issue_comments

Autocomplete indeed works in ipython, but it doesn't seem to work for accessors in my emacs configuration (lsp-mode / lsp-python-ms / python-language-server). I haven't checked in VSCode / LSP. I'll investigate this later, it's likely an issue external to xarray.

You are right. The autocomplete does work. I had a problem in my script.

that works for me, too. I moved the accessor code into a file, then imported it: ```python In [1]: import xarray as xr ...: import numpy as np ...: import custom_accessor

In [2]: ds = xr.Dataset( ...: {"a": (("latitude", "longitude"), np.linspace(0, 1, 5 * 10).reshape(5, 10))}, ...: coords={"latitude": np.arange(5), "longitude": np.arange(10)}, ...: )

In [3]: # ds.geo.c<TAB> ...: ds.geo.center Out[3]: (2.0, 4.5) `` It also works with the builtinstr,dtandplotDataArrayaccessors (just not if I'm trying to access theDataArrays from aDataset` as described above).

Edit: does your accessor work, i.e. does ds.geo.center return something?

I can reproduce your first code perfect fine in ipython, with autocomplete. However, we're defining an accessor in ipython. It seems if an accessor is used in a module and that module imported to ipython the autocomplete doesn't work. It's like ipython can't "see" the functions in the accessor's class until runtime.

This already works for me in a IPython shell (jedi 0.15.1, ipython 7.9.0): ```python In [1]: import xarray as xr ...: import numpy as np

In [2]: @xr.register_dataset_accessor("geo") ...: class GeoAccessor: ...: def init(self, xarray_obj): ...: self._obj = xarray_obj ...: ...: @property ...: def center(self): ...: # return the geographic center point of this dataset ...: lon = self._obj.latitude ...: lat = self._obj.longitude ...: return (float(lon.mean()), float(lat.mean())) ...: ...: def plot(self): ...: # plot this array's data on a map, e.g., using Cartopy ...: pass ...:

In [3]: ds = xr.Dataset( ...: {"a": (("latitude", "longitude"), np.linspace(0, 1, 5 * 10).reshape(5, 10))}, ...: coords={"latitude": np.arange(5), "longitude": np.arange(10)}, ...: )

In [4]: # ds.geo.c<TAB>: ...: ds.geo.center Out[4]: (2.0, 4.5) ``` Am I missing something?

Edit: what does not work is something like ```python In [5]: ds = xr.Dataset( ...: {"a": (("latitude", "longitude"), np.linspace(0, 1, 5 * 10).reshape(5, 10))}, ...: coords={ ...: "latitude": np.arange(5), ...: "longitude": np.arange(10), ...: "time": np.datetime64("1999-01-01"), ...: }, ...: )

In [6]: # ds.time.dt.y<TAB> ...: ds.time.dt.y

In [7]: time = ds.time ...: # time.dt.y<TAB> ...: time.dt.year `` so it's not possible to autocompleteDataArrayaccessors viagetattronDataset`.

That would be great if it could work in ipython and elsewhere too (e.g., IDEs, etc.). I guess it might be worth having a look at jedi and see if this could be easily fixed.