issue_comments

Table actions

12 rows where issue = 536214141 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 4

author_association 2

issue 1

  • Fix zarr append with groups · 12 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
593375156 https://github.com/pydata/xarray/pull/3610#issuecomment-593375156 https://api.github.com/repos/pydata/xarray/issues/3610 MDEyOklzc3VlQ29tbWVudDU5MzM3NTE1Ng== dcherian 2448579 2020-03-02T12:19:06Z 2020-03-02T12:19:06Z MEMBER

All tests are green. Thanks @niowniow. I see this is your first contribution. Welcome!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix zarr append with groups 536214141
591579373 https://github.com/pydata/xarray/pull/3610#issuecomment-591579373 https://api.github.com/repos/pydata/xarray/issues/3610 MDEyOklzc3VlQ29tbWVudDU5MTU3OTM3Mw== keewis 14808389 2020-02-26T18:43:03Z 2020-02-26T18:43:03Z MEMBER

it's here: /home/vsts/work/1/s/doc/faq.rst:239: WARNING: undefined label: api (if the link has no caption the label must precede a section header) not sure if the intersphinx warning also makes the build fail, but that could be fixed by rerunning. The deprecation warning is not a problem.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix zarr append with groups 536214141
591576949 https://github.com/pydata/xarray/pull/3610#issuecomment-591576949 https://api.github.com/repos/pydata/xarray/issues/3610 MDEyOklzc3VlQ29tbWVudDU5MTU3Njk0OQ== rabernat 1197350 2020-02-26T18:37:43Z 2020-02-26T18:37:43Z MEMBER

the docs failure (referencing api using :ref: instead of :doc:) does not seem to happen with other PRs (I also can't reproduce it locally

I can't find that message here: https://dev.azure.com/xarray/xarray/_build/results?buildId=2214&view=logs&jobId=7e620c85-24a8-5ffa-8b1f-642bc9b1fc36&j=7e620c85-24a8-5ffa-8b1f-642bc9b1fc36&t=68484831-0a19-5145-bfe9-6309e5f7691d

To me it looks like the doc build failed due to two warnings: failure to fetch the pandas intersphinx obj and a sphinx deprecation warning about scripts.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix zarr append with groups 536214141
591550375 https://github.com/pydata/xarray/pull/3610#issuecomment-591550375 https://api.github.com/repos/pydata/xarray/issues/3610 MDEyOklzc3VlQ29tbWVudDU5MTU1MDM3NQ== keewis 14808389 2020-02-26T17:38:09Z 2020-02-26T17:38:09Z MEMBER

the upstream-dev failure is #3751, but although there should be no change here that would trigger it, the docs failure (referencing api using :ref: instead of :doc:) does not seem to happen with other PRs (I also can't reproduce it locally).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix zarr append with groups 536214141
591222407 https://github.com/pydata/xarray/pull/3610#issuecomment-591222407 https://api.github.com/repos/pydata/xarray/issues/3610 MDEyOklzc3VlQ29tbWVudDU5MTIyMjQwNw== rabernat 1197350 2020-02-26T03:38:20Z 2020-02-26T03:38:20Z MEMBER

@dcherian - I assume these test failures (py38-upstream-dev and docs) are acceptable? They seem unrelated to the PR.

If so, please merge.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix zarr append with groups 536214141
573070906 https://github.com/pydata/xarray/pull/3610#issuecomment-573070906 https://api.github.com/repos/pydata/xarray/issues/3610 MDEyOklzc3VlQ29tbWVudDU3MzA3MDkwNg== keewis 14808389 2020-01-10T15:04:36Z 2020-01-10T15:04:36Z MEMBER

Looks good to me. However, I don't know much about backends so I'll let someone else review the code.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix zarr append with groups 536214141
573060295 https://github.com/pydata/xarray/pull/3610#issuecomment-573060295 https://api.github.com/repos/pydata/xarray/issues/3610 MDEyOklzc3VlQ29tbWVudDU3MzA2MDI5NQ== niowniow 5802846 2020-01-10T14:38:03Z 2020-01-10T14:38:03Z CONTRIBUTOR

Okay, this looks better. Thanks for the help! I had to try it again myself, because you cherry-picked some commits I accidentally merged into this branch (non-related to this fix). Could you check if this is good now?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix zarr append with groups 536214141
573038056 https://github.com/pydata/xarray/pull/3610#issuecomment-573038056 https://api.github.com/repos/pydata/xarray/issues/3610 MDEyOklzc3VlQ29tbWVudDU3MzAzODA1Ng== keewis 14808389 2020-01-10T13:37:01Z 2020-01-10T13:37:01Z MEMBER

I cherry-picked your commits, but I'm not sure I included all the changes. Could you check that?

Also, I can't seem to figure out how to push to this PR, so you will have to do that instead: ```bash git checkout fix_zarr_append_with_groups

backup branch

git branch backup_fix_zarr_append_with_groups

delete branch

git checkout master git branch -D fix_zarr_append_with_groups

checkout fixed branch

git checkout --track origin/fix_zarr_append_with_groups

force push

git push -f <fork-remote> fix_zarr_append_with_groups ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix zarr append with groups 536214141
573021208 https://github.com/pydata/xarray/pull/3610#issuecomment-573021208 https://api.github.com/repos/pydata/xarray/issues/3610 MDEyOklzc3VlQ29tbWVudDU3MzAyMTIwOA== niowniow 5802846 2020-01-10T12:44:05Z 2020-01-10T12:44:05Z CONTRIBUTOR

I don't mind, thanks :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix zarr append with groups 536214141
573020875 https://github.com/pydata/xarray/pull/3610#issuecomment-573020875 https://api.github.com/repos/pydata/xarray/issues/3610 MDEyOklzc3VlQ29tbWVudDU3MzAyMDg3NQ== keewis 14808389 2020-01-10T12:43:04Z 2020-01-10T12:43:04Z MEMBER

If you don't mind I'll try to fix that for you.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix zarr append with groups 536214141
573019892 https://github.com/pydata/xarray/pull/3610#issuecomment-573019892 https://api.github.com/repos/pydata/xarray/issues/3610 MDEyOklzc3VlQ29tbWVudDU3MzAxOTg5Mg== niowniow 5802846 2020-01-10T12:39:58Z 2020-01-10T12:39:58Z CONTRIBUTOR

I tried to merge with master yesterday and did it again today. There might be a problem with the way I tried to fix the whats-new.rst issues. It might be faster if I open a new pull request and re-insert the changes!?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix zarr append with groups 536214141
572610130 https://github.com/pydata/xarray/pull/3610#issuecomment-572610130 https://api.github.com/repos/pydata/xarray/issues/3610 MDEyOklzc3VlQ29tbWVudDU3MjYxMDEzMA== dcherian 2448579 2020-01-09T15:24:35Z 2020-01-09T15:24:35Z MEMBER

@niowniow can you merge master please? The diff is huge right now

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix zarr append with groups 536214141

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);