issue_comments

Table actions

3 rows where issue = 535686852 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Strided rolling · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1462754116 https://github.com/pydata/xarray/pull/3607#issuecomment-1462754116 https://api.github.com/repos/pydata/xarray/issues/3607 IC_kwDOAMm_X85XL9tE headtr1ck 43316012 2023-03-09T20:37:18Z 2023-03-09T20:37:18Z COLLABORATOR

Is that still wanted? It seems like a useful feature to have.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Strided rolling 535686852
851459023 https://github.com/pydata/xarray/pull/3607#issuecomment-851459023 https://api.github.com/repos/pydata/xarray/issues/3607 MDEyOklzc3VlQ29tbWVudDg1MTQ1OTAyMw== pep8speaks 24736507 2021-05-31T12:31:28Z 2021-05-31T12:39:49Z NONE

Hello @niowniow! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-05-31 12:39:49 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Strided rolling 535686852
564303463 https://github.com/pydata/xarray/pull/3607#issuecomment-564303463 https://api.github.com/repos/pydata/xarray/issues/3607 MDEyOklzc3VlQ29tbWVudDU2NDMwMzQ2Mw== fujiisoup 6815844 2019-12-10T23:16:51Z 2019-12-10T23:16:51Z MEMBER

@niowniow Thank you for your contribution!

I think stride option is a good idea. One thing is how to implement this efficient nan-reduction method.

Currently, we use 'bottleneck' if it is installed for speeding up nan-ops, but bottleneck does not support stride option. Another problem is inefficiency of nan-ops of numpy for strided arrays; he copies the strided array into full array and replace np.nan by zero before the reduction.

One way we could do is 1. skip using 'bottleneck' if stride is other than 1 2. implement our nan-ops for rolling. For example, for nansum, we can replace np.nan by 0 before creating the strided arrays and apply usual sum for the strided array.

In rolling.count, we did a similar thing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Strided rolling 535686852

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);