issue_comments

Table actions

7 rows where issue = 532696790 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • support for units with pint · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1203841940 https://github.com/pydata/xarray/issues/3594#issuecomment-1203841940 https://api.github.com/repos/pydata/xarray/issues/3594 IC_kwDOAMm_X85HwSuU keewis 14808389 2022-08-03T11:43:50Z 2022-08-03T11:44:05Z MEMBER

6873 might fix the nanprod issue, and we have a separate issue for the last big change left (#3950, which is not really limited to quantities) so I agree that we should be able to close this with #6873.

We might want to open a new issue to get the known issues to work, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   support for units with pint 532696790
1190681030 https://github.com/pydata/xarray/issues/3594#issuecomment-1190681030 https://api.github.com/repos/pydata/xarray/issues/3594 IC_kwDOAMm_X85G-FnG dcherian 2448579 2022-07-20T19:40:45Z 2022-07-20T19:40:45Z MEMBER

@keewis Shall we close this? It seems the only outstanding one is nanprod with quantities. Which sort of indicates that we've made the necessary big changes.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
   support for units with pint 532696790
653230116 https://github.com/pydata/xarray/issues/3594#issuecomment-653230116 https://api.github.com/repos/pydata/xarray/issues/3594 MDEyOklzc3VlQ29tbWVudDY1MzIzMDExNg== keewis 14808389 2020-07-02T21:34:05Z 2020-07-02T21:35:56Z MEMBER

so, except from the major issues mentioned above which we won't be able to fix in the near future (but there will probably be workarounds in pint-xarray) we only have three minor issues: nanprod, support for per variable fill values and the repr (#2773).

I don't think nanprod and the fill values are particularly urgent, so if we get support for the repr (maybe using some sort of hook that a library like pint-xarray can then use to properly format the duckarray) and put together the documentation page, we could include this in the 0.16 release.

Edit: I guess the release is already big enough so I don't really mind waiting on the next release, but this is really close.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   support for units with pint 532696790
597873960 https://github.com/pydata/xarray/issues/3594#issuecomment-597873960 https://api.github.com/repos/pydata/xarray/issues/3594 MDEyOklzc3VlQ29tbWVudDU5Nzg3Mzk2MA== keewis 14808389 2020-03-11T20:55:05Z 2020-03-11T20:55:48Z MEMBER

I think issues related to DataArray + pint should be in #3643, for everything else you can use this issue or new issues / pull requests.

If you want to, I'd appreciate someone reviewing the tests in test_units.py since I don't think anyone other than me thoroughly looked at all of them. You could also investigate / fix the Dataset issues, investigate the reason for the UnitStrippedWarnings or start writing documentation on how to use pint in combination with xarray.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   support for units with pint 532696790
597867455 https://github.com/pydata/xarray/issues/3594#issuecomment-597867455 https://api.github.com/repos/pydata/xarray/issues/3594 MDEyOklzc3VlQ29tbWVudDU5Nzg2NzQ1NQ== amcnicho 29958771 2020-03-11T20:39:09Z 2020-03-11T20:39:09Z CONTRIBUTOR

I will try to figure out the reason for each of these test failures, but I'd appreciate help.

Would #3643 be the best place to offer contributions at this point, or somewhere else?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   support for units with pint 532696790
561705235 https://github.com/pydata/xarray/issues/3594#issuecomment-561705235 https://api.github.com/repos/pydata/xarray/issues/3594 MDEyOklzc3VlQ29tbWVudDU2MTcwNTIzNQ== keewis 14808389 2019-12-04T15:50:06Z 2019-12-04T15:50:06Z MEMBER

What does this mean? You can't have units in a IndexVariable?

yes, we had that discussion from https://github.com/pydata/xarray/issues/525#issuecomment-514452182 on. Short version: pd.Index converts using np.asarray and support for units probably requires #1603.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   support for units with pint 532696790
561703294 https://github.com/pydata/xarray/issues/3594#issuecomment-561703294 https://api.github.com/repos/pydata/xarray/issues/3594 MDEyOklzc3VlQ29tbWVudDU2MTcwMzI5NA== dcherian 2448579 2019-12-04T15:45:40Z 2019-12-04T15:45:54Z MEMBER

Thanks for leading this effort @keewis.

I would start with the lowest-level operations like the constructors and align, concat, merge. These are called in many of the other functions so fixing these is a prerequisite for getting the rest working. I've looked at align, concat & merge recently so can help if you need to chat about confusing error messages.

indexes strip units

What does this mean? You can't have units in a IndexVariable?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   support for units with pint 532696790

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);