issue_comments

Table actions

5 rows where issue = 532165408 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • cmap.set_under() does not work as expected · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
572667885 https://github.com/pydata/xarray/issues/3590#issuecomment-572667885 https://api.github.com/repos/pydata/xarray/issues/3590 MDEyOklzc3VlQ29tbWVudDU3MjY2Nzg4NQ== mathause 10194086 2020-01-09T17:29:57Z 2020-01-09T17:29:57Z MEMBER

As a workaround (until #3601) is finished you can do:

``` python import matplotlib from matplotlib import pyplot from xarray import DataArray import numpy

da = DataArray(numpy.linspace(0, 1)[numpy.newaxis, :]*numpy.linspace(0, 1)[:, numpy.newaxis])

cmap = matplotlib.cm.viridis

h = da.plot.contourf(vmin=.3, cmap=cmap)

cmap = h.get_cmap() cmap.set_under('w')

h.set_cmap(cmap) ```

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   cmap.set_under() does not work as expected 532165408
562578478 https://github.com/pydata/xarray/issues/3590#issuecomment-562578478 https://api.github.com/repos/pydata/xarray/issues/3590 MDEyOklzc3VlQ29tbWVudDU2MjU3ODQ3OA== johnomotani 3958036 2019-12-06T13:49:36Z 2019-12-06T13:49:36Z CONTRIBUTOR

Looks like that was it, thanks @dcherian!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   cmap.set_under() does not work as expected 532165408
561366760 https://github.com/pydata/xarray/issues/3590#issuecomment-561366760 https://api.github.com/repos/pydata/xarray/issues/3590 MDEyOklzc3VlQ29tbWVudDU2MTM2Njc2MA== dcherian 2448579 2019-12-03T21:33:23Z 2019-12-03T21:33:23Z MEMBER

No that's for dataset plotting and is a norm for size of points plotted by scatter.

I would look here: https://github.com/pydata/xarray/blob/ed05f9862622b00f40f7b9b99ccdb0ab3766ff0f/xarray/plot/utils.py#L77-L101

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   cmap.set_under() does not work as expected 532165408
561358453 https://github.com/pydata/xarray/issues/3590#issuecomment-561358453 https://api.github.com/repos/pydata/xarray/issues/3590 MDEyOklzc3VlQ29tbWVudDU2MTM1ODQ1Mw== johnomotani 3958036 2019-12-03T21:10:58Z 2019-12-03T21:10:58Z CONTRIBUTOR

Might be somethnig to do with https://github.com/pydata/xarray/blob/ed05f9862622b00f40f7b9b99ccdb0ab3766ff0f/xarray/plot/dataset_plot.py#L137 ?

The docstring for matplotlib.colors.Normalize says

If clip is True, masked values are set to 1; otherwise they remain masked. Clipping silently defeats the purpose of setting the over, under, and masked colors in the colormap, so it is likely to lead to surprises; therefore the default is clip = False.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   cmap.set_under() does not work as expected 532165408
561314623 https://github.com/pydata/xarray/issues/3590#issuecomment-561314623 https://api.github.com/repos/pydata/xarray/issues/3590 MDEyOklzc3VlQ29tbWVudDU2MTMxNDYyMw== dcherian 2448579 2019-12-03T19:15:20Z 2019-12-03T19:15:20Z MEMBER

Thanks for the report @johnomotani. I expect we are recreating the colormap from scratch somewhere in plot/utils.py

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   cmap.set_under() does not work as expected 532165408

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);