issue_comments

Table actions

4 rows where issue = 531087939 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • boundary options for rolling.construct · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
747665480 https://github.com/pydata/xarray/pull/3587#issuecomment-747665480 https://api.github.com/repos/pydata/xarray/issues/3587 MDEyOklzc3VlQ29tbWVudDc0NzY2NTQ4MA== fujiisoup 6815844 2020-12-17T19:55:36Z 2020-12-17T19:55:36Z MEMBER

I was thinking to wait for the pad method implemented but forgot until now. I am not sure this is easily merginable, as the rolling.py has been updated for a while...

The first motivation was to implement the rolling operation for the periodic coordinate, but it is not yet implemented.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   boundary options for rolling.construct 531087939
747302848 https://github.com/pydata/xarray/pull/3587#issuecomment-747302848 https://api.github.com/repos/pydata/xarray/issues/3587 MDEyOklzc3VlQ29tbWVudDc0NzMwMjg0OA== mathause 10194086 2020-12-17T08:53:21Z 2020-12-17T08:53:21Z MEMBER

@fujiisoup I would eventually like to pick this one up. Can you remember what was missing? Mostly the tests?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   boundary options for rolling.construct 531087939
561648997 https://github.com/pydata/xarray/pull/3587#issuecomment-561648997 https://api.github.com/repos/pydata/xarray/issues/3587 MDEyOklzc3VlQ29tbWVudDU2MTY0ODk5Nw== mathause 10194086 2019-12-04T13:37:27Z 2019-12-04T13:37:27Z MEMBER

Thanks for picking this up - excited to get this in! Are you able to get it to work with dask arrays? (That was the stopper in my PR.) Or maybe you can require that dask arrays are not chunked along the rolling dimension?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   boundary options for rolling.construct 531087939
560385400 https://github.com/pydata/xarray/pull/3587#issuecomment-560385400 https://api.github.com/repos/pydata/xarray/issues/3587 MDEyOklzc3VlQ29tbWVudDU2MDM4NTQwMA== pep8speaks 24736507 2019-12-02T12:57:37Z 2019-12-03T05:17:40Z NONE

Hello @fujiisoup! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-12-03 05:17:40 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   boundary options for rolling.construct 531087939

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);