issue_comments

Table actions

4 rows where issue = 523878167 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

issue 1

  • Minor fix to combine_by_coords to allow for the combination of CFTimeIndexes separated by large time intervals · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
562884213 https://github.com/pydata/xarray/pull/3543#issuecomment-562884213 https://api.github.com/repos/pydata/xarray/issues/3543 MDEyOklzc3VlQ29tbWVudDU2Mjg4NDIxMw== dcherian 2448579 2019-12-07T20:37:53Z 2019-12-07T20:37:53Z MEMBER

test failure is #3603 . Thanks @spencerkclark for the fix, @TomNicholas for reviewing and @mathause for testing!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Minor fix to combine_by_coords to allow for the combination of CFTimeIndexes separated by large time intervals 523878167
562857806 https://github.com/pydata/xarray/pull/3543#issuecomment-562857806 https://api.github.com/repos/pydata/xarray/issues/3543 MDEyOklzc3VlQ29tbWVudDU2Mjg1NzgwNg== TomNicholas 35968931 2019-12-07T14:54:49Z 2019-12-07T14:54:49Z MEMBER

I think this should be fine...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Minor fix to combine_by_coords to allow for the combination of CFTimeIndexes separated by large time intervals 523878167
557523107 https://github.com/pydata/xarray/pull/3543#issuecomment-557523107 https://api.github.com/repos/pydata/xarray/issues/3543 MDEyOklzc3VlQ29tbWVudDU1NzUyMzEwNw== spencerkclark 6628425 2019-11-22T13:02:06Z 2019-11-22T13:02:06Z MEMBER

@TomNicholas I'm comforted by the fact that this does not seem to break any existing tests, but does it look OK to you?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Minor fix to combine_by_coords to allow for the combination of CFTimeIndexes separated by large time intervals 523878167
557203189 https://github.com/pydata/xarray/pull/3543#issuecomment-557203189 https://api.github.com/repos/pydata/xarray/issues/3543 MDEyOklzc3VlQ29tbWVudDU1NzIwMzE4OQ== mathause 10194086 2019-11-21T18:01:55Z 2019-11-21T18:01:55Z MEMBER

Thanks. Just for reference, the current implementation leads to a series of CFTimeIndex (which fails when subtracting one from the other):

``` python pd.Index([index.take([0]) for index in indexes]).to_series()

[4500-12-31 00:00:00] CFTimeIndex([4500-12-31 00:00:00], dtype='obje... [4600-12-31 00:00:00] CFTimeIndex([4600-12-31 00:00:00], dtype='obje... [5100-12-31 00:00:00] CFTimeIndex([5100-12-31 00:00:00], dtype='obje... dtype: object ``` The implementation in this PR leads to a series of CFTime (and subtracting one from the other works):

``` python pd.Index([index[0] for index in indexes]).to_series()

4500-12-31 00:00:00 4500-12-31 00:00:00 4600-12-31 00:00:00 4600-12-31 00:00:00 5100-12-31 00:00:00 5100-12-31 00:00:00 dtype: object ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Minor fix to combine_by_coords to allow for the combination of CFTimeIndexes separated by large time intervals 523878167

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);