issue_comments

Table actions

3 rows where issue = 522402552 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • CFTimeIndex changes to normal Index after renaming · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
553559886 https://github.com/pydata/xarray/issues/3522#issuecomment-553559886 https://api.github.com/repos/pydata/xarray/issues/3522 MDEyOklzc3VlQ29tbWVudDU1MzU1OTg4Ng== max-sixty 5635139 2019-11-13T19:24:44Z 2019-11-13T19:24:44Z MEMBER

Nice spot @mathause . We should be constructing from the type of v. pd.Index also has a method _shallow_copy IIRC we could call

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CFTimeIndex changes to normal Index after renaming 522402552
553553330 https://github.com/pydata/xarray/issues/3522#issuecomment-553553330 https://api.github.com/repos/pydata/xarray/issues/3522 MDEyOklzc3VlQ29tbWVudDU1MzU1MzMzMA== mathause 10194086 2019-11-13T19:07:16Z 2019-11-13T19:14:48Z MEMBER

The culprit may be in ds._rename_indexes:

https://github.com/pydata/xarray/blob/40588dc38ddc2d573e3dc8c63b2e6533eb978656/xarray/core/dataset.py#L2662

where the index gets piped through pd.Index (even if it is not renamed):

python import pandas as pd pd.Index(ds.indexes['time']) returns an Index instead of a CFTimeIndex

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CFTimeIndex changes to normal Index after renaming 522402552
553553607 https://github.com/pydata/xarray/issues/3522#issuecomment-553553607 https://api.github.com/repos/pydata/xarray/issues/3522 MDEyOklzc3VlQ29tbWVudDU1MzU1MzYwNw== keewis 14808389 2019-11-13T19:07:58Z 2019-11-13T19:07:58Z MEMBER

also, you can simplify that to python print( ds.indexes, ds.rename().indexes, ds.rename_dims().indexes, ds.rename_vars().indexes, sep="\n", ) and the type of the index still gets dropped (on master)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CFTimeIndex changes to normal Index after renaming 522402552

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);