issue_comments

Table actions

11 rows where issue = 515662368 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • drop_vars; deprecate drop for variables · 11 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
551311482 https://github.com/pydata/xarray/pull/3475#issuecomment-551311482 https://api.github.com/repos/pydata/xarray/issues/3475 MDEyOklzc3VlQ29tbWVudDU1MTMxMTQ4Mg== shoyer 1217238 2019-11-07T23:20:40Z 2019-11-07T23:20:40Z MEMBER

Thank you @max-sixty, and @dcherian for reviewing!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   drop_vars; deprecate drop for variables 515662368
551244548 https://github.com/pydata/xarray/pull/3475#issuecomment-551244548 https://api.github.com/repos/pydata/xarray/issues/3475 MDEyOklzc3VlQ29tbWVudDU1MTI0NDU0OA== max-sixty 5635139 2019-11-07T20:13:42Z 2019-11-07T20:13:42Z MEMBER

Going to merge given @dcherian 's approval, any other follow-ups I can address in another PR

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   drop_vars; deprecate drop for variables 515662368
551185004 https://github.com/pydata/xarray/pull/3475#issuecomment-551185004 https://api.github.com/repos/pydata/xarray/issues/3475 MDEyOklzc3VlQ29tbWVudDU1MTE4NTAwNA== max-sixty 5635139 2019-11-07T17:36:42Z 2019-11-07T17:36:42Z MEMBER

This is ready to go!

As a reminder, we have PendingDeprecationWarning for drop, which is ignored in user code by default. It does appear in tests, so let me know if that's too strong given the above discussion on backward-compat.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   drop_vars; deprecate drop for variables 515662368
550516099 https://github.com/pydata/xarray/pull/3475#issuecomment-550516099 https://api.github.com/repos/pydata/xarray/issues/3475 MDEyOklzc3VlQ29tbWVudDU1MDUxNjA5OQ== dcherian 2448579 2019-11-06T21:49:43Z 2019-11-06T21:49:43Z MEMBER

:+1:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   drop_vars; deprecate drop for variables 515662368
550499576 https://github.com/pydata/xarray/pull/3475#issuecomment-550499576 https://api.github.com/repos/pydata/xarray/issues/3475 MDEyOklzc3VlQ29tbWVudDU1MDQ5OTU3Ng== shoyer 1217238 2019-11-06T21:04:12Z 2019-11-06T21:04:12Z MEMBER

I wanted a name that is reminiscent of "sel" in some way.

On Wed, Nov 6, 2019 at 7:14 AM Deepak Cherian notifications@github.com wrote:

Add drop_sel for dropping labels

Would drop_labels be better?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/3475?email_source=notifications&email_token=AAJJFVVMPYUZS37B4BW2C43QSLNOPA5CNFSM4JHQAN7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDG4BNQ#issuecomment-550355126, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJJFVQKLRALMGU5ALWKWVLQSLNOPANCNFSM4JHQAN7A . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   drop_vars; deprecate drop for variables 515662368
550499180 https://github.com/pydata/xarray/pull/3475#issuecomment-550499180 https://api.github.com/repos/pydata/xarray/issues/3475 MDEyOklzc3VlQ29tbWVudDU1MDQ5OTE4MA== max-sixty 5635139 2019-11-06T21:03:07Z 2019-11-06T21:03:07Z MEMBER

Would drop_labels be better?

I think either is reasonable. drop_sel has the advantage that it's easily comparable to sel, and has the same arguments, so I'd marginally vote for that. Am easily swayed by popular opinion!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   drop_vars; deprecate drop for variables 515662368
550355126 https://github.com/pydata/xarray/pull/3475#issuecomment-550355126 https://api.github.com/repos/pydata/xarray/issues/3475 MDEyOklzc3VlQ29tbWVudDU1MDM1NTEyNg== dcherian 2448579 2019-11-06T15:14:46Z 2019-11-06T15:14:46Z MEMBER

Add drop_sel for dropping labels

Would drop_labels be better?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   drop_vars; deprecate drop for variables 515662368
550086071 https://github.com/pydata/xarray/pull/3475#issuecomment-550086071 https://api.github.com/repos/pydata/xarray/issues/3475 MDEyOklzc3VlQ29tbWVudDU1MDA4NjA3MQ== max-sixty 5635139 2019-11-06T00:29:42Z 2019-11-06T00:29:42Z MEMBER

@crusaderky let me know if you know off-hand why the MinimumVersionsPolicy is breaking, otherwise I can look into it

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   drop_vars; deprecate drop for variables 515662368
550083850 https://github.com/pydata/xarray/pull/3475#issuecomment-550083850 https://api.github.com/repos/pydata/xarray/issues/3475 MDEyOklzc3VlQ29tbWVudDU1MDA4Mzg1MA== max-sixty 5635139 2019-11-06T00:20:12Z 2019-11-06T00:20:12Z MEMBER

Updated! I used PendingDeprecationWarning, which is default disabled.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   drop_vars; deprecate drop for variables 515662368
549655830 https://github.com/pydata/xarray/pull/3475#issuecomment-549655830 https://api.github.com/repos/pydata/xarray/issues/3475 MDEyOklzc3VlQ29tbWVudDU0OTY1NTgzMA== max-sixty 5635139 2019-11-05T04:15:05Z 2019-11-05T04:15:05Z MEMBER

Yes, that sounds reasonable—I think we move documentation and internal usages to drop_sel and drop_vars, and leave drop as a backward compatible option?

Maybe at last a case for FutureDeprecationWarning :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   drop_vars; deprecate drop for variables 515662368
549628677 https://github.com/pydata/xarray/pull/3475#issuecomment-549628677 https://api.github.com/repos/pydata/xarray/issues/3475 MDEyOklzc3VlQ29tbWVudDU0OTYyODY3Nw== shoyer 1217238 2019-11-05T01:55:38Z 2019-11-05T01:55:38Z MEMBER

What do you think about this alternative?

  • Add drop_sel for dropping labels
  • Add drop_vars for variables.
  • Keep around drop as an overloaded alias for both?

(I'm not really sure which is best, to be honest. But keeping down churn does seem like a good idea, if possible.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   drop_vars; deprecate drop for variables 515662368

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);