issue_comments

Table actions

10 rows where issue = 514191264 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Poor error message on Dataset.sum(axis=...) · 10 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
547626517 https://github.com/pydata/xarray/issues/3461#issuecomment-547626517 https://api.github.com/repos/pydata/xarray/issues/3461 MDEyOklzc3VlQ29tbWVudDU0NzYyNjUxNw== max-sixty 5635139 2019-10-29T20:58:36Z 2019-10-29T20:58:36Z MEMBER

OK, good points

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Poor error message on Dataset.sum(axis=...) 514191264
547620729 https://github.com/pydata/xarray/issues/3461#issuecomment-547620729 https://api.github.com/repos/pydata/xarray/issues/3461 MDEyOklzc3VlQ29tbWVudDU0NzYyMDcyOQ== crusaderky 6213168 2019-10-29T20:43:34Z 2019-10-29T20:43:34Z MEMBER

I think there's space here to make xarray more user friendly. A better error message would particularly be useful with new xarray users which are used to numpy and pandas - which is the most common new user profile TBH.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Poor error message on Dataset.sum(axis=...) 514191264
547619497 https://github.com/pydata/xarray/issues/3461#issuecomment-547619497 https://api.github.com/repos/pydata/xarray/issues/3461 MDEyOklzc3VlQ29tbWVudDU0NzYxOTQ5Nw== rpgoldman 3274 2019-10-29T20:40:35Z 2019-10-29T20:40:35Z CONTRIBUTOR

I guess so. Minor preference for checking for inappropriate numpy errors like this and giving a better error message, but I can see this would be difficult.

This won't be the first bewildering error message problem from **kwargs, and it won't be the last. This is a python problem, not an xarray one, per se.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Poor error message on Dataset.sum(axis=...) 514191264
547618326 https://github.com/pydata/xarray/issues/3461#issuecomment-547618326 https://api.github.com/repos/pydata/xarray/issues/3461 MDEyOklzc3VlQ29tbWVudDU0NzYxODMyNg== max-sixty 5635139 2019-10-29T20:37:39Z 2019-10-29T20:37:39Z MEMBER

I think given we're not in full control of the sum function and it's relatively rare to pass axis, it's OK to close; is that OK?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Poor error message on Dataset.sum(axis=...) 514191264
547614151 https://github.com/pydata/xarray/issues/3461#issuecomment-547614151 https://api.github.com/repos/pydata/xarray/issues/3461 MDEyOklzc3VlQ29tbWVudDU0NzYxNDE1MQ== crusaderky 6213168 2019-10-29T20:27:14Z 2019-10-29T20:33:27Z MEMBER

@rpgoldman if you want to do an elementwise sum of the data_vars of a Dataset, it's as simple as sum(ds.data_vars.values()). Dataset.sum() is not elementwise - it's a reduction along one or more axes - exactly like in numpy.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Poor error message on Dataset.sum(axis=...) 514191264
547614650 https://github.com/pydata/xarray/issues/3461#issuecomment-547614650 https://api.github.com/repos/pydata/xarray/issues/3461 MDEyOklzc3VlQ29tbWVudDU0NzYxNDY1MA== rpgoldman 3274 2019-10-29T20:28:30Z 2019-10-29T20:28:30Z CONTRIBUTOR

@crusaderky Thanks. Yes, that was exactly what I was trying to do.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Poor error message on Dataset.sum(axis=...) 514191264
547614052 https://github.com/pydata/xarray/issues/3461#issuecomment-547614052 https://api.github.com/repos/pydata/xarray/issues/3461 MDEyOklzc3VlQ29tbWVudDU0NzYxNDA1Mg== rpgoldman 3274 2019-10-29T20:27:00Z 2019-10-29T20:27:00Z CONTRIBUTOR

@crusaderky I see what I did wrong. I mistakenly read the documentation page for DataArray.sum() instead of DataSet.sum(). The former does support an axis argument, and I believe it makes sense there.

Blacklisting these arguments sounds like a great idea, thanks.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Poor error message on Dataset.sum(axis=...) 514191264
547613150 https://github.com/pydata/xarray/issues/3461#issuecomment-547613150 https://api.github.com/repos/pydata/xarray/issues/3461 MDEyOklzc3VlQ29tbWVudDU0NzYxMzE1MA== crusaderky 6213168 2019-10-29T20:24:50Z 2019-10-29T20:24:50Z MEMBER

It's a case of improper error message.

I don't think anybody ever thought of passing the axis parameter to any of the Dataset methods before. As a general rule, it would be a very unwise idea unless you're sure that all of your data_vars have the required dimension exactly in the same position.

Note the documentation for Dataset.sum vs. DataArray.sum:

http://xarray.pydata.org/en/stable/generated/xarray.Dataset.sum.html http://xarray.pydata.org/en/stable/generated/xarray.DataArray.sum.html

You were able to pass the axis parameter because Dataset.sum accepts **kwargs, which are intended for backend-specific arguments (e.g. dask's split_every parameter).

The solution is to blacklist a bunch of numpy arguments that don't make sense (axis is one, but out also comes to mind).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Poor error message on Dataset.sum(axis=...) 514191264
547612958 https://github.com/pydata/xarray/issues/3461#issuecomment-547612958 https://api.github.com/repos/pydata/xarray/issues/3461 MDEyOklzc3VlQ29tbWVudDU0NzYxMjk1OA== rpgoldman 3274 2019-10-29T20:24:25Z 2019-10-29T20:24:25Z CONTRIBUTOR

@max-sixty I was trying to sum across the data variables, rather than across a dimension.

What I ended up doing was taking the data for each of the data variables and adding the resulting numpy arrays. This gave me the sum across the data variables, along the dim (each data variable is one dimensional and they share a single dimension).

I'm not sure how to suggest fixing the error message, because I'm not sure what xarray doesn't like.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Poor error message on Dataset.sum(axis=...) 514191264
547611830 https://github.com/pydata/xarray/issues/3461#issuecomment-547611830 https://api.github.com/repos/pydata/xarray/issues/3461 MDEyOklzc3VlQ29tbWVudDU0NzYxMTgzMA== max-sixty 5635139 2019-10-29T20:21:32Z 2019-10-29T20:21:32Z MEMBER

It's a bad error message. But the error is correct, I think. Why do you want to use axis rather than dim? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Poor error message on Dataset.sum(axis=...) 514191264

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);