issue_comments

Table actions

7 rows where issue = 514164837 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • fix test suite warnings re `drop` · 7 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
548213907 https://github.com/pydata/xarray/pull/3460#issuecomment-548213907 https://api.github.com/repos/pydata/xarray/issues/3460 MDEyOklzc3VlQ29tbWVudDU0ODIxMzkwNw== shoyer 1217238 2019-10-31T04:39:11Z 2019-10-31T04:39:11Z MEMBER

Yeah, that was my thought

On Wed, Oct 30, 2019 at 6:43 PM Maximilian Roos notifications@github.com wrote:

I think the idea is just to provide a more explicit option for dropping variables instead of labels. It's a little messy all in one API.

Yeah, agree it's messy. I think we could have drop_vars, completely deprecate any use of drop apart from lables, and then we're in a decent place? Or is that too much churn?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/3460?email_source=notifications&email_token=AAJJFVQCFMCNQTGOOZQ5VJTQRIZ5LA5CNFSM4JGOGT52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECWJOMA#issuecomment-548181808, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJJFVQTAUQ6ITQGU3AJ4UTQRIZ5LANCNFSM4JGOGT5Q . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix test suite warnings re `drop` 514164837
548181808 https://github.com/pydata/xarray/pull/3460#issuecomment-548181808 https://api.github.com/repos/pydata/xarray/issues/3460 MDEyOklzc3VlQ29tbWVudDU0ODE4MTgwOA== max-sixty 5635139 2019-10-31T01:43:48Z 2019-10-31T01:43:48Z MEMBER

I think the idea is just to provide a more explicit option for dropping variables instead of labels. It's a little messy all in one API.

Yeah, agree it's messy. I think we could have drop_vars, completely deprecate any use of drop apart from lables, and then we're in a decent place? Or is that too much churn?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix test suite warnings re `drop` 514164837
548181213 https://github.com/pydata/xarray/pull/3460#issuecomment-548181213 https://api.github.com/repos/pydata/xarray/issues/3460 MDEyOklzc3VlQ29tbWVudDU0ODE4MTIxMw== shoyer 1217238 2019-10-31T01:40:14Z 2019-10-31T01:40:14Z MEMBER

I think the idea is just to provide a more explicit option for dropping variables instead of labels. It's a little messy all in one API.

On Wed, Oct 30, 2019 at 6:30 PM Maximilian Roos notifications@github.com wrote:

Yes, this was a suggestion for a new method

How would this work differently from .drop(var_name)? Or would we deprecate that use of drop?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/3460?email_source=notifications&email_token=AAJJFVQVAGWK6TUU6JPFZA3QRIYMDA5CNFSM4JGOGT52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECWI3QI#issuecomment-548179393, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJJFVT7WTBA7N5VOPPRNS3QRIYMDANCNFSM4JGOGT5Q . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix test suite warnings re `drop` 514164837
548179393 https://github.com/pydata/xarray/pull/3460#issuecomment-548179393 https://api.github.com/repos/pydata/xarray/issues/3460 MDEyOklzc3VlQ29tbWVudDU0ODE3OTM5Mw== max-sixty 5635139 2019-10-31T01:30:40Z 2019-10-31T01:30:40Z MEMBER

Yes, this was a suggestion for a new method

How would this work differently from .drop(var_name)? Or would we deprecate that use of drop?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix test suite warnings re `drop` 514164837
548172110 https://github.com/pydata/xarray/pull/3460#issuecomment-548172110 https://api.github.com/repos/pydata/xarray/issues/3460 MDEyOklzc3VlQ29tbWVudDU0ODE3MjExMA== shoyer 1217238 2019-10-31T00:52:48Z 2019-10-31T00:52:48Z MEMBER

One other issue: it suggests using drop_vars but that doesn't exist!

Yes, this was a suggestion for a new method

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix test suite warnings re `drop` 514164837
548170568 https://github.com/pydata/xarray/pull/3460#issuecomment-548170568 https://api.github.com/repos/pydata/xarray/issues/3460 MDEyOklzc3VlQ29tbWVudDU0ODE3MDU2OA== max-sixty 5635139 2019-10-31T00:44:42Z 2019-10-31T00:44:42Z MEMBER

One other issue: it suggests using drop_vars but that doesn't exist!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix test suite warnings re `drop` 514164837
547593366 https://github.com/pydata/xarray/pull/3460#issuecomment-547593366 https://api.github.com/repos/pydata/xarray/issues/3460 MDEyOklzc3VlQ29tbWVudDU0NzU5MzM2Ng== max-sixty 5635139 2019-10-29T19:34:19Z 2019-10-29T19:34:19Z MEMBER

ref https://github.com/pydata/xarray/issues/3266. This was causing about a quarter of the total, because of the test's parameterization. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix test suite warnings re `drop` 514164837

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);