issue_comments

Table actions

4 rows where issue = 511477827 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Request error handling in dataarray construction · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
572259725 https://github.com/pydata/xarray/issues/3437#issuecomment-572259725 https://api.github.com/repos/pydata/xarray/issues/3437 MDEyOklzc3VlQ29tbWVudDU3MjI1OTcyNQ== dcherian 2448579 2020-01-08T21:14:27Z 2020-01-08T21:14:27Z MEMBER

A quick search shows it is only used in dataarray.py. This should be an easy fix if you have the time.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Request error handling in dataarray construction 511477827
572216092 https://github.com/pydata/xarray/issues/3437#issuecomment-572216092 https://api.github.com/repos/pydata/xarray/issues/3437 MDEyOklzc3VlQ29tbWVudDU3MjIxNjA5Mg== rpgoldman 3274 2020-01-08T19:18:53Z 2020-01-08T19:18:53Z CONTRIBUTOR

Good point: that might be a lot easier than picking up the information on the way down the stack in an exception handler.

I don't know how many call sites there are for this, so no idea how difficult that would be. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Request error handling in dataarray construction 511477827
572202898 https://github.com/pydata/xarray/issues/3437#issuecomment-572202898 https://api.github.com/repos/pydata/xarray/issues/3437 MDEyOklzc3VlQ29tbWVudDU3MjIwMjg5OA== dcherian 2448579 2020-01-08T18:44:42Z 2020-01-08T18:44:42Z MEMBER

Good idea! How about passoing name to _infer_coords_and_dims and have that function raise a nicer error message?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Request error handling in dataarray construction 511477827
572133055 https://github.com/pydata/xarray/issues/3437#issuecomment-572133055 https://api.github.com/repos/pydata/xarray/issues/3437 MDEyOklzc3VlQ29tbWVudDU3MjEzMzA1NQ== rpgoldman 3274 2020-01-08T15:54:55Z 2020-01-08T15:54:55Z CONTRIBUTOR

I think the Right Thing here would be to raise a specific Exception class instead of ValueError in the case of dimension mismatch. Then a caller can trap that exception, add information about the variable that cannot be translated, and re-signal.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Request error handling in dataarray construction 511477827

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);