issue_comments

Table actions

18 rows where issue = 510915725 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • v0.14.1 Release · 18 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
555763914 https://github.com/pydata/xarray/issues/3434#issuecomment-555763914 https://api.github.com/repos/pydata/xarray/issues/3434 MDEyOklzc3VlQ29tbWVudDU1NTc2MzkxNA== dcherian 2448579 2019-11-19T23:28:56Z 2019-11-19T23:28:56Z MEMBER

Thanks @max-sixty I activated the RTD build.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
   v0.14.1 Release 510915725
555572691 https://github.com/pydata/xarray/issues/3434#issuecomment-555572691 https://api.github.com/repos/pydata/xarray/issues/3434 MDEyOklzc3VlQ29tbWVudDU1NTU3MjY5MQ== dcherian 2448579 2019-11-19T15:56:39Z 2019-11-19T15:56:39Z MEMBER

:+1:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   v0.14.1 Release 510915725
555568887 https://github.com/pydata/xarray/issues/3434#issuecomment-555568887 https://api.github.com/repos/pydata/xarray/issues/3434 MDEyOklzc3VlQ29tbWVudDU1NTU2ODg4Nw== max-sixty 5635139 2019-11-19T15:48:45Z 2019-11-19T15:48:45Z MEMBER

Yup I can do it later this afternoon!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   v0.14.1 Release 510915725
555565372 https://github.com/pydata/xarray/issues/3434#issuecomment-555565372 https://api.github.com/repos/pydata/xarray/issues/3434 MDEyOklzc3VlQ29tbWVudDU1NTU2NTM3Mg== dcherian 2448579 2019-11-19T15:41:15Z 2019-11-19T15:41:15Z MEMBER

I agree! @crusaderky, @max-sixty: do either of you have the time to make a release?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   v0.14.1 Release 510915725
555522754 https://github.com/pydata/xarray/issues/3434#issuecomment-555522754 https://api.github.com/repos/pydata/xarray/issues/3434 MDEyOklzc3VlQ29tbWVudDU1NTUyMjc1NA== crusaderky 6213168 2019-11-19T14:07:27Z 2019-11-19T14:07:27Z MEMBER

I think we're good to go!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   v0.14.1 Release 510915725
554352825 https://github.com/pydata/xarray/issues/3434#issuecomment-554352825 https://api.github.com/repos/pydata/xarray/issues/3434 MDEyOklzc3VlQ29tbWVudDU1NDM1MjgyNQ== crusaderky 6213168 2019-11-15T13:09:59Z 2019-11-15T13:09:59Z MEMBER

If someone could review and merge #3537 and #3531, we can close this!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   v0.14.1 Release 510915725
552495711 https://github.com/pydata/xarray/issues/3434#issuecomment-552495711 https://api.github.com/repos/pydata/xarray/issues/3434 MDEyOklzc3VlQ29tbWVudDU1MjQ5NTcxMQ== dcherian 2448579 2019-11-11T15:40:59Z 2019-11-11T15:40:59Z MEMBER

I'm in favour of releasing even if we are currently broken with numpy master.

Our current release is also broken with numpy master, so the situation is no worse...

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   v0.14.1 Release 510915725
551148787 https://github.com/pydata/xarray/issues/3434#issuecomment-551148787 https://api.github.com/repos/pydata/xarray/issues/3434 MDEyOklzc3VlQ29tbWVudDU1MTE0ODc4Nw== mathause 10194086 2019-11-07T16:13:30Z 2019-11-07T16:13:30Z MEMBER

Don't we have to figure out whether to use np.mean or np.nanmean for datetime vectors?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   v0.14.1 Release 510915725
551131435 https://github.com/pydata/xarray/issues/3434#issuecomment-551131435 https://api.github.com/repos/pydata/xarray/issues/3434 MDEyOklzc3VlQ29tbWVudDU1MTEzMTQzNQ== dcherian 2448579 2019-11-07T15:34:03Z 2019-11-07T15:34:03Z MEMBER

Once #3491 is merged, we should be ready to release since numpy will fix itself (https://github.com/numpy/numpy/pull/14841)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   v0.14.1 Release 510915725
549879504 https://github.com/pydata/xarray/issues/3434#issuecomment-549879504 https://api.github.com/repos/pydata/xarray/issues/3434 MDEyOklzc3VlQ29tbWVudDU0OTg3OTUwNA== dcherian 2448579 2019-11-05T15:43:14Z 2019-11-05T15:43:14Z MEMBER

@mathause Thanks for filing these upstream issues!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   v0.14.1 Release 510915725
549766145 https://github.com/pydata/xarray/issues/3434#issuecomment-549766145 https://api.github.com/repos/pydata/xarray/issues/3434 MDEyOklzc3VlQ29tbWVudDU0OTc2NjE0NQ== mathause 10194086 2019-11-05T10:37:54Z 2019-11-05T10:37:54Z MEMBER

xref for numpy 1.18 numpy/numpy#14831

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   v0.14.1 Release 510915725
549407230 https://github.com/pydata/xarray/issues/3434#issuecomment-549407230 https://api.github.com/repos/pydata/xarray/issues/3434 MDEyOklzc3VlQ29tbWVudDU0OTQwNzIzMA== barronh 1191149 2019-11-04T15:30:08Z 2019-11-04T15:30:08Z CONTRIBUTOR

Got it. This is a test update to a test that is backward and forward compatible. I'll get something checked in.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   v0.14.1 Release 510915725
548485688 https://github.com/pydata/xarray/issues/3434#issuecomment-548485688 https://api.github.com/repos/pydata/xarray/issues/3434 MDEyOklzc3VlQ29tbWVudDU0ODQ4NTY4OA== crusaderky 6213168 2019-10-31T17:31:13Z 2019-10-31T17:31:13Z MEMBER

@barronh, we don't care about Python 2.7 compliance. We support >=3.6.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   v0.14.1 Release 510915725
548458836 https://github.com/pydata/xarray/issues/3434#issuecomment-548458836 https://api.github.com/repos/pydata/xarray/issues/3434 MDEyOklzc3VlQ29tbWVudDU0ODQ1ODgzNg== barronh 1191149 2019-10-31T16:29:32Z 2019-10-31T16:29:32Z CONTRIBUTOR

I believe there are two issues here.

First, the 3.1 release was not 2.7 compliant. It mixed named keyword arguments with **kwds. That could be fixed easily.

Second, the camx reader changed subclasses, which affects the xarray test for CF variables. I could update the test that would fix xarray test-case.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   v0.14.1 Release 510915725
547619793 https://github.com/pydata/xarray/issues/3434#issuecomment-547619793 https://api.github.com/repos/pydata/xarray/issues/3434 MDEyOklzc3VlQ29tbWVudDU0NzYxOTc5Mw== crusaderky 6213168 2019-10-29T20:41:22Z 2019-10-29T20:41:22Z MEMBER

@barronh any update re pseudonetcdf 3.1?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   v0.14.1 Release 510915725
547619144 https://github.com/pydata/xarray/issues/3434#issuecomment-547619144 https://api.github.com/repos/pydata/xarray/issues/3434 MDEyOklzc3VlQ29tbWVudDU0NzYxOTE0NA== crusaderky 6213168 2019-10-29T20:39:44Z 2019-10-29T20:39:44Z MEMBER

@mathause I'm personally really uncomfortable pushing out a release when there are multiple known breakages against dependencies - see Must have list. Help is welcome!

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   v0.14.1 Release 510915725
547050663 https://github.com/pydata/xarray/issues/3434#issuecomment-547050663 https://api.github.com/repos/pydata/xarray/issues/3434 MDEyOklzc3VlQ29tbWVudDU0NzA1MDY2Mw== mathause 10194086 2019-10-28T17:12:13Z 2019-10-28T17:12:13Z MEMBER

Would be nice to get this out - just hit #3426. (I now updated to master but this is besides the point).

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   v0.14.1 Release 510915725
545158667 https://github.com/pydata/xarray/issues/3434#issuecomment-545158667 https://api.github.com/repos/pydata/xarray/issues/3434 MDEyOklzc3VlQ29tbWVudDU0NTE1ODY2Nw== dcherian 2448579 2019-10-22T21:14:34Z 2019-10-22T21:14:34Z MEMBER

3406 needs a review

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   v0.14.1 Release 510915725

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);