issue_comments

Table actions

9 rows where issue = 509486175 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

issue 1

  • change ALL_DIMS to equal ellipsis · 9 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
546395374 https://github.com/pydata/xarray/pull/3418#issuecomment-546395374 https://api.github.com/repos/pydata/xarray/issues/3418 MDEyOklzc3VlQ29tbWVudDU0NjM5NTM3NA== dcherian 2448579 2019-10-25T15:15:41Z 2019-10-25T15:15:41Z MEMBER

Thanks @max-sixty !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   change ALL_DIMS to equal ellipsis 509486175
545952741 https://github.com/pydata/xarray/pull/3418#issuecomment-545952741 https://api.github.com/repos/pydata/xarray/issues/3418 MDEyOklzc3VlQ29tbWVudDU0NTk1Mjc0MQ== max-sixty 5635139 2019-10-24T14:45:06Z 2019-10-24T14:45:06Z MEMBER

Any final comments before merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   change ALL_DIMS to equal ellipsis 509486175
545693128 https://github.com/pydata/xarray/pull/3418#issuecomment-545693128 https://api.github.com/repos/pydata/xarray/issues/3418 MDEyOklzc3VlQ29tbWVudDU0NTY5MzEyOA== shoyer 1217238 2019-10-24T00:43:06Z 2019-10-24T00:43:06Z MEMBER

build failure should be fixed by https://github.com/pydata/xarray/pull/3439

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   change ALL_DIMS to equal ellipsis 509486175
545595223 https://github.com/pydata/xarray/pull/3418#issuecomment-545595223 https://api.github.com/repos/pydata/xarray/issues/3418 MDEyOklzc3VlQ29tbWVudDU0NTU5NTIyMw== dcherian 2448579 2019-10-23T19:16:40Z 2019-10-23T19:16:40Z MEMBER

cftime has merged the PR with the fix so we should just switch back to their master branch

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   change ALL_DIMS to equal ellipsis 509486175
545550957 https://github.com/pydata/xarray/pull/3418#issuecomment-545550957 https://api.github.com/repos/pydata/xarray/issues/3418 MDEyOklzc3VlQ29tbWVudDU0NTU1MDk1Nw== max-sixty 5635139 2019-10-23T17:26:21Z 2019-10-23T17:26:21Z MEMBER

Hmmm, still getting cftime issues with the build: ERROR: Command errored out with exit status 128: git fetch -q https://github.com/Unidata/cftime.git refs/pull/127/merge Check the logs for full command output. https://dev.azure.com/xarray/xarray/_build/results?buildId=1208&view=logs

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   change ALL_DIMS to equal ellipsis 509486175
544336428 https://github.com/pydata/xarray/pull/3418#issuecomment-544336428 https://api.github.com/repos/pydata/xarray/issues/3418 MDEyOklzc3VlQ29tbWVudDU0NDMzNjQyOA== max-sixty 5635139 2019-10-21T03:38:22Z 2019-10-21T03:38:22Z MEMBER

Ready for review / merge

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   change ALL_DIMS to equal ellipsis 509486175
544301384 https://github.com/pydata/xarray/pull/3418#issuecomment-544301384 https://api.github.com/repos/pydata/xarray/issues/3418 MDEyOklzc3VlQ29tbWVudDU0NDMwMTM4NA== crusaderky 6213168 2019-10-20T22:54:32Z 2019-10-20T22:54:32Z MEMBER

@max-sixty I'm in favour of ... as the preferred syntax

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   change ALL_DIMS to equal ellipsis 509486175
544298693 https://github.com/pydata/xarray/pull/3418#issuecomment-544298693 https://api.github.com/repos/pydata/xarray/issues/3418 MDEyOklzc3VlQ29tbWVudDU0NDI5ODY5Mw== max-sixty 5635139 2019-10-20T22:17:35Z 2019-10-20T22:17:35Z MEMBER

Should we advertise ... as the recommended way to supply 'all dims', rather than xr.ALL_DIMS? (if we're not sure, we could leave as currently proposed and change later)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   change ALL_DIMS to equal ellipsis 509486175
544264186 https://github.com/pydata/xarray/pull/3418#issuecomment-544264186 https://api.github.com/repos/pydata/xarray/issues/3418 MDEyOklzc3VlQ29tbWVudDU0NDI2NDE4Ng== crusaderky 6213168 2019-10-20T15:44:57Z 2019-10-20T15:44:57Z MEMBER

Tests broken by #3409 - please stand by...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   change ALL_DIMS to equal ellipsis 509486175

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);