issue_comments

Table actions

7 rows where issue = 507599878 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Drop groups associated with nans in group variable · 7 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
547194223 https://github.com/pydata/xarray/pull/3406#issuecomment-547194223 https://api.github.com/repos/pydata/xarray/issues/3406 MDEyOklzc3VlQ29tbWVudDU0NzE5NDIyMw== max-sixty 5635139 2019-10-28T23:46:56Z 2019-10-28T23:46:56Z MEMBER

Thanks @dcherian !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop groups associated with nans in group variable 507599878
547146051 https://github.com/pydata/xarray/pull/3406#issuecomment-547146051 https://api.github.com/repos/pydata/xarray/issues/3406 MDEyOklzc3VlQ29tbWVudDU0NzE0NjA1MQ== dcherian 2448579 2019-10-28T21:06:44Z 2019-10-28T21:06:44Z MEMBER

Fixed merge conflict.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop groups associated with nans in group variable 507599878
547131464 https://github.com/pydata/xarray/pull/3406#issuecomment-547131464 https://api.github.com/repos/pydata/xarray/issues/3406 MDEyOklzc3VlQ29tbWVudDU0NzEzMTQ2NA== max-sixty 5635139 2019-10-28T20:28:13Z 2019-10-28T20:28:13Z MEMBER

Shall we merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop groups associated with nans in group variable 507599878
542985070 https://github.com/pydata/xarray/pull/3406#issuecomment-542985070 https://api.github.com/repos/pydata/xarray/issues/3406 MDEyOklzc3VlQ29tbWVudDU0Mjk4NTA3MA== dcherian 2448579 2019-10-17T03:40:39Z 2019-10-17T03:40:39Z MEMBER

Thanks for checking!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop groups associated with nans in group variable 507599878
542981586 https://github.com/pydata/xarray/pull/3406#issuecomment-542981586 https://api.github.com/repos/pydata/xarray/issues/3406 MDEyOklzc3VlQ29tbWVudDU0Mjk4MTU4Ng== max-sixty 5635139 2019-10-17T03:25:05Z 2019-10-17T03:25:05Z MEMBER

I don't think so. Two of the tests I added fail on master with the IndexError in #2383. The rest pass on master.

You're right!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop groups associated with nans in group variable 507599878
542952519 https://github.com/pydata/xarray/pull/3406#issuecomment-542952519 https://api.github.com/repos/pydata/xarray/issues/3406 MDEyOklzc3VlQ29tbWVudDU0Mjk1MjUxOQ== dcherian 2448579 2019-10-17T01:06:10Z 2019-10-17T01:06:10Z MEMBER

I don't think so. Two of the tests I added fail on master with the IndexError in #2383. The rest pass on master.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop groups associated with nans in group variable 507599878
542913858 https://github.com/pydata/xarray/pull/3406#issuecomment-542913858 https://api.github.com/repos/pydata/xarray/issues/3406 MDEyOklzc3VlQ29tbWVudDU0MjkxMzg1OA== max-sixty 5635139 2019-10-16T22:15:13Z 2019-10-16T22:15:13Z MEMBER

+1. This is how pandas treats NaNs

IIUC, it is a breaking change, so we'd need to leave this open or commit to 0.15 for next release

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop groups associated with nans in group variable 507599878

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);