issue_comments

Table actions

19 rows where issue = 503700649 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • [Release] 0.14 · 19 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
541991847 https://github.com/pydata/xarray/issues/3380#issuecomment-541991847 https://api.github.com/repos/pydata/xarray/issues/3380 MDEyOklzc3VlQ29tbWVudDU0MTk5MTg0Nw== max-sixty 5635139 2019-10-15T01:08:11Z 2019-10-15T01:08:11Z MEMBER

Thanks a lot @jhamman !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Release] 0.14 503700649
541933541 https://github.com/pydata/xarray/issues/3380#issuecomment-541933541 https://api.github.com/repos/pydata/xarray/issues/3380 MDEyOklzc3VlQ29tbWVudDU0MTkzMzU0MQ== dcherian 2448579 2019-10-14T21:30:50Z 2019-10-14T21:30:50Z MEMBER

:confetti_ball:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Release] 0.14 503700649
541931692 https://github.com/pydata/xarray/issues/3380#issuecomment-541931692 https://api.github.com/repos/pydata/xarray/issues/3380 MDEyOklzc3VlQ29tbWVudDU0MTkzMTY5Mg== jhamman 2443309 2019-10-14T21:26:59Z 2019-10-14T21:26:59Z MEMBER

0.14 is on github/pypi/conda-forge/readthedocs now. Announcement emails/tweets are pending. Closing this now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Release] 0.14 503700649
541842501 https://github.com/pydata/xarray/issues/3380#issuecomment-541842501 https://api.github.com/repos/pydata/xarray/issues/3380 MDEyOklzc3VlQ29tbWVudDU0MTg0MjUwMQ== jhamman 2443309 2019-10-14T18:28:21Z 2019-10-14T18:28:21Z MEMBER

Okay all. Making the release now. 

{
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
   [Release] 0.14 503700649
541432418 https://github.com/pydata/xarray/issues/3380#issuecomment-541432418 https://api.github.com/repos/pydata/xarray/issues/3380 MDEyOklzc3VlQ29tbWVudDU0MTQzMjQxOA== keewis 14808389 2019-10-13T16:16:14Z 2019-10-13T16:16:14Z MEMBER

I agree that until __array_function__ is at least in pint master (which may take a while, especially since hgrecco/pint#764 seems to be on hold), having #3238 in a release is not really important.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Release] 0.14 503700649
541423943 https://github.com/pydata/xarray/issues/3380#issuecomment-541423943 https://api.github.com/repos/pydata/xarray/issues/3380 MDEyOklzc3VlQ29tbWVudDU0MTQyMzk0Mw== crusaderky 6213168 2019-10-13T14:41:51Z 2019-10-13T14:41:51Z MEMBER

I think #3238 has somewhat little value until __array_function__ is properly implemented in pint master. @keewis what's your opinion?

The other two only improve the tests so users of the release version don't benefit from them.

I'd say let's close it!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Release] 0.14 503700649
541367633 https://github.com/pydata/xarray/issues/3380#issuecomment-541367633 https://api.github.com/repos/pydata/xarray/issues/3380 MDEyOklzc3VlQ29tbWVudDU0MTM2NzYzMw== dcherian 2448579 2019-10-12T22:51:10Z 2019-10-12T22:51:10Z MEMBER

3364 could be useful for the hackathon but definitely not necessary.

Thanks for pushing this along Joe. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Release] 0.14 503700649
541364181 https://github.com/pydata/xarray/issues/3380#issuecomment-541364181 https://api.github.com/repos/pydata/xarray/issues/3380 MDEyOklzc3VlQ29tbWVudDU0MTM2NDE4MQ== jhamman 2443309 2019-10-12T21:49:12Z 2019-10-12T21:49:12Z MEMBER

I think we're feature complete here. There are three PRs that are close (#3238, #3283, #3285) but probably don't need to hold up a release. I have some time Monday morning to issue the release so we'll go with that. Nice work all!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Release] 0.14 503700649
541112373 https://github.com/pydata/xarray/issues/3380#issuecomment-541112373 https://api.github.com/repos/pydata/xarray/issues/3380 MDEyOklzc3VlQ29tbWVudDU0MTExMjM3Mw== jhamman 2443309 2019-10-11T15:30:58Z 2019-10-11T15:30:58Z MEMBER

Need a fix for #3377

See #3393

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Release] 0.14 503700649
540694583 https://github.com/pydata/xarray/issues/3380#issuecomment-540694583 https://api.github.com/repos/pydata/xarray/issues/3380 MDEyOklzc3VlQ29tbWVudDU0MDY5NDU4Mw== jhamman 2443309 2019-10-10T17:41:17Z 2019-10-10T17:41:17Z MEMBER

See #3389 for the PR removing OrderedDicts. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Release] 0.14 503700649
540486871 https://github.com/pydata/xarray/issues/3380#issuecomment-540486871 https://api.github.com/repos/pydata/xarray/issues/3380 MDEyOklzc3VlQ29tbWVudDU0MDQ4Njg3MQ== crusaderky 6213168 2019-10-10T09:36:50Z 2019-10-10T09:36:50Z MEMBER

@jhamman never release to production on a Friday! 🏖 Jokes aside, I'm happy to leave the burden to you

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Release] 0.14 503700649
540069770 https://github.com/pydata/xarray/issues/3380#issuecomment-540069770 https://api.github.com/repos/pydata/xarray/issues/3380 MDEyOklzc3VlQ29tbWVudDU0MDA2OTc3MA== shoyer 1217238 2019-10-09T16:04:19Z 2019-10-09T16:04:19Z MEMBER

Should we also make assign and assign_coords no longer sort their arguments? We can do that now that dictionary are always ordered

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Release] 0.14 503700649
540063556 https://github.com/pydata/xarray/issues/3380#issuecomment-540063556 https://api.github.com/repos/pydata/xarray/issues/3380 MDEyOklzc3VlQ29tbWVudDU0MDA2MzU1Ng== jhamman 2443309 2019-10-09T15:50:07Z 2019-10-09T15:50:07Z MEMBER

@jhamman no - I should have it ready by the end of the weekend.

I plan to make the release on Friday. I can do this task before then unless you really want to do it :wink:.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
   [Release] 0.14 503700649
539747962 https://github.com/pydata/xarray/issues/3380#issuecomment-539747962 https://api.github.com/repos/pydata/xarray/issues/3380 MDEyOklzc3VlQ29tbWVudDUzOTc0Nzk2Mg== crusaderky 6213168 2019-10-08T23:34:15Z 2019-10-08T23:34:15Z MEMBER

@jhamman no - I should have it ready by the end of the weekend.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Release] 0.14 503700649
539725031 https://github.com/pydata/xarray/issues/3380#issuecomment-539725031 https://api.github.com/repos/pydata/xarray/issues/3380 MDEyOklzc3VlQ29tbWVudDUzOTcyNTAzMQ== jhamman 2443309 2019-10-08T22:10:15Z 2019-10-08T22:10:15Z MEMBER

Nuke away all OrderedDicts! (blocked by #3358)

@crusaderky - have you started on this yet? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Release] 0.14 503700649
539525375 https://github.com/pydata/xarray/issues/3380#issuecomment-539525375 https://api.github.com/repos/pydata/xarray/issues/3380 MDEyOklzc3VlQ29tbWVudDUzOTUyNTM3NQ== keewis 14808389 2019-10-08T13:55:15Z 2019-10-08T13:55:15Z MEMBER

I don't know if I will have the time to finish #3238 this week, even if I limit it to only testing DataArray.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Release] 0.14 503700649
539228342 https://github.com/pydata/xarray/issues/3380#issuecomment-539228342 https://api.github.com/repos/pydata/xarray/issues/3380 MDEyOklzc3VlQ29tbWVudDUzOTIyODM0Mg== dcherian 2448579 2019-10-07T22:19:08Z 2019-10-07T22:19:08Z MEMBER

This looks like it may have fallen out of the indexing refactor; definitely should be fixed: https://github.com/pydata/xarray/issues/3377

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Release] 0.14 503700649
539224341 https://github.com/pydata/xarray/issues/3380#issuecomment-539224341 https://api.github.com/repos/pydata/xarray/issues/3380 MDEyOklzc3VlQ29tbWVudDUzOTIyNDM0MQ== crusaderky 6213168 2019-10-07T22:05:24Z 2019-10-07T22:05:24Z MEMBER

Nuke away all OrderedDicts! (blocked by #3358)

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Release] 0.14 503700649
539213256 https://github.com/pydata/xarray/issues/3380#issuecomment-539213256 https://api.github.com/repos/pydata/xarray/issues/3380 MDEyOklzc3VlQ29tbWVudDUzOTIxMzI1Ng== dcherian 2448579 2019-10-07T21:31:30Z 2019-10-07T21:31:30Z MEMBER

Added #3338 

{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Release] 0.14 503700649

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);