issue_comments

Table actions

5 rows where issue = 503562032 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 4

author_association 2

issue 1

  • Changed behavior for replacing coordinates on dataset. · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
541025099 https://github.com/pydata/xarray/issues/3377#issuecomment-541025099 https://api.github.com/repos/pydata/xarray/issues/3377 MDEyOklzc3VlQ29tbWVudDU0MTAyNTA5OQ== jbusecke 14314623 2019-10-11T11:25:26Z 2019-10-11T11:25:26Z CONTRIBUTOR

Glad that this orphaned test (we ended up removing it, because the function was not called anymore) was still useful!

And many thanks to @dcherian for suggesting to test xgxm with the upstream master!

<sub>Sent with GitHawk</sub>

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Changed behavior for replacing coordinates on dataset. 503562032
540928701 https://github.com/pydata/xarray/issues/3377#issuecomment-540928701 https://api.github.com/repos/pydata/xarray/issues/3377 MDEyOklzc3VlQ29tbWVudDU0MDkyODcwMQ== shoyer 1217238 2019-10-11T06:25:08Z 2019-10-11T06:25:08Z MEMBER

@jbusecke kudos to you for catching this so early, before we even made a release!

https://github.com/pydata/xarray/pull/3393 should fix the immediate issue, though it's a pretty awkward fix.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 1,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Changed behavior for replacing coordinates on dataset. 503562032
540917530 https://github.com/pydata/xarray/issues/3377#issuecomment-540917530 https://api.github.com/repos/pydata/xarray/issues/3377 MDEyOklzc3VlQ29tbWVudDU0MDkxNzUzMA== shoyer 1217238 2019-10-11T05:45:43Z 2019-10-11T05:45:43Z MEMBER

Yes, it was definitely my explicit indexes refactor. Apparently this wasn't tested?

Here's a simpler reproduction: python import xarray as xr ds = xr.Dataset({"x": [0, 1, 2]}) ds["x"] = ds["x"][:2] assert ds.sizes["x"] == 2, ds

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Changed behavior for replacing coordinates on dataset. 503562032
540886056 https://github.com/pydata/xarray/issues/3377#issuecomment-540886056 https://api.github.com/repos/pydata/xarray/issues/3377 MDEyOklzc3VlQ29tbWVudDU0MDg4NjA1Ng== jhamman 2443309 2019-10-11T03:32:45Z 2019-10-11T03:32:45Z MEMBER

I looked into this a bit tonight. I think this may be related to @shoyer's recent explicit indexes refactor (#3234). I'm having trouble following some of the new logic but it seems we're not updating the size of the x_c dimension during the __setitem__ step in @jbusecke's example. I have a PR coming with a regression test -- #3392. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Changed behavior for replacing coordinates on dataset. 503562032
539105764 https://github.com/pydata/xarray/issues/3377#issuecomment-539105764 https://api.github.com/repos/pydata/xarray/issues/3377 MDEyOklzc3VlQ29tbWVudDUzOTEwNTc2NA== max-sixty 5635139 2019-10-07T16:53:46Z 2019-10-07T16:53:46Z MEMBER

Thanks for submitting. Confirmed. I couldn't work out the cause quickly, can have another look later; unless anyone knows immediately.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Changed behavior for replacing coordinates on dataset. 503562032

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);