issue_comments

Table actions

4 rows where issue = 503425825 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • .coarsen() method for the xarray.Dataset removes its attributes. · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
544477005 https://github.com/pydata/xarray/issues/3376#issuecomment-544477005 https://api.github.com/repos/pydata/xarray/issues/3376 MDEyOklzc3VlQ29tbWVudDU0NDQ3NzAwNQ== TomNicholas 35968931 2019-10-21T11:44:04Z 2019-10-21T11:44:04Z MEMBER

@jejjohnson that means coarsen must have been missed when applying the keep_attrs logic in #2482. If you have a look there it should hopefully be clear how to copy the same logic for coarsen.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .coarsen() method for the xarray.Dataset removes its attributes. 503425825
539027757 https://github.com/pydata/xarray/issues/3376#issuecomment-539027757 https://api.github.com/repos/pydata/xarray/issues/3376 MDEyOklzc3VlQ29tbWVudDUzOTAyNzc1Nw== dcherian 2448579 2019-10-07T14:04:35Z 2019-10-07T14:04:35Z MEMBER

Thanks for the clear report. I'll mark this as a bug then. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .coarsen() method for the xarray.Dataset removes its attributes. 503425825
539022505 https://github.com/pydata/xarray/issues/3376#issuecomment-539022505 https://api.github.com/repos/pydata/xarray/issues/3376 MDEyOklzc3VlQ29tbWVudDUzOTAyMjUwNQ== jejjohnson 3642622 2019-10-07T13:53:48Z 2019-10-07T13:55:10Z NONE

Hello,

Yes, even with the option xr.set_options(keep_attrs=True), I still encounter the attributes changed. The full code with the set options is below.

#### Inputs ```python import xarray as xr import numpy as np xr.set_options(keep_attrs=True) import xarray as xr import numpy as np var1 = np.linspace(10, 15, 100) var2 = np.linspace(5, 10, 100) coords = np.linspace(1, 10, 100) dat = xr.Dataset( data_vars={'var1': ('coord', var1), 'var2': ('coord', var2)}, coords={'coord': coords} ) dat.attrs['model_id'] = 'model1' # coarsen dataset dat = dat.coarsen(coord=5, keep_attrs=True).mean() # print dataset dat ``` #### Actual Output ```python <xarray.Dataset> Dimensions: (coord: 20) Coordinates: * coord (coord) float64 1.182 1.636 2.091 2.545 ... 8.455 8.909 9.364 9.818 Data variables: var1 (coord) float64 10.1 10.35 10.61 10.86 ... 14.14 14.39 14.65 14.9 var2 (coord) float64 5.101 5.354 5.606 5.859 ... 9.141 9.394 9.646 9.899 ``` #### Expected Output ```python <xarray.Dataset> Dimensions: (coord: 20) Coordinates: * coord (coord) float64 1.182 1.636 2.091 2.545 ... 8.455 8.909 9.364 9.818 Data variables: var1 (coord) float64 10.1 10.35 10.61 10.86 ... 14.14 14.39 14.65 14.9 var2 (coord) float64 5.101 5.354 5.606 5.859 ... 9.141 9.394 9.646 9.899 Attributes: model_id: model1 ```

I'm not too familiar with the xarray package internals. But I will look to see if I can do my part and do a pull request. I'll get back to you after having a look at the internals.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .coarsen() method for the xarray.Dataset removes its attributes. 503425825
539018257 https://github.com/pydata/xarray/issues/3376#issuecomment-539018257 https://api.github.com/repos/pydata/xarray/issues/3376 MDEyOklzc3VlQ29tbWVudDUzOTAxODI1Nw== dcherian 2448579 2019-10-07T13:44:41Z 2019-10-07T13:44:41Z MEMBER

Have you tried xr.set_options(keep_attrs=True)?

The behaviour for Datasets and DataArrays should be consistent in any case. Would you like to try and fix it?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .coarsen() method for the xarray.Dataset removes its attributes. 503425825

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);