issue_comments

Table actions

5 rows where issue = 502130982 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

These facets timed out: issue

user 1

  • max-sixty · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
594734114 https://github.com/pydata/xarray/issues/3370#issuecomment-594734114 https://api.github.com/repos/pydata/xarray/issues/3370 MDEyOklzc3VlQ29tbWVudDU5NDczNDExNA== max-sixty 5635139 2020-03-04T18:32:53Z 2020-03-04T18:32:53Z MEMBER

@keewis I'm guessing we're still stuck on this because of the Napoleon bug?

Your efforts to quash the previous warnings are laudable, and would be great if we can add tests to ensure they don't creep back in...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Hundreds of Sphinx errors 502130982
548414737 https://github.com/pydata/xarray/issues/3370#issuecomment-548414737 https://api.github.com/repos/pydata/xarray/issues/3370 MDEyOklzc3VlQ29tbWVudDU0ODQxNDczNw== max-sixty 5635139 2019-10-31T14:54:33Z 2019-10-31T14:54:33Z MEMBER

Is there a sphinx or restructured text linter that we can run? e.g. https://github.com/PyCQA/doc8

Looks reasonable; though this is a checker rather than fixer

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Hundreds of Sphinx errors 502130982
548414589 https://github.com/pydata/xarray/issues/3370#issuecomment-548414589 https://api.github.com/repos/pydata/xarray/issues/3370 MDEyOklzc3VlQ29tbWVudDU0ODQxNDU4OQ== max-sixty 5635139 2019-10-31T14:54:16Z 2019-10-31T14:54:16Z MEMBER

I ran https://github.com/myint/docformatter on our code docformatter --in-place -r --wrap-summaries=88 .; results here

But it doesn't solve many of our issues, which are around the sphinx docstrings

Happy to do a PR, but worry it's more churn than help?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Hundreds of Sphinx errors 502130982
548408079 https://github.com/pydata/xarray/issues/3370#issuecomment-548408079 https://api.github.com/repos/pydata/xarray/issues/3370 MDEyOklzc3VlQ29tbWVudDU0ODQwODA3OQ== max-sixty 5635139 2019-10-31T14:41:06Z 2019-10-31T14:41:06Z MEMBER

The sphinx log states:

/home/docs/checkouts/readthedocs.org/user_builds/xray/conda/latest/lib/python3.7/site-packages/xarray-0.14.0+37.g96cc2bc6-py3.7.egg/xarray/core/dataset.py:docstring of xarray.Dataset.integrate:12: WARNING: Unexpected indentation.

That's a good case...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Hundreds of Sphinx errors 502130982
547749938 https://github.com/pydata/xarray/issues/3370#issuecomment-547749938 https://api.github.com/repos/pydata/xarray/issues/3370 MDEyOklzc3VlQ29tbWVudDU0Nzc0OTkzOA== max-sixty 5635139 2019-10-30T05:57:53Z 2019-10-30T05:57:53Z MEMBER

Do these matter?

Do we know of examples of bad outcomes (e.g. hard-to-read docs)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Hundreds of Sphinx errors 502130982

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);