issue_comments

Table actions

5 rows where issue = 502130982 and user = 14808389 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

These facets timed out: author_association

user 1

  • keewis · 5 ✖

issue 1

  • Hundreds of Sphinx errors · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
663840450 https://github.com/pydata/xarray/issues/3370#issuecomment-663840450 https://api.github.com/repos/pydata/xarray/issues/3370 MDEyOklzc3VlQ29tbWVudDY2Mzg0MDQ1MA== keewis 14808389 2020-07-25T10:42:39Z 2020-07-25T22:39:01Z MEMBER

I've been working on a type preprocessor for napoleon (sphinx-doc/sphinx#7690) which is pretty close (to be included in sphinx v3.2.0). Hopefully that will silence all those warnings and also fix most of the broken type links.

Edit: the PR has been merged, so now we only have to wait until the next release of sphinx. That feature is pretty strict about the format of the type spec, so I'll create a PR to update our docstrings.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Hundreds of Sphinx errors 502130982
594797685 https://github.com/pydata/xarray/issues/3370#issuecomment-594797685 https://api.github.com/repos/pydata/xarray/issues/3370 MDEyOklzc3VlQ29tbWVudDU5NDc5NzY4NQ== keewis 14808389 2020-03-04T19:56:04Z 2020-03-04T19:56:04Z MEMBER

most warnings are due to the bug, yes. The others are broken references to accessor methods like Dataset.plot.scatter (see #3625). Last time I checked we did not have new warnings unrelated to the bug, but my grep regexp might have missed a few lines.

We could do something to make sure we don't introduce more warnings, though: the nitpicky mode allows ignoring warnings using nitpick_ignore, so we might be able to ignore every nitpicky warning related to docstrings / napoleon. We still would need to fix or bypass #3625 first, though.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Hundreds of Sphinx errors 502130982
566696534 https://github.com/pydata/xarray/issues/3370#issuecomment-566696534 https://api.github.com/repos/pydata/xarray/issues/3370 MDEyOklzc3VlQ29tbWVudDU2NjY5NjUzNA== keewis 14808389 2019-12-17T18:47:36Z 2019-12-17T21:20:12Z MEMBER

this is not yet fully fixed, we still need to silence the nitpick warnings. That is blocked by the napoleon bug, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Hundreds of Sphinx errors 502130982
564124368 https://github.com/pydata/xarray/issues/3370#issuecomment-564124368 https://api.github.com/repos/pydata/xarray/issues/3370 MDEyOklzc3VlQ29tbWVudDU2NDEyNDM2OA== keewis 14808389 2019-12-10T16:48:05Z 2019-12-10T16:48:05Z MEMBER

looks like I was wrong, numpydoc does not have much to do with this. The real culprit is napoleon: see sphinx-doc/sphinx#6861

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Hundreds of Sphinx errors 502130982
562582121 https://github.com/pydata/xarray/issues/3370#issuecomment-562582121 https://api.github.com/repos/pydata/xarray/issues/3370 MDEyOklzc3VlQ29tbWVudDU2MjU4MjEyMQ== keewis 14808389 2019-12-06T14:00:22Z 2019-12-06T14:18:08Z MEMBER

most of the nitpicky errors are raised because numpydoc tries to link to parameter types. We can define aliases and ignore terms like instance or words like of, see

https://github.com/mne-tools/mne-python/blob/da9cd19a9b65e792e2523f159820549ec6082f9d/doc/conf.py#L531-L616

for an example. We can also ignore nitpicky warnings using nitpick_ignore, but the normal warnings can't be selectively ignored (suppress_warnings ignores warning categories).

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Hundreds of Sphinx errors 502130982

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);