issue_comments

Table actions

3 rows where issue = 501108453 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • user-friendly additions for dask usage · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
538705207 https://github.com/pydata/xarray/issues/3363#issuecomment-538705207 https://api.github.com/repos/pydata/xarray/issues/3363 MDEyOklzc3VlQ29tbWVudDUzODcwNTIwNw== shoyer 1217238 2019-10-06T02:10:14Z 2019-10-06T02:10:14Z MEMBER

I think it's totally reasonable to ask people to write da.data.chunksize.

I would prefer to reserve writing wrappers for cases where we do some additional xarray-specific stuff, e.g., wrapping the result back in an xarray object. Even then, if we need more than a few wrappers I would consider putting them in an accessor namespace, e.g., da.dask.chunksize.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   user-friendly additions for dask usage 501108453
537694290 https://github.com/pydata/xarray/issues/3363#issuecomment-537694290 https://api.github.com/repos/pydata/xarray/issues/3363 MDEyOklzc3VlQ29tbWVudDUzNzY5NDI5MA== max-sixty 5635139 2019-10-02T21:43:25Z 2019-10-02T21:43:25Z MEMBER

To what extent is asking people to call da.data.chunksize reasonable? Is the extra indirection all we'd we saving? (I don't use dask so this might seem naive)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   user-friendly additions for dask usage 501108453
537401568 https://github.com/pydata/xarray/issues/3363#issuecomment-537401568 https://api.github.com/repos/pydata/xarray/issues/3363 MDEyOklzc3VlQ29tbWVudDUzNzQwMTU2OA== crusaderky 6213168 2019-10-02T08:55:51Z 2019-10-02T08:55:51Z MEMBER

I'd rather transparently invoke data's method instead. This has bonus points considering the variety of NEP18-compatible xarray can now wrap.

python class DataArray: def __getattr__(self, item): try: return getattr(self._variable._data, item) except AttributeError: pass ... although that may cause a lot of not-niceness with methods that return a new array, which will become accidentally un-wrapped. Also unsure how such a system should behave on Dataset (probably shouldn't be there at all).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   user-friendly additions for dask usage 501108453

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);