issue_comments

Table actions

7 rows where issue = 497945632 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • CI environments overhaul · 7 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
534815773 https://github.com/pydata/xarray/pull/3340#issuecomment-534815773 https://api.github.com/repos/pydata/xarray/issues/3340 MDEyOklzc3VlQ29tbWVudDUzNDgxNTc3Mw== shoyer 1217238 2019-09-25T01:50:07Z 2019-09-25T01:50:07Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CI environments overhaul 497945632
534814130 https://github.com/pydata/xarray/pull/3340#issuecomment-534814130 https://api.github.com/repos/pydata/xarray/issues/3340 MDEyOklzc3VlQ29tbWVudDUzNDgxNDEzMA== crusaderky 6213168 2019-09-25T01:41:03Z 2019-09-25T01:41:03Z MEMBER

Thanks all!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CI environments overhaul 497945632
534804650 https://github.com/pydata/xarray/pull/3340#issuecomment-534804650 https://api.github.com/repos/pydata/xarray/issues/3340 MDEyOklzc3VlQ29tbWVudDUzNDgwNDY1MA== shoyer 1217238 2019-09-25T00:56:03Z 2019-09-25T00:56:03Z MEMBER

This looks great to me!

@crusaderky when you're ready, feel free to merge

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CI environments overhaul 497945632
534785445 https://github.com/pydata/xarray/pull/3340#issuecomment-534785445 https://api.github.com/repos/pydata/xarray/issues/3340 MDEyOklzc3VlQ29tbWVudDUzNDc4NTQ0NQ== crusaderky 6213168 2019-09-24T23:22:43Z 2019-09-24T23:22:43Z MEMBER

Ready for review

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CI environments overhaul 497945632
534770767 https://github.com/pydata/xarray/pull/3340#issuecomment-534770767 https://api.github.com/repos/pydata/xarray/issues/3340 MDEyOklzc3VlQ29tbWVudDUzNDc3MDc2Nw== crusaderky 6213168 2019-09-24T22:17:50Z 2019-09-24T22:33:33Z MEMBER

Differences between the requirements files after the changes:

```patch --- py36.yml +++ py37.yml @@ -5 +5 @@ - - python=3.6 + - python=3.7

--- py37.yml +++ py37-windows.yml @@ -9,2 +9,2 @@ - - cdms2 - - cfgrib>=0.9.2 + # - cdms2 # Not available on Windows + # - cfgrib>=0.9.2 # Causes Python interpreter crash on Windows @@ -31 +31 @@ - - pynio + # - pynio # Not available on Windows

```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CI environments overhaul 497945632
534773407 https://github.com/pydata/xarray/pull/3340#issuecomment-534773407 https://api.github.com/repos/pydata/xarray/issues/3340 MDEyOklzc3VlQ29tbWVudDUzNDc3MzQwNw== crusaderky 6213168 2019-09-24T22:29:06Z 2019-09-24T22:29:06Z MEMBER

@rabernat I'll look into it but on first inspection it feels like scope creep to me and I think it should be dealt with separately. Note how I didn't touch doc/environment.yml.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CI environments overhaul 497945632
534772064 https://github.com/pydata/xarray/pull/3340#issuecomment-534772064 https://api.github.com/repos/pydata/xarray/issues/3340 MDEyOklzc3VlQ29tbWVudDUzNDc3MjA2NA== rabernat 1197350 2019-09-24T22:23:09Z 2019-09-24T22:23:09Z MEMBER

For this PR, it could be worth considering the doc built challenges we are discussing over in https://github.com/pydata/xarray/pull/3199#issuecomment-534702846.

In that case, the doc build succeeded on CI but still failed on RTD. In theory, that shouldn't be possible.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CI environments overhaul 497945632

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);