issue_comments

Table actions

7 rows where issue = 496826564 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • More doc fixes · 7 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
533935918 https://github.com/pydata/xarray/pull/3333#issuecomment-533935918 https://api.github.com/repos/pydata/xarray/issues/3333 MDEyOklzc3VlQ29tbWVudDUzMzkzNTkxOA== dcherian 2448579 2019-09-23T01:08:39Z 2019-09-23T01:08:39Z MEMBER

Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More doc fixes 496826564
533933310 https://github.com/pydata/xarray/pull/3333#issuecomment-533933310 https://api.github.com/repos/pydata/xarray/issues/3333 MDEyOklzc3VlQ29tbWVudDUzMzkzMzMxMA== keewis 14808389 2019-09-23T00:34:58Z 2019-09-23T00:34:58Z MEMBER

done

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More doc fixes 496826564
533932013 https://github.com/pydata/xarray/pull/3333#issuecomment-533932013 https://api.github.com/repos/pydata/xarray/issues/3333 MDEyOklzc3VlQ29tbWVudDUzMzkzMjAxMw== dcherian 2448579 2019-09-23T00:18:18Z 2019-09-23T00:18:18Z MEMBER

Yes we have similar issues with GroupBy, Resample and rolling objects. methods like mean etc. aren't shown in the docs. There must be some way to tell sphinx to look for these "injected" methods (I think that's what they're called).

How about you remove the scatter changes for now and we can merge the rest? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More doc fixes 496826564
533929769 https://github.com/pydata/xarray/pull/3333#issuecomment-533929769 https://api.github.com/repos/pydata/xarray/issues/3333 MDEyOklzc3VlQ29tbWVudDUzMzkyOTc2OQ== keewis 14808389 2019-09-22T23:50:50Z 2019-09-22T23:50:50Z MEMBER

I tried tracking it down, but it uses the same mechanism as DataArray.plot where a new instance of _PlotMethods is assigned on each getattr on the property. The documentation on DataArray.plot skips this issue entirely by pointing to xr.plot.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More doc fixes 496826564
533928918 https://github.com/pydata/xarray/pull/3333#issuecomment-533928918 https://api.github.com/repos/pydata/xarray/issues/3333 MDEyOklzc3VlQ29tbWVudDUzMzkyODkxOA== keewis 14808389 2019-09-22T23:39:14Z 2019-09-22T23:40:04Z MEMBER

Then either we have to start testing for it or edit the docs of Dataset.plot, because there that function is mentioned.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More doc fixes 496826564
533928574 https://github.com/pydata/xarray/pull/3333#issuecomment-533928574 https://api.github.com/repos/pydata/xarray/issues/3333 MDEyOklzc3VlQ29tbWVudDUzMzkyODU3NA== dcherian 2448579 2019-09-22T23:34:25Z 2019-09-22T23:34:25Z MEMBER

The rest looks good though. Thanks @keewis 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More doc fixes 496826564
533928535 https://github.com/pydata/xarray/pull/3333#issuecomment-533928535 https://api.github.com/repos/pydata/xarray/issues/3333 MDEyOklzc3VlQ29tbWVudDUzMzkyODUzNQ== dcherian 2448579 2019-09-22T23:33:57Z 2019-09-22T23:33:57Z MEMBER

I've added plot.dataset_plot.scatter to plot.all (exposing xr.plot.scatter) and changed api.rst to reference plot.scatter instead of Dataset.plot.scatter. It seems harmless to me, but the information that scatter only exists for Dataset is less visible. Is that the way to fix this?

I don't know about this. We don't test for xr.plot.scatter. I don't know why adding Dataset.plot.scatter doesn't work. It would be good to track that down.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More doc fixes 496826564

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);