issue_comments

Table actions

4 rows where issue = 493108860 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

issue 1

  • NetCDF tests failing · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
531286189 https://github.com/pydata/xarray/issues/3308#issuecomment-531286189 https://api.github.com/repos/pydata/xarray/issues/3308 MDEyOklzc3VlQ29tbWVudDUzMTI4NjE4OQ== max-sixty 5635139 2019-09-13T15:36:27Z 2019-09-13T15:36:27Z MEMBER

Thanks @dcherian 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   NetCDF tests failing 493108860
531284892 https://github.com/pydata/xarray/issues/3308#issuecomment-531284892 https://api.github.com/repos/pydata/xarray/issues/3308 MDEyOklzc3VlQ29tbWVudDUzMTI4NDg5Mg== dcherian 2448579 2019-09-13T15:32:46Z 2019-09-13T15:32:46Z MEMBER

This is #3300 which is fixed by #3301 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   NetCDF tests failing 493108860
531284341 https://github.com/pydata/xarray/issues/3308#issuecomment-531284341 https://api.github.com/repos/pydata/xarray/issues/3308 MDEyOklzc3VlQ29tbWVudDUzMTI4NDM0MQ== max-sixty 5635139 2019-09-13T15:31:20Z 2019-09-13T15:31:20Z MEMBER

Thanks @crusaderky, I was confusing for another failure. This is the failure on master:

``` ___ TestH5NetCDFData.test_complex[None-FutureWarning-1] ______

self = <xarray.tests.test_backends.TestH5NetCDFData object at 0x7f39ad21e358> invalid_netcdf = None, warns = <class 'FutureWarning'>, num_warns = 1

@pytest.mark.filterwarnings("ignore:complex dtypes are supported by h5py")
@pytest.mark.parametrize(
    "invalid_netcdf, warns, num_warns",
    [(None, FutureWarning, 1), (False, FutureWarning, 1), (True, None, 0)],
)
def test_complex(self, invalid_netcdf, warns, num_warns):
    expected = Dataset({"x": ("y", np.ones(5) + 1j * np.ones(5))})
    save_kwargs = {"invalid_netcdf": invalid_netcdf}
    with pytest.warns(warns) as record:
        with self.roundtrip(expected, save_kwargs=save_kwargs) as actual:
            assert_equal(expected, actual)

  assert len(record) == num_warns

E assert 2 == 1 E + where 2 = len(WarningsChecker(record=True))

xarray/tests/test_backends.py:2185: AssertionError ___ TestH5NetCDFData.test_complex[False-FutureWarning-1] _____

self = <xarray.tests.test_backends.TestH5NetCDFData object at 0x7f39ae3fc668> invalid_netcdf = False, warns = <class 'FutureWarning'>, num_warns = 1

@pytest.mark.filterwarnings("ignore:complex dtypes are supported by h5py")
@pytest.mark.parametrize(
    "invalid_netcdf, warns, num_warns",
    [(None, FutureWarning, 1), (False, FutureWarning, 1), (True, None, 0)],
)
def test_complex(self, invalid_netcdf, warns, num_warns):
    expected = Dataset({"x": ("y", np.ones(5) + 1j * np.ones(5))})
    save_kwargs = {"invalid_netcdf": invalid_netcdf}
    with pytest.warns(warns) as record:
        with self.roundtrip(expected, save_kwargs=save_kwargs) as actual:
            assert_equal(expected, actual)

  assert len(record) == num_warns

E assert 2 == 1 E + where 2 = len(WarningsChecker(record=True))

xarray/tests/test_backends.py:2185: AssertionError ___ TestH5NetCDFData.testcomplex[True-None-0] ____

self = <xarray.tests.test_backends.TestH5NetCDFData object at 0x7f39ad2058d0> invalid_netcdf = True, warns = None, num_warns = 0

@pytest.mark.filterwarnings("ignore:complex dtypes are supported by h5py")
@pytest.mark.parametrize(
    "invalid_netcdf, warns, num_warns",
    [(None, FutureWarning, 1), (False, FutureWarning, 1), (True, None, 0)],
)
def test_complex(self, invalid_netcdf, warns, num_warns):
    expected = Dataset({"x": ("y", np.ones(5) + 1j * np.ones(5))})
    save_kwargs = {"invalid_netcdf": invalid_netcdf}
    with pytest.warns(warns) as record:
        with self.roundtrip(expected, save_kwargs=save_kwargs) as actual:
            assert_equal(expected, actual)

  assert len(record) == num_warns

E assert 1 == 0 E + where 1 = len(WarningsChecker(record=True))

xarray/tests/test_backends.py:2185: AssertionError _ TestH5NetCDFFileObject.testcomplex[None-FutureWarning-1] ___

self = <xarray.tests.test_backends.TestH5NetCDFFileObject object at 0x7f39ad7402e8> invalid_netcdf = None, warns = <class 'FutureWarning'>, num_warns = 1

@pytest.mark.filterwarnings("ignore:complex dtypes are supported by h5py")
@pytest.mark.parametrize(
    "invalid_netcdf, warns, num_warns",
    [(None, FutureWarning, 1), (False, FutureWarning, 1), (True, None, 0)],
)
def test_complex(self, invalid_netcdf, warns, num_warns):
    expected = Dataset({"x": ("y", np.ones(5) + 1j * np.ones(5))})
    save_kwargs = {"invalid_netcdf": invalid_netcdf}
    with pytest.warns(warns) as record:
        with self.roundtrip(expected, save_kwargs=save_kwargs) as actual:
            assert_equal(expected, actual)

  assert len(record) == num_warns

E assert 2 == 1 E + where 2 = len(WarningsChecker(record=True))

xarray/tests/test_backends.py:2185: AssertionError _ TestH5NetCDFFileObject.testcomplex[False-FutureWarning-1] __

self = <xarray.tests.test_backends.TestH5NetCDFFileObject object at 0x7f39ad545940> invalid_netcdf = False, warns = <class 'FutureWarning'>, num_warns = 1

@pytest.mark.filterwarnings("ignore:complex dtypes are supported by h5py")
@pytest.mark.parametrize(
    "invalid_netcdf, warns, num_warns",
    [(None, FutureWarning, 1), (False, FutureWarning, 1), (True, None, 0)],
)
def test_complex(self, invalid_netcdf, warns, num_warns):
    expected = Dataset({"x": ("y", np.ones(5) + 1j * np.ones(5))})
    save_kwargs = {"invalid_netcdf": invalid_netcdf}
    with pytest.warns(warns) as record:
        with self.roundtrip(expected, save_kwargs=save_kwargs) as actual:
            assert_equal(expected, actual)

  assert len(record) == num_warns

E assert 2 == 1 E + where 2 = len(WarningsChecker(record=True))

xarray/tests/test_backends.py:2185: AssertionError __ TestH5NetCDFFileObject.test_complex[True-None-0] __

self = <xarray.tests.test_backends.TestH5NetCDFFileObject object at 0x7f39ae20ae80> invalid_netcdf = True, warns = None, num_warns = 0

@pytest.mark.filterwarnings("ignore:complex dtypes are supported by h5py")
@pytest.mark.parametrize(
    "invalid_netcdf, warns, num_warns",
    [(None, FutureWarning, 1), (False, FutureWarning, 1), (True, None, 0)],
)
def test_complex(self, invalid_netcdf, warns, num_warns):
    expected = Dataset({"x": ("y", np.ones(5) + 1j * np.ones(5))})
    save_kwargs = {"invalid_netcdf": invalid_netcdf}
    with pytest.warns(warns) as record:
        with self.roundtrip(expected, save_kwargs=save_kwargs) as actual:
            assert_equal(expected, actual)

  assert len(record) == num_warns

E assert 1 == 0 E + where 1 = len(WarningsChecker(record=True))

xarray/tests/test_backends.py:2185: AssertionError _ TestH5NetCDFViaDaskData.testcomplex[None-FutureWarning-1] __

self = <xarray.tests.test_backends.TestH5NetCDFViaDaskData object at 0x7f39ad740b70> invalid_netcdf = None, warns = <class 'FutureWarning'>, num_warns = 1

@pytest.mark.filterwarnings("ignore:complex dtypes are supported by h5py")
@pytest.mark.parametrize(
    "invalid_netcdf, warns, num_warns",
    [(None, FutureWarning, 1), (False, FutureWarning, 1), (True, None, 0)],
)
def test_complex(self, invalid_netcdf, warns, num_warns):
    expected = Dataset({"x": ("y", np.ones(5) + 1j * np.ones(5))})
    save_kwargs = {"invalid_netcdf": invalid_netcdf}
    with pytest.warns(warns) as record:
        with self.roundtrip(expected, save_kwargs=save_kwargs) as actual:
            assert_equal(expected, actual)

  assert len(record) == num_warns

E assert 2 == 1 E + where 2 = len(WarningsChecker(record=True))

xarray/tests/test_backends.py:2185: AssertionError ___ TestH5NetCDFViaDaskData.test_complex[False-FutureWarning-1] ____

self = <xarray.tests.test_backends.TestH5NetCDFViaDaskData object at 0x7f39ae4a8d30> invalid_netcdf = False, warns = <class 'FutureWarning'>, num_warns = 1

@pytest.mark.filterwarnings("ignore:complex dtypes are supported by h5py")
@pytest.mark.parametrize(
    "invalid_netcdf, warns, num_warns",
    [(None, FutureWarning, 1), (False, FutureWarning, 1), (True, None, 0)],
)
def test_complex(self, invalid_netcdf, warns, num_warns):
    expected = Dataset({"x": ("y", np.ones(5) + 1j * np.ones(5))})
    save_kwargs = {"invalid_netcdf": invalid_netcdf}
    with pytest.warns(warns) as record:
        with self.roundtrip(expected, save_kwargs=save_kwargs) as actual:
            assert_equal(expected, actual)

  assert len(record) == num_warns

E assert 2 == 1 E + where 2 = len(WarningsChecker(record=True))

xarray/tests/test_backends.py:2185: AssertionError __ TestH5NetCDFViaDaskData.test_complex[True-None-0] ___

self = <xarray.tests.test_backends.TestH5NetCDFViaDaskData object at 0x7f39ad4ee3c8> invalid_netcdf = True, warns = None, num_warns = 0

@pytest.mark.filterwarnings("ignore:complex dtypes are supported by h5py")
@pytest.mark.parametrize(
    "invalid_netcdf, warns, num_warns",
    [(None, FutureWarning, 1), (False, FutureWarning, 1), (True, None, 0)],
)
def test_complex(self, invalid_netcdf, warns, num_warns):
    expected = Dataset({"x": ("y", np.ones(5) + 1j * np.ones(5))})
    save_kwargs = {"invalid_netcdf": invalid_netcdf}
    with pytest.warns(warns) as record:
        with self.roundtrip(expected, save_kwargs=save_kwargs) as actual:
            assert_equal(expected, actual)

  assert len(record) == num_warns

E assert 1 == 0 E + where 1 = len(WarningsChecker(record=True))

xarray/tests/test_backends.py:2185: AssertionError ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   NetCDF tests failing 493108860
531129812 https://github.com/pydata/xarray/issues/3308#issuecomment-531129812 https://api.github.com/repos/pydata/xarray/issues/3308 MDEyOklzc3VlQ29tbWVudDUzMTEyOTgxMg== crusaderky 6213168 2019-09-13T07:24:24Z 2019-09-13T07:24:24Z MEMBER

Looks like a very old fork, the min python version in master is 3.5.3. Try merging master in... 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   NetCDF tests failing 493108860

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);