issue_comments

Table actions

8 rows where issue = 490752037 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Drop 3.5 after 0.13? · 8 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
530119958 https://github.com/pydata/xarray/issues/3293#issuecomment-530119958 https://api.github.com/repos/pydata/xarray/issues/3293 MDEyOklzc3VlQ29tbWVudDUzMDExOTk1OA== shoyer 1217238 2019-09-10T21:07:05Z 2019-09-10T21:07:05Z MEMBER

(that said I'm perfectly happy to have 0.14 one week after 0.13!)

What are the semver rules for underlying versions? If we drop 3.5 support, do we need a minor version increase to 0.14, or is a patch release to 0.13.1 OK?

We don't really have strict rules about this, but I think it's friendlier to keep major version bumps of xarray's dependencies to major xarray releases (i.e., 0.13 or 0.14).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop 3.5 after 0.13? 490752037
530119620 https://github.com/pydata/xarray/issues/3293#issuecomment-530119620 https://api.github.com/repos/pydata/xarray/issues/3293 MDEyOklzc3VlQ29tbWVudDUzMDExOTYyMA== shoyer 1217238 2019-09-10T21:06:18Z 2019-09-10T21:06:18Z MEMBER

Getting rid of all the ordereddicts is a colossal change, and IMHO this release is already way too large...

I agree, I was suggesting simply dropping support for Python 3.5 without other associated changes -- those can come later.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop 3.5 after 0.13? 490752037
529885673 https://github.com/pydata/xarray/issues/3293#issuecomment-529885673 https://api.github.com/repos/pydata/xarray/issues/3293 MDEyOklzc3VlQ29tbWVudDUyOTg4NTY3Mw== max-sixty 5635139 2019-09-10T11:06:06Z 2019-09-10T11:06:06Z MEMBER

(that said I'm perfectly happy to have 0.14 one week after 0.13!)

What are the semver rules for underlying versions? If we drop 3.5 support, do we need a minor version increase to 0.14, or is a patch release to 0.13.1 OK?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop 3.5 after 0.13? 490752037
529885174 https://github.com/pydata/xarray/issues/3293#issuecomment-529885174 https://api.github.com/repos/pydata/xarray/issues/3293 MDEyOklzc3VlQ29tbWVudDUyOTg4NTE3NA== max-sixty 5635139 2019-09-10T11:04:27Z 2019-09-10T11:04:27Z MEMBER

I wasn't initially suggesting for 0.13 but not opposed to it

What about releasing 0.13 and then dropping 3.5? That way any 3.5 users have an up-to-date version and we can have a master on 3.6 very soon

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop 3.5 after 0.13? 490752037
529816440 https://github.com/pydata/xarray/issues/3293#issuecomment-529816440 https://api.github.com/repos/pydata/xarray/issues/3293 MDEyOklzc3VlQ29tbWVudDUyOTgxNjQ0MA== crusaderky 6213168 2019-09-10T07:48:22Z 2019-09-10T07:48:22Z MEMBER

(that said I'm perfectly happy to have 0.14 one week after 0.13!)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop 3.5 after 0.13? 490752037
529815841 https://github.com/pydata/xarray/issues/3293#issuecomment-529815841 https://api.github.com/repos/pydata/xarray/issues/3293 MDEyOklzc3VlQ29tbWVudDUyOTgxNTg0MQ== crusaderky 6213168 2019-09-10T07:46:40Z 2019-09-10T07:46:40Z MEMBER

Getting rid of all the ordereddicts is a colossal change, and IMHO this release is already way too large... 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop 3.5 after 0.13? 490752037
529788898 https://github.com/pydata/xarray/issues/3293#issuecomment-529788898 https://api.github.com/repos/pydata/xarray/issues/3293 MDEyOklzc3VlQ29tbWVudDUyOTc4ODg5OA== shoyer 1217238 2019-09-10T06:21:26Z 2019-09-10T06:21:26Z MEMBER

To clarify — the proposal is to drop support for Python 3.5 in the upcoming 0.13 release? Or later, in 0.14? I’d be happy to go ahead and do it now... it would be nice to be able to rely on dict iteration order and f-strings.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop 3.5 after 0.13? 490752037
529335633 https://github.com/pydata/xarray/issues/3293#issuecomment-529335633 https://api.github.com/repos/pydata/xarray/issues/3293 MDEyOklzc3VlQ29tbWVudDUyOTMzNTYzMw== crusaderky 6213168 2019-09-09T07:29:06Z 2019-09-09T07:29:06Z MEMBER

As somebody who's maintained conda in a large corporate environment, I can confirm that upgrading major version of python is a couple day's work at worst. I'm strongly in favour of a rolling policy for maintaining the last 2 versions of python supported by the official anaconda release package (as opposed to just the repo). 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop 3.5 after 0.13? 490752037

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);