issue_comments

Table actions

5 rows where issue = 490228661 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Add hypothesis test for netCDF4 roundtrip · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
528785320 https://github.com/pydata/xarray/pull/3283#issuecomment-528785320 https://api.github.com/repos/pydata/xarray/issues/3283 MDEyOklzc3VlQ29tbWVudDUyODc4NTMyMA== pep8speaks 24736507 2019-09-06T09:33:51Z 2019-10-12T09:28:07Z NONE

Hello @takluyver! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-10-12 09:28:07 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add hypothesis test for netCDF4 roundtrip 490228661
541046819 https://github.com/pydata/xarray/pull/3283#issuecomment-541046819 https://api.github.com/repos/pydata/xarray/issues/3283 MDEyOklzc3VlQ29tbWVudDU0MTA0NjgxOQ== Zac-HD 12229877 2019-10-11T12:38:06Z 2019-10-11T12:38:06Z CONTRIBUTOR

The datetime64 & timedelta64 cases don't roundtrip completely, so there are test failures. I've added these in a separate commit at the end, so it's easy to cut that back out if you prefer.

The basic problem seems to be that Hypothesis is generating timedelta64[Y], but Xarray is dealing with timedelta64[ns]:

``` ____ test_netcdf_roundtrip _____ tmp_path = PosixPath('/tmp/pytest-of-vsts/pytest-0/test_netcdf_roundtrip0') data = data(...), arr = array([293], dtype='timedelta64[Y]') ... with xr.open_dataset(tmp_path / "test.nc") as roundtripped:

      xr.testing.assert_identical(original, roundtripped)

E AssertionError: Left and right Dataset objects are not identical E
E Differing data variables: E L data (0) timedelta64[ns] -106488 days +01:41:02.290448 E R data (0) timedelta64[ns] -106488 days +01:41:02.290449

properties/test_netcdf_roundtrip.py:51: AssertionError ---------------------------------- Hypothesis ---------------------------------- Falsifying example: test_netcdf_roundtrip( tmp_path=PosixPath('/tmp/pytest-of-vsts/pytest-0/test_netcdf_roundtrip0'), data=data(...), arr=array([293], dtype='timedelta64[Y]') ) ```

So either that's a pretty serious bug, or you should specify the max_period of the timedelta dtype strategy.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add hypothesis test for netCDF4 roundtrip 490228661
540981087 https://github.com/pydata/xarray/pull/3283#issuecomment-540981087 https://api.github.com/repos/pydata/xarray/issues/3283 MDEyOklzc3VlQ29tbWVudDU0MDk4MTA4Nw== takluyver 327925 2019-10-11T09:01:35Z 2019-10-11T09:01:35Z MEMBER

Yes, sorry, it dropped off my radar. I've implemented all the changes suggested above.

The datetime64 & timedelta64 cases don't roundtrip completely, so there are test failures. I've added these in a separate commit at the end, so it's easy to cut that back out if you prefer.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add hypothesis test for netCDF4 roundtrip 490228661
540703776 https://github.com/pydata/xarray/pull/3283#issuecomment-540703776 https://api.github.com/repos/pydata/xarray/issues/3283 MDEyOklzc3VlQ29tbWVudDU0MDcwMzc3Ng== jhamman 2443309 2019-10-10T18:04:06Z 2019-10-10T18:04:34Z MEMBER

@takluyver - just checking in on this one to see if there is interested in wrapping this up. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add hypothesis test for netCDF4 roundtrip 490228661
530019002 https://github.com/pydata/xarray/pull/3283#issuecomment-530019002 https://api.github.com/repos/pydata/xarray/issues/3283 MDEyOklzc3VlQ29tbWVudDUzMDAxOTAwMg== dcherian 2448579 2019-09-10T16:34:48Z 2019-09-10T16:34:48Z MEMBER

Thanks @takluyver. LGTM but maybe @Zac-HD can review this and #3285 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add hypothesis test for netCDF4 roundtrip 490228661

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);