issue_comments

Table actions

9 rows where issue = 489270698 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

issue 1

  • Deprecation cycles to finish for xarray 0.13 · 9 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
532263016 https://github.com/pydata/xarray/issues/3280#issuecomment-532263016 https://api.github.com/repos/pydata/xarray/issues/3280 MDEyOklzc3VlQ29tbWVudDUzMjI2MzAxNg== dcherian 2448579 2019-09-17T15:05:23Z 2019-09-17T15:05:23Z MEMBER

3313 and #3314 should be looked over by someone who knows the auto_combine and groupby code.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecation cycles to finish for xarray 0.13 489270698
531361035 https://github.com/pydata/xarray/issues/3280#issuecomment-531361035 https://api.github.com/repos/pydata/xarray/issues/3280 MDEyOklzc3VlQ29tbWVudDUzMTM2MTAzNQ== shoyer 1217238 2019-09-13T19:23:00Z 2019-09-13T19:23:00Z MEMBER

Yeah, there's also some question about if combine_nested() and combine_by_coords() really solve all the use-cases of auto_combine(). For example, a bunch of files that don't contain the concatenated dimension and have different variables can be combined automatically by auto_combine() but not combine_by_coord().

On Fri, Sep 13, 2019 at 9:03 AM Deepak Cherian notifications@github.com wrote:

We were also planing to deprecate auto_combine for 0.13 but we've been warning about that only since 29 June, 2019 so that should be pushed to 0.14. I've added this to the list.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/issues/3280?email_source=notifications&email_token=AAJJFVQWOC4UEA6LGUYMJALQJO2UNA5CNFSM4ITUC3R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6VO4YI#issuecomment-531295841, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJJFVQBN7OLZHD3VOKKBATQJO2UNANCNFSM4ITUC3RQ . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecation cycles to finish for xarray 0.13 489270698
531295841 https://github.com/pydata/xarray/issues/3280#issuecomment-531295841 https://api.github.com/repos/pydata/xarray/issues/3280 MDEyOklzc3VlQ29tbWVudDUzMTI5NTg0MQ== dcherian 2448579 2019-09-13T16:03:17Z 2019-09-13T16:03:17Z MEMBER

We were also planing to deprecate auto_combine for 0.13 but we've been warning about that only since 29 June, 2019 so that should be pushed to 0.14. I've added this to the list.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecation cycles to finish for xarray 0.13 489270698
529523741 https://github.com/pydata/xarray/issues/3280#issuecomment-529523741 https://api.github.com/repos/pydata/xarray/issues/3280 MDEyOklzc3VlQ29tbWVudDUyOTUyMzc0MQ== mathause 10194086 2019-09-09T15:10:55Z 2019-09-09T15:10:55Z MEMBER

Yes, fine for me. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecation cycles to finish for xarray 0.13 489270698
529520452 https://github.com/pydata/xarray/issues/3280#issuecomment-529520452 https://api.github.com/repos/pydata/xarray/issues/3280 MDEyOklzc3VlQ29tbWVudDUyOTUyMDQ1Mg== dcherian 2448579 2019-09-09T15:04:26Z 2019-09-09T15:04:35Z MEMBER

stop supporting a list of colors in the cmap argument

I am a bit worried about the 3rd last item on your list. I currently still rely on this behavior because the alternative does not work for me, see #3284.

@mathause Does your PR mean that we can go forward with the deprecation then?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecation cycles to finish for xarray 0.13 489270698
529366898 https://github.com/pydata/xarray/issues/3280#issuecomment-529366898 https://api.github.com/repos/pydata/xarray/issues/3280 MDEyOklzc3VlQ29tbWVudDUyOTM2Njg5OA== max-sixty 5635139 2019-09-09T08:54:23Z 2019-09-09T08:54:23Z MEMBER

I think all the 'must-dos' are done

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecation cycles to finish for xarray 0.13 489270698
529197236 https://github.com/pydata/xarray/issues/3280#issuecomment-529197236 https://api.github.com/repos/pydata/xarray/issues/3280 MDEyOklzc3VlQ29tbWVudDUyOTE5NzIzNg== max-sixty 5635139 2019-09-08T12:17:19Z 2019-09-08T12:17:19Z MEMBER

@shoyer I edited your comment to check-off the ones in #3292, hope that's OK. (would be good to have a system from GH that didn't involve free editing of others' comments!)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecation cycles to finish for xarray 0.13 489270698
528950471 https://github.com/pydata/xarray/issues/3280#issuecomment-528950471 https://api.github.com/repos/pydata/xarray/issues/3280 MDEyOklzc3VlQ29tbWVudDUyODk1MDQ3MQ== shoyer 1217238 2019-09-06T17:49:28Z 2019-09-06T17:49:28Z MEMBER

stop supporting a list of colors in the cmap argument

I am a bit worried about the 3rd last item on your list. I currently still rely on this behavior because the alternative does not work for me, see #3284.

OK, we should put this off until the alternative works! But I do think we want to stop overloading cmap in an incompatible way.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecation cycles to finish for xarray 0.13 489270698
528787208 https://github.com/pydata/xarray/issues/3280#issuecomment-528787208 https://api.github.com/repos/pydata/xarray/issues/3280 MDEyOklzc3VlQ29tbWVudDUyODc4NzIwOA== mathause 10194086 2019-09-06T09:39:51Z 2019-09-06T09:39:51Z MEMBER

stop supporting a list of colors in the cmap argument

I am a bit worried about the 3rd last item on your list. I currently still rely on this behavior because the alternative does not work for me, see #3284.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecation cycles to finish for xarray 0.13 489270698

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);