issue_comments

Table actions

6 rows where issue = 488812619 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Add head, tail and thin methods · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
528207788 https://github.com/pydata/xarray/pull/3278#issuecomment-528207788 https://api.github.com/repos/pydata/xarray/issues/3278 MDEyOklzc3VlQ29tbWVudDUyODIwNzc4OA== griverat 23618263 2019-09-05T05:48:33Z 2019-09-05T05:48:33Z CONTRIBUTOR

Thanks @max-sixty @shoyer !! I also agree with your suggestions and will be working on adding the default values during these days.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add head, tail and thin methods 488812619
528190551 https://github.com/pydata/xarray/pull/3278#issuecomment-528190551 https://api.github.com/repos/pydata/xarray/issues/3278 MDEyOklzc3VlQ29tbWVudDUyODE5MDU1MQ== max-sixty 5635139 2019-09-05T04:22:19Z 2019-09-05T04:22:19Z MEMBER

Great!

In the spirit of faster iteration, I'll merge this @DangoMelon and then if you want to add default values (I also like the idea of supporting a single value), please go ahead!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add head, tail and thin methods 488812619
528188475 https://github.com/pydata/xarray/pull/3278#issuecomment-528188475 https://api.github.com/repos/pydata/xarray/issues/3278 MDEyOklzc3VlQ29tbWVudDUyODE4ODQ3NQ== shoyer 1217238 2019-09-05T04:10:36Z 2019-09-05T04:10:36Z MEMBER

But yes, I agree with @max-sixty this looks great, and already ready to merge!

If you don't have time to work on default values and/or integers now, we can always merge this PR now and leave those backwards compatible API changes for later :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add head, tail and thin methods 488812619
528188128 https://github.com/pydata/xarray/pull/3278#issuecomment-528188128 https://api.github.com/repos/pydata/xarray/issues/3278 MDEyOklzc3VlQ29tbWVudDUyODE4ODEyOA== shoyer 1217238 2019-09-05T04:08:55Z 2019-09-05T04:08:55Z MEMBER

Do we want to support integer values, indicating that an operation should be applied to all dimensions? e.g., supposing ds has dimensions x and y, then ds.head(5) would be equivalent to ds.head(x=5, y=5).

This would be a natural way to support a default value (if we want that) -- we could simply set the default value to 5, so ds.head() -> ds.head(5) -> ds.head(x=5, y=5).

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add head, tail and thin methods 488812619
527631074 https://github.com/pydata/xarray/pull/3278#issuecomment-527631074 https://api.github.com/repos/pydata/xarray/issues/3278 MDEyOklzc3VlQ29tbWVudDUyNzYzMTA3NA== pep8speaks 24736507 2019-09-03T20:41:52Z 2019-09-04T19:28:37Z NONE

Hello @DangoMelon! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-09-04 19:28:37 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add head, tail and thin methods 488812619
527738615 https://github.com/pydata/xarray/pull/3278#issuecomment-527738615 https://api.github.com/repos/pydata/xarray/issues/3278 MDEyOklzc3VlQ29tbWVudDUyNzczODYxNQ== max-sixty 5635139 2019-09-04T04:50:16Z 2019-09-04T04:50:16Z MEMBER

Looks great! V good first effort @DangoMelon

Any thoughts from others? Do we want a default (e.g. 5)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add head, tail and thin methods 488812619

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);