issue_comments

Table actions

19 rows where issue = 488243328 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • map_blocks · 19 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
540863450 https://github.com/pydata/xarray/pull/3276#issuecomment-540863450 https://api.github.com/repos/pydata/xarray/issues/3276 MDEyOklzc3VlQ29tbWVudDU0MDg2MzQ1MA== dcherian 2448579 2019-10-11T01:37:42Z 2019-10-11T01:37:42Z MEMBER

!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   map_blocks 488243328
540852090 https://github.com/pydata/xarray/pull/3276#issuecomment-540852090 https://api.github.com/repos/pydata/xarray/issues/3276 MDEyOklzc3VlQ29tbWVudDU0MDg1MjA5MA== shoyer 1217238 2019-10-11T00:34:05Z 2019-10-11T00:34:05Z MEMBER

yes, nice work @dcherian and @crusaderky !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   map_blocks 488243328
540846421 https://github.com/pydata/xarray/pull/3276#issuecomment-540846421 https://api.github.com/repos/pydata/xarray/issues/3276 MDEyOklzc3VlQ29tbWVudDU0MDg0NjQyMQ== jakirkham 3019665 2019-10-11T00:03:25Z 2019-10-11T00:03:25Z NONE

Congratulations! 🎉

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   map_blocks 488243328
540845620 https://github.com/pydata/xarray/pull/3276#issuecomment-540845620 https://api.github.com/repos/pydata/xarray/issues/3276 MDEyOklzc3VlQ29tbWVudDU0MDg0NTYyMA== jhamman 2443309 2019-10-10T23:59:37Z 2019-10-10T23:59:37Z MEMBER

Fantastic work all! This is going to be a killer addition to the project. 🎉 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   map_blocks 488243328
540843642 https://github.com/pydata/xarray/pull/3276#issuecomment-540843642 https://api.github.com/repos/pydata/xarray/issues/3276 MDEyOklzc3VlQ29tbWVudDU0MDg0MzY0Mg== mrocklin 306380 2019-10-10T23:49:12Z 2019-10-10T23:49:12Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   map_blocks 488243328
540842654 https://github.com/pydata/xarray/pull/3276#issuecomment-540842654 https://api.github.com/repos/pydata/xarray/issues/3276 MDEyOklzc3VlQ29tbWVudDU0MDg0MjY1NA== crusaderky 6213168 2019-10-10T23:44:15Z 2019-10-10T23:44:15Z MEMBER

Thank you

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   map_blocks 488243328
540837143 https://github.com/pydata/xarray/pull/3276#issuecomment-540837143 https://api.github.com/repos/pydata/xarray/issues/3276 MDEyOklzc3VlQ29tbWVudDU0MDgzNzE0Mw== dcherian 2448579 2019-10-10T23:19:37Z 2019-10-10T23:19:37Z MEMBER

Added one line to docstring. Looks good otherwise. Thanks @crusaderky 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   map_blocks 488243328
540829670 https://github.com/pydata/xarray/pull/3276#issuecomment-540829670 https://api.github.com/repos/pydata/xarray/issues/3276 MDEyOklzc3VlQ29tbWVudDU0MDgyOTY3MA== crusaderky 6213168 2019-10-10T22:46:47Z 2019-10-10T22:46:47Z MEMBER

@dcherian I gave it a polish pass, please review my changes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   map_blocks 488243328
540703057 https://github.com/pydata/xarray/pull/3276#issuecomment-540703057 https://api.github.com/repos/pydata/xarray/issues/3276 MDEyOklzc3VlQ29tbWVudDU0MDcwMzA1Nw== jhamman 2443309 2019-10-10T18:02:19Z 2019-10-10T18:02:19Z MEMBER

@crusaderky - are we happy here? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   map_blocks 488243328
540627439 https://github.com/pydata/xarray/pull/3276#issuecomment-540627439 https://api.github.com/repos/pydata/xarray/issues/3276 MDEyOklzc3VlQ29tbWVudDU0MDYyNzQzOQ== dcherian 2448579 2019-10-10T14:57:43Z 2019-10-10T14:57:43Z MEMBER

@crusaderky should be fixed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   map_blocks 488243328
540482043 https://github.com/pydata/xarray/pull/3276#issuecomment-540482043 https://api.github.com/repos/pydata/xarray/issues/3276 MDEyOklzc3VlQ29tbWVudDU0MDQ4MjA0Mw== crusaderky 6213168 2019-10-10T09:24:34Z 2019-10-10T09:24:34Z MEMBER

@dcherian make_meta is failing on dask 1.2

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   map_blocks 488243328
539780023 https://github.com/pydata/xarray/pull/3276#issuecomment-539780023 https://api.github.com/repos/pydata/xarray/issues/3276 MDEyOklzc3VlQ29tbWVudDUzOTc4MDAyMw== dcherian 2448579 2019-10-09T01:38:12Z 2019-10-09T01:38:12Z MEMBER

hahaha the conflict was that you deleted dask_array_compat! I added it back in for meta_from_array

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   map_blocks 488243328
539748209 https://github.com/pydata/xarray/pull/3276#issuecomment-539748209 https://api.github.com/repos/pydata/xarray/issues/3276 MDEyOklzc3VlQ29tbWVudDUzOTc0ODIwOQ== crusaderky 6213168 2019-10-08T23:35:29Z 2019-10-08T23:35:29Z MEMBER

@jhamman I'd like to give it a final read. @dcherian merge's failing right now

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   map_blocks 488243328
539715212 https://github.com/pydata/xarray/pull/3276#issuecomment-539715212 https://api.github.com/repos/pydata/xarray/issues/3276 MDEyOklzc3VlQ29tbWVudDUzOTcxNTIxMg== jhamman 2443309 2019-10-08T21:38:14Z 2019-10-08T21:38:14Z MEMBER

@crusaderky - are you happy with the state of things here?

I plan to merge this tomorrow evening unless additional reviews come in.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   map_blocks 488243328
538004304 https://github.com/pydata/xarray/pull/3276#issuecomment-538004304 https://api.github.com/repos/pydata/xarray/issues/3276 MDEyOklzc3VlQ29tbWVudDUzODAwNDMwNA== dcherian 2448579 2019-10-03T15:47:51Z 2019-10-03T15:47:51Z MEMBER

Thanks for the type annotations, @crusaderky.

map_blocks now handles attrs and name changes so I've switched almost all tests to assert_identical. I'm calling compute manually till we can figure out what's wrong with assert_equal (e.g. #3350). The only exception is Dataset.to_array() which doesn't preserve name.

I copied over meta_to_array to account for dask < 2.0

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   map_blocks 488243328
533589666 https://github.com/pydata/xarray/pull/3276#issuecomment-533589666 https://api.github.com/repos/pydata/xarray/issues/3276 MDEyOklzc3VlQ29tbWVudDUzMzU4OTY2Ng== dcherian 2448579 2019-09-20T15:00:39Z 2019-09-20T15:00:39Z MEMBER

Ready for review. I failed hard at adding types, so some help there would be appreciated.

Otherwise I think I've made all changes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   map_blocks 488243328
531481714 https://github.com/pydata/xarray/pull/3276#issuecomment-531481714 https://api.github.com/repos/pydata/xarray/issues/3276 MDEyOklzc3VlQ29tbWVudDUzMTQ4MTcxNA== dcherian 2448579 2019-09-14T13:56:19Z 2019-09-14T13:56:19Z MEMBER

Thanks for the extremely thorough review @crusaderky. I'll work on this slowly over the next few days

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   map_blocks 488243328
531443628 https://github.com/pydata/xarray/pull/3276#issuecomment-531443628 https://api.github.com/repos/pydata/xarray/issues/3276 MDEyOklzc3VlQ29tbWVudDUzMTQ0MzYyOA== dcherian 2448579 2019-09-14T03:12:39Z 2019-09-14T03:12:39Z MEMBER

Ready for review.

@crusaderky I'd like to add DataArray.map_blocks and Dataset.map_blocks but don't know how to work around the circular import issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   map_blocks 488243328
529167703 https://github.com/pydata/xarray/pull/3276#issuecomment-529167703 https://api.github.com/repos/pydata/xarray/issues/3276 MDEyOklzc3VlQ29tbWVudDUyOTE2NzcwMw== dcherian 2448579 2019-09-08T04:05:21Z 2019-09-08T06:38:32Z MEMBER

I can reconstruct Datasets now. ~This version requires a template kwarg to know what the returned object looks like. I'll add some code to infer that next.~

Now infers properties of the returned object.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   map_blocks 488243328

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);