issue_comments

Table actions

13 rows where issue = 487746465 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Use drawstyle instead of linestyle in plot.step. · 13 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
604166273 https://github.com/pydata/xarray/pull/3274#issuecomment-604166273 https://api.github.com/repos/pydata/xarray/issues/3274 MDEyOklzc3VlQ29tbWVudDYwNDE2NjI3Mw== dcherian 2448579 2020-03-26T00:54:09Z 2020-03-26T00:54:09Z MEMBER

Got it. Thanks @QuLogic

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use drawstyle instead of linestyle in plot.step. 487746465
604164703 https://github.com/pydata/xarray/pull/3274#issuecomment-604164703 https://api.github.com/repos/pydata/xarray/issues/3274 MDEyOklzc3VlQ29tbWVudDYwNDE2NDcwMw== max-sixty 5635139 2020-03-26T00:47:50Z 2020-03-26T00:47:50Z MEMBER

Thanks @QuLogic !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use drawstyle instead of linestyle in plot.step. 487746465
604142368 https://github.com/pydata/xarray/pull/3274#issuecomment-604142368 https://api.github.com/repos/pydata/xarray/issues/3274 MDEyOklzc3VlQ29tbWVudDYwNDE0MjM2OA== max-sixty 5635139 2020-03-25T23:27:48Z 2020-03-25T23:27:48Z MEMBER

Yes agree! Let's merge on green

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use drawstyle instead of linestyle in plot.step. 487746465
604139693 https://github.com/pydata/xarray/pull/3274#issuecomment-604139693 https://api.github.com/repos/pydata/xarray/issues/3274 MDEyOklzc3VlQ29tbWVudDYwNDEzOTY5Mw== QuLogic 302469 2020-03-25T23:20:18Z 2020-03-25T23:20:18Z CONTRIBUTOR

@pep8speaks seems a little broken... Line 328 is an empty line.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 1,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use drawstyle instead of linestyle in plot.step. 487746465
604138577 https://github.com/pydata/xarray/pull/3274#issuecomment-604138577 https://api.github.com/repos/pydata/xarray/issues/3274 MDEyOklzc3VlQ29tbWVudDYwNDEzODU3Nw== pep8speaks 24736507 2020-03-25T23:17:45Z 2020-03-25T23:17:45Z NONE

Hello @QuLogic! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 72:3: E111 indentation is not a multiple of four Line 85:3: E111 indentation is not a multiple of four Line 89:3: E111 indentation is not a multiple of four Line 92:3: E111 indentation is not a multiple of four Line 101:3: E111 indentation is not a multiple of four Line 110:3: E111 indentation is not a multiple of four Line 112:3: E111 indentation is not a multiple of four Line 115:3: E111 indentation is not a multiple of four Line 118:3: E111 indentation is not a multiple of four Line 121:7: E111 indentation is not a multiple of four Line 124:3: E111 indentation is not a multiple of four Line 127:7: E114 indentation is not a multiple of four (comment) Line 128:7: E114 indentation is not a multiple of four (comment) Line 129:7: E111 indentation is not a multiple of four Line 132:3: E111 indentation is not a multiple of four Line 137:3: E111 indentation is not a multiple of four Line 146:3: E111 indentation is not a multiple of four Line 148:7: E111 indentation is not a multiple of four Line 150:7: E111 indentation is not a multiple of four Line 154:3: E111 indentation is not a multiple of four Line 162:3: E111 indentation is not a multiple of four Line 164:7: E111 indentation is not a multiple of four Line 183:3: E111 indentation is not a multiple of four Line 208:3: E111 indentation is not a multiple of four Line 211:3: E111 indentation is not a multiple of four Line 212:3: E111 indentation is not a multiple of four Line 218:3: E111 indentation is not a multiple of four Line 223:3: E111 indentation is not a multiple of four Line 226:3: E114 indentation is not a multiple of four (comment) Line 227:3: E114 indentation is not a multiple of four (comment) Line 228:3: E114 indentation is not a multiple of four (comment) Line 229:3: E114 indentation is not a multiple of four (comment) Line 230:3: E114 indentation is not a multiple of four (comment) Line 231:3: E111 indentation is not a multiple of four Line 243:3: E111 indentation is not a multiple of four Line 254:3: E111 indentation is not a multiple of four Line 255:3: E114 indentation is not a multiple of four (comment) Line 256:3: E114 indentation is not a multiple of four (comment) Line 257:3: E114 indentation is not a multiple of four (comment) Line 258:3: E114 indentation is not a multiple of four (comment) Line 259:3: E114 indentation is not a multiple of four (comment) Line 260:3: E111 indentation is not a multiple of four Line 262:3: E111 indentation is not a multiple of four Line 265:7: E114 indentation is not a multiple of four (comment) Line 266:7: E111 indentation is not a multiple of four Line 267:7: E111 indentation is not a multiple of four Line 269:7: E111 indentation is not a multiple of four Line 298:3: E111 indentation is not a multiple of four Line 299:3: E111 indentation is not a multiple of four Line 301:3: E111 indentation is not a multiple of four Line 302:3: E111 indentation is not a multiple of four Line 303:3: E111 indentation is not a multiple of four Line 305:3: E114 indentation is not a multiple of four (comment) Line 306:3: E111 indentation is not a multiple of four Line 307:3: E111 indentation is not a multiple of four Line 310:3: E111 indentation is not a multiple of four Line 317:3: E114 indentation is not a multiple of four (comment) Line 318:3: E114 indentation is not a multiple of four (comment) Line 319:3: E111 indentation is not a multiple of four Line 323:3: E114 indentation is not a multiple of four (comment) Line 324:3: E111 indentation is not a multiple of four Line 325:3: E111 indentation is not a multiple of four Line 328:3: E111 indentation is not a multiple of four Line 332:3: E111 indentation is not a multiple of four Line 334:3: E111 indentation is not a multiple of four Line 338:3: E111 indentation is not a multiple of four Line 340:3: E111 indentation is not a multiple of four Line 341:24: W504 line break after binary operator Line 342:5: E129 visually indented line with same indent as next logical line Line 343:7: E111 indentation is not a multiple of four Line 347:3: E111 indentation is not a multiple of four Line 350:3: E111 indentation is not a multiple of four Line 355:5: E125 continuation line with same indent as next logical line Line 356:3: E111 indentation is not a multiple of four Line 372:3: E114 indentation is not a multiple of four (comment) Line 373:3: E111 indentation is not a multiple of four Line 377:3: E111 indentation is not a multiple of four Line 380:3: E114 indentation is not a multiple of four (comment) Line 381:3: E111 indentation is not a multiple of four Line 383:7: E111 indentation is not a multiple of four Line 384:7: E111 indentation is not a multiple of four Line 387:7: E111 indentation is not a multiple of four Line 391:3: E114 indentation is not a multiple of four (comment) Line 392:3: E114 indentation is not a multiple of four (comment) Line 393:3: E111 indentation is not a multiple of four Line 400:3: E111 indentation is not a multiple of four Line 400:57: W504 line break after binary operator Line 401:7: E129 visually indented line with same indent as next logical line Line 405:17: E721 do not compare types, use 'isinstance()' Line 406:7: E111 indentation is not a multiple of four Line 407:7: E111 indentation is not a multiple of four Line 409:3: E111 indentation is not a multiple of four Line 410:3: E111 indentation is not a multiple of four Line 428:7: E111 indentation is not a multiple of four Line 430:7: E111 indentation is not a multiple of four Line 434:7: E111 indentation is not a multiple of four Line 435:7: E111 indentation is not a multiple of four Line 438:11: E125 continuation line with same indent as next logical line Line 443:3: E111 indentation is not a multiple of four Line 448:7: E111 indentation is not a multiple of four Line 452:7: E111 indentation is not a multiple of four Line 453:7: E111 indentation is not a multiple of four Line 455:3: E111 indentation is not a multiple of four Line 456:3: E111 indentation is not a multiple of four Line 460:3: E111 indentation is not a multiple of four Line 462:3: E111 indentation is not a multiple of four Line 468:3: E111 indentation is not a multiple of four Line 470:3: E111 indentation is not a multiple of four Line 477:3: E111 indentation is not a multiple of four Line 494:3: E111 indentation is not a multiple of four Line 496:3: E111 indentation is not a multiple of four Line 498:3: E111 indentation is not a multiple of four Line 500:3: E111 indentation is not a multiple of four Line 502:7: E111 indentation is not a multiple of four Line 505:3: E111 indentation is not a multiple of four Line 509:3: E111 indentation is not a multiple of four Line 511:3: E111 indentation is not a multiple of four Line 520:3: E111 indentation is not a multiple of four Line 521:3: E111 indentation is not a multiple of four Line 522:3: E111 indentation is not a multiple of four Line 539:3: E111 indentation is not a multiple of four Line 543:3: E111 indentation is not a multiple of four Line 545:3: E111 indentation is not a multiple of four Line 546:3: E111 indentation is not a multiple of four Line 547:3: E111 indentation is not a multiple of four Line 548:3: E114 indentation is not a multiple of four (comment) Line 550:3: E114 indentation is not a multiple of four (comment) Line 551:3: E114 indentation is not a multiple of four (comment) Line 552:3: E114 indentation is not a multiple of four (comment) Line 553:3: E114 indentation is not a multiple of four (comment) Line 554:3: E114 indentation is not a multiple of four (comment) Line 555:3: E111 indentation is not a multiple of four Line 558:7: E111 indentation is not a multiple of four Line 565:3: E114 indentation is not a multiple of four (comment) Line 566:3: E111 indentation is not a multiple of four Line 568:3: E111 indentation is not a multiple of four Line 569:3: E111 indentation is not a multiple of four Line 570:3: E111 indentation is not a multiple of four Line 572:3: E111 indentation is not a multiple of four Line 574:3: E111 indentation is not a multiple of four Line 576:3: E111 indentation is not a multiple of four Line 579:3: E111 indentation is not a multiple of four Line 584:3: E111 indentation is not a multiple of four Line 585:3: E111 indentation is not a multiple of four Line 587:3: E111 indentation is not a multiple of four Line 594:3: E111 indentation is not a multiple of four Line 596:3: E111 indentation is not a multiple of four Line 599:3: E111 indentation is not a multiple of four Line 603:3: E111 indentation is not a multiple of four Line 615:3: E114 indentation is not a multiple of four (comment) Line 616:3: E111 indentation is not a multiple of four Line 618:3: E111 indentation is not a multiple of four Line 619:3: E111 indentation is not a multiple of four Line 620:3: E111 indentation is not a multiple of four Line 621:3: E111 indentation is not a multiple of four Line 622:3: E111 indentation is not a multiple of four Line 623:3: E111 indentation is not a multiple of four Line 625:3: E114 indentation is not a multiple of four (comment) Line 626:3: E114 indentation is not a multiple of four (comment) Line 627:3: E114 indentation is not a multiple of four (comment) Line 628:3: E111 indentation is not a multiple of four Line 629:3: E111 indentation is not a multiple of four Line 630:3: E111 indentation is not a multiple of four Line 633:3: E111 indentation is not a multiple of four Line 634:3: E111 indentation is not a multiple of four Line 635:3: E111 indentation is not a multiple of four Line 636:3: E111 indentation is not a multiple of four Line 637:3: E111 indentation is not a multiple of four

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use drawstyle instead of linestyle in plot.step. 487746465
603722099 https://github.com/pydata/xarray/pull/3274#issuecomment-603722099 https://api.github.com/repos/pydata/xarray/issues/3274 MDEyOklzc3VlQ29tbWVudDYwMzcyMjA5OQ== mathause 10194086 2020-03-25T08:58:02Z 2020-03-25T08:58:02Z MEMBER

Does this need a deprecation message or is this handled by matplotlib?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use drawstyle instead of linestyle in plot.step. 487746465
603649349 https://github.com/pydata/xarray/pull/3274#issuecomment-603649349 https://api.github.com/repos/pydata/xarray/issues/3274 MDEyOklzc3VlQ29tbWVudDYwMzY0OTM0OQ== QuLogic 302469 2020-03-25T05:32:25Z 2020-03-25T05:32:25Z CONTRIBUTOR

Done.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use drawstyle instead of linestyle in plot.step. 487746465
596016815 https://github.com/pydata/xarray/pull/3274#issuecomment-596016815 https://api.github.com/repos/pydata/xarray/issues/3274 MDEyOklzc3VlQ29tbWVudDU5NjAxNjgxNQ== QuLogic 302469 2020-03-07T00:13:29Z 2020-03-07T00:13:29Z CONTRIBUTOR

Sorry I lost track of this; I will rebase soon and update.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use drawstyle instead of linestyle in plot.step. 487746465
547452024 https://github.com/pydata/xarray/pull/3274#issuecomment-547452024 https://api.github.com/repos/pydata/xarray/issues/3274 MDEyOklzc3VlQ29tbWVudDU0NzQ1MjAyNA== max-sixty 5635139 2019-10-29T14:37:00Z 2019-10-29T14:37:00Z MEMBER

@QuLogic this is so close! How would you feel about a test & whatsnew entry? Then we can merge.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use drawstyle instead of linestyle in plot.step. 487746465
540630950 https://github.com/pydata/xarray/pull/3274#issuecomment-540630950 https://api.github.com/repos/pydata/xarray/issues/3274 MDEyOklzc3VlQ29tbWVudDU0MDYzMDk1MA== dcherian 2448579 2019-10-10T15:05:19Z 2019-10-10T15:05:19Z MEMBER

Looks like our min matplotlib is now 3.1.0. @QuLogic can you add a test and whats-new entry please?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use drawstyle instead of linestyle in plot.step. 487746465
535365202 https://github.com/pydata/xarray/pull/3274#issuecomment-535365202 https://api.github.com/repos/pydata/xarray/issues/3274 MDEyOklzc3VlQ29tbWVudDUzNTM2NTIwMg== QuLogic 302469 2019-09-26T06:50:57Z 2019-09-26T06:50:57Z CONTRIBUTOR 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use drawstyle instead of linestyle in plot.step. 487746465
527149935 https://github.com/pydata/xarray/pull/3274#issuecomment-527149935 https://api.github.com/repos/pydata/xarray/issues/3274 MDEyOklzc3VlQ29tbWVudDUyNzE0OTkzNQ== dcherian 2448579 2019-09-02T13:32:51Z 2019-09-02T13:32:51Z MEMBER

Hmmm... this is backwards-incompatible so we'll have to be careful.

Mixing the two is deprecated in Matplotlib 3.1

What does this mean? I couldn't find anything in the release notes...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use drawstyle instead of linestyle in plot.step. 487746465
526815188 https://github.com/pydata/xarray/pull/3274#issuecomment-526815188 https://api.github.com/repos/pydata/xarray/issues/3274 MDEyOklzc3VlQ29tbWVudDUyNjgxNTE4OA== max-sixty 5635139 2019-08-31T09:17:09Z 2019-08-31T09:17:09Z MEMBER

Thanks @QuLogic !

If you want to add a whatsnew and give yourself credit, please do. Given it silences a warning, I don't think we necessarily need a test; if you have an easy one to add then feel free.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use drawstyle instead of linestyle in plot.step. 487746465

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);