issue_comments

Table actions

8 rows where issue = 484243962 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Update filter_by_attrs to use 'variables' instead of 'data_vars' · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
524491631 https://github.com/pydata/xarray/pull/3247#issuecomment-524491631 https://api.github.com/repos/pydata/xarray/issues/3247 MDEyOklzc3VlQ29tbWVudDUyNDQ5MTYzMQ== dcherian 2448579 2019-08-23T23:27:02Z 2019-08-23T23:27:02Z MEMBER

Oh no! I forgot to ask you to add a note in whats-new.rst. Can you send in a new PR with a small note in that file please?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update filter_by_attrs to use 'variables' instead of 'data_vars' 484243962
524491485 https://github.com/pydata/xarray/pull/3247#issuecomment-524491485 https://api.github.com/repos/pydata/xarray/issues/3247 MDEyOklzc3VlQ29tbWVudDUyNDQ5MTQ4NQ== dcherian 2448579 2019-08-23T23:25:56Z 2019-08-23T23:25:56Z MEMBER

Thanks @cspencerjones 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update filter_by_attrs to use 'variables' instead of 'data_vars' 484243962
524444168 https://github.com/pydata/xarray/pull/3247#issuecomment-524444168 https://api.github.com/repos/pydata/xarray/issues/3247 MDEyOklzc3VlQ29tbWVudDUyNDQ0NDE2OA== max-sixty 5635139 2019-08-23T20:02:40Z 2019-08-23T20:02:40Z MEMBER

Thanks @cspencerjones ! Great to have you as a contributor

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update filter_by_attrs to use 'variables' instead of 'data_vars' 484243962
524400858 https://github.com/pydata/xarray/pull/3247#issuecomment-524400858 https://api.github.com/repos/pydata/xarray/issues/3247 MDEyOklzc3VlQ29tbWVudDUyNDQwMDg1OA== pep8speaks 24736507 2019-08-23T17:38:30Z 2019-08-23T19:03:46Z NONE

Hello @cspencerjones! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-08-23 19:03:46 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update filter_by_attrs to use 'variables' instead of 'data_vars' 484243962
524400034 https://github.com/pydata/xarray/pull/3247#issuecomment-524400034 https://api.github.com/repos/pydata/xarray/issues/3247 MDEyOklzc3VlQ29tbWVudDUyNDQwMDAzNA== dopplershift 221526 2019-08-23T17:35:49Z 2019-08-23T17:35:49Z CONTRIBUTOR

cc: @jthielen Might make some things in MetPy easier...

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update filter_by_attrs to use 'variables' instead of 'data_vars' 484243962
524388856 https://github.com/pydata/xarray/pull/3247#issuecomment-524388856 https://api.github.com/repos/pydata/xarray/issues/3247 MDEyOklzc3VlQ29tbWVudDUyNDM4ODg1Ng== dcherian 2448579 2019-08-23T16:59:32Z 2019-08-23T16:59:32Z MEMBER

Exactly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update filter_by_attrs to use 'variables' instead of 'data_vars' 484243962
524323480 https://github.com/pydata/xarray/pull/3247#issuecomment-524323480 https://api.github.com/repos/pydata/xarray/issues/3247 MDEyOklzc3VlQ29tbWVudDUyNDMyMzQ4MA== ocefpaf 950575 2019-08-23T13:51:48Z 2019-08-23T13:51:48Z CONTRIBUTOR

Thanks @cspencerjones . Can you add a test that tests this?

I guess we can just extend the existing test and check if we can find a coordinate by its attributes. For example, add a standard name for time here and see if we can find time using it.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update filter_by_attrs to use 'variables' instead of 'data_vars' 484243962
524124262 https://github.com/pydata/xarray/pull/3247#issuecomment-524124262 https://api.github.com/repos/pydata/xarray/issues/3247 MDEyOklzc3VlQ29tbWVudDUyNDEyNDI2Mg== dcherian 2448579 2019-08-23T00:12:50Z 2019-08-23T00:12:50Z MEMBER

Thanks @cspencerjones . Can you add a test that tests this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Update filter_by_attrs to use 'variables' instead of 'data_vars' 484243962

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);