issue_comments

Table actions

7 rows where issue = 484212164 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 4

author_association 2

issue 1

  • Make argmin/max work lazy with dask · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
525404314 https://github.com/pydata/xarray/pull/3244#issuecomment-525404314 https://api.github.com/repos/pydata/xarray/issues/3244 MDEyOklzc3VlQ29tbWVudDUyNTQwNDMxNA== ulijh 13190237 2019-08-27T17:31:41Z 2019-08-27T17:31:41Z CONTRIBUTOR

Thanks guys!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Make argmin/max work lazy with dask 484212164
525396502 https://github.com/pydata/xarray/pull/3244#issuecomment-525396502 https://api.github.com/repos/pydata/xarray/issues/3244 MDEyOklzc3VlQ29tbWVudDUyNTM5NjUwMg== shoyer 1217238 2019-08-27T17:11:40Z 2019-08-27T17:11:40Z MEMBER

We recommend using "merge master". It looks like our contributor guidelines need to be updated here so don't hesitate to ask any questions.

On Tue, Aug 27, 2019 at 8:53 AM ulijh notifications@github.com wrote:

May be this is a stupid question: What's the best way to resolve this conflict, and get the checks to run? Should I do a merge master? Or rebase (seems somewhat of a pain to get the remote up to date)? Thanks for the advice!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/3244?email_source=notifications&email_token=AAJJFVQAAE3MFYV7TYISC5LQGVEY3A5CNFSM4IOZF562YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5IHB2I#issuecomment-525365481, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJJFVVE2BSI2T76X6CAHC3QGVEY3ANCNFSM4IOZF56Q . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Make argmin/max work lazy with dask 484212164
525367937 https://github.com/pydata/xarray/pull/3244#issuecomment-525367937 https://api.github.com/repos/pydata/xarray/issues/3244 MDEyOklzc3VlQ29tbWVudDUyNTM2NzkzNw== dcherian 2448579 2019-08-27T15:59:16Z 2019-08-27T15:59:16Z MEMBER

Merge master is enough. I just did it to kick off the tests.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Make argmin/max work lazy with dask 484212164
525365481 https://github.com/pydata/xarray/pull/3244#issuecomment-525365481 https://api.github.com/repos/pydata/xarray/issues/3244 MDEyOklzc3VlQ29tbWVudDUyNTM2NTQ4MQ== ulijh 13190237 2019-08-27T15:53:46Z 2019-08-27T15:53:46Z CONTRIBUTOR

May be this is a stupid question: What's the best way to resolve this conflict, and get the checks to run? Should I do a merge master? Or rebase (seems somewhat of a pain to get the remote up to date)? Thanks for the advice!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Make argmin/max work lazy with dask 484212164
524277968 https://github.com/pydata/xarray/pull/3244#issuecomment-524277968 https://api.github.com/repos/pydata/xarray/issues/3244 MDEyOklzc3VlQ29tbWVudDUyNDI3Nzk2OA== ulijh 13190237 2019-08-23T11:19:45Z 2019-08-23T11:21:03Z CONTRIBUTOR

Guys, if you could have a look at the tests I modified (a4c3622) to check how many times things get computed. I tried to integrate it with the existing tests. The number of count check could possibly be applied to some other tests as well. May be there is a smarter way of doing this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Make argmin/max work lazy with dask 484212164
524078960 https://github.com/pydata/xarray/pull/3244#issuecomment-524078960 https://api.github.com/repos/pydata/xarray/issues/3244 MDEyOklzc3VlQ29tbWVudDUyNDA3ODk2MA== ulijh 13190237 2019-08-22T21:10:27Z 2019-08-22T21:10:27Z CONTRIBUTOR

Thanks @max-sixty! Sure, I'll do this tomorrow then.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Make argmin/max work lazy with dask 484212164
524077985 https://github.com/pydata/xarray/pull/3244#issuecomment-524077985 https://api.github.com/repos/pydata/xarray/issues/3244 MDEyOklzc3VlQ29tbWVudDUyNDA3Nzk4NQ== max-sixty 5635139 2019-08-22T21:07:15Z 2019-08-22T21:07:15Z MEMBER

This looks good @ulijh ! Thanks

Could you add a test? Also feel free to give yourself credit in a whatsnew

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Make argmin/max work lazy with dask 484212164

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);