issue_comments

Table actions

6 rows where issue = 481250429 and user = 6213168 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • crusaderky · 6 ✖

issue 1

  • Minimum versions for optional libraries · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
537862374 https://github.com/pydata/xarray/issues/3222#issuecomment-537862374 https://api.github.com/repos/pydata/xarray/issues/3222 MDEyOklzc3VlQ29tbWVudDUzNzg2MjM3NA== crusaderky 6213168 2019-10-03T09:18:41Z 2019-10-03T09:18:41Z MEMBER

scipy 1.1 and 1.2 break numpy 1.14 due to a conflict on openblas. We're stuck with 1.0 at least until the next numpy upgrade.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Minimum versions for optional libraries 481250429
537853919 https://github.com/pydata/xarray/issues/3222#issuecomment-537853919 https://api.github.com/repos/pydata/xarray/issues/3222 MDEyOklzc3VlQ29tbWVudDUzNzg1MzkxOQ== crusaderky 6213168 2019-10-03T08:55:56Z 2019-10-03T08:55:56Z MEMBER

Ok, bumping pandas to >=0.24 and scipy to >=1.2

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Minimum versions for optional libraries 481250429
537131190 https://github.com/pydata/xarray/issues/3222#issuecomment-537131190 https://api.github.com/repos/pydata/xarray/issues/3222 MDEyOklzc3VlQ29tbWVudDUzNzEzMTE5MA== crusaderky 6213168 2019-10-01T17:03:28Z 2019-10-01T17:03:28Z MEMBER

I slightly misinterpreted NEP-29. The above should be rectified:

pandas: 24 months (>=0.21) scipy: 24 months (>=1.0)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Minimum versions for optional libraries 481250429
536772940 https://github.com/pydata/xarray/issues/3222#issuecomment-536772940 https://api.github.com/repos/pydata/xarray/issues/3222 MDEyOklzc3VlQ29tbWVudDUzNjc3Mjk0MA== crusaderky 6213168 2019-09-30T22:08:27Z 2019-09-30T22:08:27Z MEMBER

Revised proposal (in parenthesis: minimum version if this policy were to be applied right now):

  • Python: NEP-29; 42 months (>=3.6)
  • numpy: NEP-29; 24 months (>=1.14)
  • pandas: 24 months (>=0.20)
  • scipy: 24 months (>=0.19)
  • NEP18 packages (sparse, pint, etc.): very latest available only, at least until the technology has reasonably matured across the whole ecosystem. This extends to dask when used in conjunction with any of these packages. numpy >=1.17. A very recent version of pandas may also be required if necessary.
  • all other packages: 6 months or the latest available in the anaconda (not conda-forge) repository if it exists, whatever is older.

Note: patch versions are not pinned. This means that the minimum python version that is guaranteed to work is actually 3.6.7 or 3.6.9, not 3.6.0.

What are people's thoughts?

It may also be a cool idea to write a script that parses the requirements yml files and generates .rst documentation out of them.

 
{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Minimum versions for optional libraries 481250429
535432625 https://github.com/pydata/xarray/issues/3222#issuecomment-535432625 https://api.github.com/repos/pydata/xarray/issues/3222 MDEyOklzc3VlQ29tbWVudDUzNTQzMjYyNQ== crusaderky 6213168 2019-09-26T09:59:50Z 2019-09-26T09:59:50Z MEMBER

@shoyer that sounds sensible, but only covers python and numpy. What about the rest? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Minimum versions for optional libraries 481250429
535115143 https://github.com/pydata/xarray/issues/3222#issuecomment-535115143 https://api.github.com/repos/pydata/xarray/issues/3222 MDEyOklzc3VlQ29tbWVudDUzNTExNTE0Mw== crusaderky 6213168 2019-09-25T16:57:36Z 2019-09-25T17:06:29Z MEMBER

How does this sound as a rolling policy? - Python: latest 2 major versions published in official anaconda releases (as opposed to just the conda repository), plus the latest major version available version in conda-forge. Latest available minimum versions. This today translates to =3.6 and =3.7 (with no minor versions, so actually 3.6.7 and 3.7.4); 3.8 to be added as soon as conda-forge rebuilds its own stack with it. - numpy, pandas, scipy: latest major version at least 1 year old; latest available minor version (which may be newer than 1 year old). Today this translates to numpy=1.15, pandas=0.23, scipy=1.1. - all other non-NEP18 packages: 6 months old major versions, or the latest available in the anaconda (not conda-forge) repository if it exists, whatever is older - NEP18 packages (sparse, pint, etc.): very latest available only, at least until the technology has reasonably matured across the whole ecosystem. This extends to dask when used to wrap NEP18 arrays. numpy >=1.17. - In all cases: older versions than those stated by the above policy can remain officially supported indefinitely, but only as long as doing so can be achieved trivially and doesn't slow development down.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Minimum versions for optional libraries 481250429

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);