home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

7 rows where issue = 481005183 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 4

  • aidanheerdegen 3
  • shoyer 2
  • max-sixty 1
  • pep8speaks 1

author_association 3

  • CONTRIBUTOR 3
  • MEMBER 3
  • NONE 1

issue 1

  • BUG: Fixes GH3215 · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
525607263 https://github.com/pydata/xarray/pull/3220#issuecomment-525607263 https://api.github.com/repos/pydata/xarray/issues/3220 MDEyOklzc3VlQ29tbWVudDUyNTYwNzI2Mw== shoyer 1217238 2019-08-28T06:45:41Z 2019-08-28T06:45:41Z MEMBER

thanks @aidanheerdegen !

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  BUG: Fixes GH3215 481005183
525585853 https://github.com/pydata/xarray/pull/3220#issuecomment-525585853 https://api.github.com/repos/pydata/xarray/issues/3220 MDEyOklzc3VlQ29tbWVudDUyNTU4NTg1Mw== pep8speaks 24736507 2019-08-28T05:05:41Z 2019-08-28T06:29:45Z NONE

Hello @aidanheerdegen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-08-28 06:29:45 UTC
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  BUG: Fixes GH3215 481005183
525588616 https://github.com/pydata/xarray/pull/3220#issuecomment-525588616 https://api.github.com/repos/pydata/xarray/issues/3220 MDEyOklzc3VlQ29tbWVudDUyNTU4ODYxNg== aidanheerdegen 6063709 2019-08-28T05:20:40Z 2019-08-28T05:20:40Z CONTRIBUTOR

Thanks @shoyer. I have added a test. It contains no assertion, but does fail with AttributeError: 'Array' object has no attribute 'tolist' without the code update. Is that sufficient?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  BUG: Fixes GH3215 481005183
525576296 https://github.com/pydata/xarray/pull/3220#issuecomment-525576296 https://api.github.com/repos/pydata/xarray/issues/3220 MDEyOklzc3VlQ29tbWVudDUyNTU3NjI5Ng== shoyer 1217238 2019-08-28T04:10:48Z 2019-08-28T04:10:48Z MEMBER

When you write a dataset to a dict, the dask arrays are converted into NumPy arrays. Try something like xarray.decode_cf(xarray.Dataset.from_dict(ds.to_dict()).chunk())

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  BUG: Fixes GH3215 481005183
525543137 https://github.com/pydata/xarray/pull/3220#issuecomment-525543137 https://api.github.com/repos/pydata/xarray/issues/3220 MDEyOklzc3VlQ29tbWVudDUyNTU0MzEzNw== aidanheerdegen 6063709 2019-08-28T01:15:25Z 2019-08-28T01:15:25Z CONTRIBUTOR

I can save the decoded version to a file and read it back in and it throws the error. I suppose this is traversing a different code path ```

xarray.decode_cf(xarray.Dataset.from_dict(ds.to_dict())) <xarray.Dataset> Dimensions: (time: 5) Coordinates: * time (time) object 2198-07-02 12:00:00 ... 2202-07-02 12:00:00 Data variables: average_T1 (time) datetime64[ns] ... xarray.decode_cf(xarray.Dataset.from_dict(ds.to_dict())).to_netcdf('tmp.nc') xarray.decode_cf(xarray.open_mfdataset('tmp.nc',decode_cf=False)) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/conventions.py", line 479, in decode_cf decode_coords, drop_variables=drop_variables, use_cftime=use_cftime) File "/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/conventions.py", line 401, in decode_cf_variables stack_char_dim=stack_char_dim, use_cftime=use_cftime) File "/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/conventions.py", line 306, in decode_cf_variable var = coder.decode(var, name=name) File "/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/coding/times.py", line 419, in decode self.use_cftime) File "/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/coding/times.py", line 90, in _decode_cf_datetime_dtype last_item(values) or [0]]) File "/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/core/formatting.py", line 99, in last_item return np.ravel(array[indexer]).tolist() AttributeError: 'Array' object has no attribute 'tolist'

```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  BUG: Fixes GH3215 481005183
525538937 https://github.com/pydata/xarray/pull/3220#issuecomment-525538937 https://api.github.com/repos/pydata/xarray/issues/3220 MDEyOklzc3VlQ29tbWVudDUyNTUzODkzNw== aidanheerdegen 6063709 2019-08-28T00:53:53Z 2019-08-28T00:53:53Z CONTRIBUTOR

HI @max-sixty. I am working on making a test, but when I serialise my test file so it is suitable for inclusion in a test it doesn't throw an error! ```

ds = xarray.open_mfdataset('temp_049.nc', decode_cf=False) xarray.decode_cf(ds) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/conventions.py", line 479, in decode_cf decode_coords, drop_variables=drop_variables, use_cftime=use_cftime) File "/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/conventions.py", line 401, in decode_cf_variables stack_char_dim=stack_char_dim, use_cftime=use_cftime) File "/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/conventions.py", line 306, in decode_cf_variable var = coder.decode(var, name=name) File "/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/coding/times.py", line 419, in decode self.use_cftime) File "/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/coding/times.py", line 90, in _decode_cf_datetime_dtype last_item(values) or [0]]) File "/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/core/formatting.py", line 99, in last_item return np.ravel(array[indexer]).tolist() AttributeError: 'Array' object has no attribute 'tolist' xarray.decode_cf(xarray.Dataset.from_dict(ds.to_dict())) <xarray.Dataset> Dimensions: (time: 5) Coordinates: * time (time) object 2198-07-02 12:00:00 ... 2202-07-02 12:00:00 Data variables: average_T1 (time) datetime64[ns] ... ds.identical(xarray.Dataset.from_dict(ds.to_dict())) True

`` SeemsDataset.identicalis failing to find something that traversingdecode_cf` does. Odd.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  BUG: Fixes GH3215 481005183
524468175 https://github.com/pydata/xarray/pull/3220#issuecomment-524468175 https://api.github.com/repos/pydata/xarray/issues/3220 MDEyOklzc3VlQ29tbWVudDUyNDQ2ODE3NQ== max-sixty 5635139 2019-08-23T21:28:39Z 2019-08-23T21:28:39Z MEMBER

Hi @aidanheerdegen - apologies no one followed up on this for a few days. Thank you for the contribution!

Could you add a test?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  BUG: Fixes GH3215 481005183

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 87.292ms · About: xarray-datasette