issue_comments

Table actions

4 rows where issue = 479932490 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Array formatting fixes for sparse and NEP-18 arrays. · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
520666608 https://github.com/pydata/xarray/pull/3211#issuecomment-520666608 https://api.github.com/repos/pydata/xarray/issues/3211 MDEyOklzc3VlQ29tbWVudDUyMDY2NjYwOA== pep8speaks 24736507 2019-08-13T02:41:49Z 2019-08-15T20:33:51Z NONE

Hello @shoyer! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 962:89: E501 line too long (90 > 88 characters)

Line 101:89: E501 line too long (91 > 88 characters) Line 102:89: E501 line too long (95 > 88 characters)

Line 193:89: E501 line too long (91 > 88 characters) Line 194:89: E501 line too long (89 > 88 characters)

Comment last updated at 2019-08-15 20:33:50 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Array formatting fixes for sparse and NEP-18 arrays. 479932490
521722962 https://github.com/pydata/xarray/pull/3211#issuecomment-521722962 https://api.github.com/repos/pydata/xarray/issues/3211 MDEyOklzc3VlQ29tbWVudDUyMTcyMjk2Mg== crusaderky 6213168 2019-08-15T17:19:27Z 2019-08-15T17:19:27Z MEMBER

Re legacy dask: #3222

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Array formatting fixes for sparse and NEP-18 arrays. 479932490
521507669 https://github.com/pydata/xarray/pull/3211#issuecomment-521507669 https://api.github.com/repos/pydata/xarray/issues/3211 MDEyOklzc3VlQ29tbWVudDUyMTUwNzY2OQ== shoyer 1217238 2019-08-15T04:17:43Z 2019-08-15T04:17:43Z MEMBER
  • Take a slice from the front of sparse arrays, densify it, and show the array contents just like you can see them for dense arrays

This is a good idea, but it will require slightly more complex logic to pull items only from the front of an array. I don't have a lot of time to iterate on this right now, so I'm going to leave it for later.

Represent dask arrays differently when they have a sparse _meta

I have now added in meta to the repr for dask arrays. PTAL.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Array formatting fixes for sparse and NEP-18 arrays. 479932490
521231183 https://github.com/pydata/xarray/pull/3211#issuecomment-521231183 https://api.github.com/repos/pydata/xarray/issues/3211 MDEyOklzc3VlQ29tbWVudDUyMTIzMTE4Mw== crusaderky 6213168 2019-08-14T12:46:44Z 2019-08-14T12:46:44Z MEMBER

Possible improvements:

  • Take a slice from the front of sparse arrays, densify it, and show the array contents just like you can see them for dense arrays
  • Represent dask arrays differently when they have a sparse _meta
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Array formatting fixes for sparse and NEP-18 arrays. 479932490

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);