issue_comments

Table actions

3 rows where issue = 479420466 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Accessors are recreated on every access · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
520287442 https://github.com/pydata/xarray/issues/3205#issuecomment-520287442 https://api.github.com/repos/pydata/xarray/issues/3205 MDEyOklzc3VlQ29tbWVudDUyMDI4NzQ0Mg== shoyer 1217238 2019-08-12T03:00:49Z 2019-08-12T03:00:49Z MEMBER

I'm leaning towards (1), unfortunately.

Xarray's data model doesn't keep around the DataArray objects that are part of a Dataset, only Variable objects. So even if we cached DataArray objects on a Dataset, they would get lost as soon as you do any sort of more complex computation or data manipulation.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Accessors are recreated on every access 479420466
520285297 https://github.com/pydata/xarray/issues/3205#issuecomment-520285297 https://api.github.com/repos/pydata/xarray/issues/3205 MDEyOklzc3VlQ29tbWVudDUyMDI4NTI5Nw== djhoese 1828519 2019-08-12T02:37:46Z 2019-08-12T02:37:46Z CONTRIBUTOR

So I guess the questions are:

  1. Is creating a new DataArray for Dataset.__getitem__ important enough that the above behavior is expected and should be documented as a known limitation/gotcha? Or...

  2. Accessors should work when used like this and the Dataset.__getitem__ creation of DataArrays should be "fixed" or worked around to handle this better?

  3. Or some other option?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Accessors are recreated on every access 479420466
520274338 https://github.com/pydata/xarray/issues/3205#issuecomment-520274338 https://api.github.com/repos/pydata/xarray/issues/3205 MDEyOklzc3VlQ29tbWVudDUyMDI3NDMzOA== shoyer 1217238 2019-08-12T00:33:13Z 2019-08-12T00:33:13Z MEMBER

My guess is that Dataset.__getitem__ is recreating the DataArray every time from the underlying Variable object which means ds['a'] is not ds['a']?

Yes, I believe this is the case.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Accessors are recreated on every access 479420466

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);