issue_comments

Table actions

7 rows where issue = 475730053 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

issue 1

  • Add join='override' · 7 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
522169407 https://github.com/pydata/xarray/pull/3175#issuecomment-522169407 https://api.github.com/repos/pydata/xarray/issues/3175 MDEyOklzc3VlQ29tbWVudDUyMjE2OTQwNw== dcherian 2448579 2019-08-16T22:23:31Z 2019-08-16T22:23:31Z MEMBER

Great, thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add join='override' 475730053
521819111 https://github.com/pydata/xarray/pull/3175#issuecomment-521819111 https://api.github.com/repos/pydata/xarray/issues/3175 MDEyOklzc3VlQ29tbWVudDUyMTgxOTExMQ== max-sixty 5635139 2019-08-15T22:26:00Z 2019-08-15T22:26:00Z MEMBER

Yes agree! Thanks @dcherian !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add join='override' 475730053
521816407 https://github.com/pydata/xarray/pull/3175#issuecomment-521816407 https://api.github.com/repos/pydata/xarray/issues/3175 MDEyOklzc3VlQ29tbWVudDUyMTgxNjQwNw== shoyer 1217238 2019-08-15T22:14:24Z 2019-08-15T22:14:24Z MEMBER

LGTM -- anyone else have opinions here?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add join='override' 475730053
520465887 https://github.com/pydata/xarray/pull/3175#issuecomment-520465887 https://api.github.com/repos/pydata/xarray/issues/3175 MDEyOklzc3VlQ29tbWVudDUyMDQ2NTg4Nw== dcherian 2448579 2019-08-12T15:10:17Z 2019-08-12T15:10:17Z MEMBER

Ready for review.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add join='override' 475730053
520022848 https://github.com/pydata/xarray/pull/3175#issuecomment-520022848 https://api.github.com/repos/pydata/xarray/issues/3175 MDEyOklzc3VlQ29tbWVudDUyMDAyMjg0OA== crusaderky 6213168 2019-08-09T18:39:31Z 2019-08-09T18:40:03Z MEMBER

Lazy-loading indices, plus this and #3102, would probably solve #2039. Without lazy-loading, an ad-hoc hack needs to be implemented in open_mfdataset directly...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add join='override' 475730053
519938082 https://github.com/pydata/xarray/pull/3175#issuecomment-519938082 https://api.github.com/repos/pydata/xarray/issues/3175 MDEyOklzc3VlQ29tbWVudDUxOTkzODA4Mg== dcherian 2448579 2019-08-09T14:21:53Z 2019-08-09T14:21:53Z MEMBER

Ah, good point. Do you have any thoughts on the implementation? or on the compat='override' proposal in https://github.com/pydata/xarray/issues/2064#issuecomment-519149757

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add join='override' 475730053
519830804 https://github.com/pydata/xarray/pull/3175#issuecomment-519830804 https://api.github.com/repos/pydata/xarray/issues/3175 MDEyOklzc3VlQ29tbWVudDUxOTgzMDgwNA== crusaderky 6213168 2019-08-09T08:27:39Z 2019-08-09T08:33:31Z MEMBER

Hi,

This doesn't close #2039 because

  • ~~open_mfdataset does not offer a 'join' parameter to be propagated to align~~ [EDIT] I just saw #3102, sorry
  • ~~even if it did,~~ by when open_mfdataset invokes align time has already been wasted because indices, as of today, are eagerly loaded by open_dataset
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add join='override' 475730053

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);