issue_comments

Table actions

3 rows where issue = 471409673 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Out of date docstring for concat_dim in open_mfdataset · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
876062035 https://github.com/pydata/xarray/issues/3158#issuecomment-876062035 https://api.github.com/repos/pydata/xarray/issues/3158 MDEyOklzc3VlQ29tbWVudDg3NjA2MjAzNQ== stale[bot] 26384082 2021-07-08T02:06:45Z 2021-07-08T02:06:45Z NONE

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity

If this issue remains relevant, please comment here or remove the stale label; otherwise it will be marked as closed automatically

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Out of date docstring for concat_dim in open_mfdataset 471409673
514118022 https://github.com/pydata/xarray/issues/3158#issuecomment-514118022 https://api.github.com/repos/pydata/xarray/issues/3158 MDEyOklzc3VlQ29tbWVudDUxNDExODAyMg== TomNicholas 35968931 2019-07-23T08:53:50Z 2019-07-23T08:53:50Z MEMBER

Thanks @zdgriffith. Yes it would be clearer to make that distinction. How about just adding a line:

concat_dim : str, or list of str, DataArray, Index or None, optional Dimensions to concatenate files along. You only need to provide this argument if any of the dimensions along which you want to concatenate is not a dimension in the original datasets, e.g., if you want to stack a collection of 2D arrays along a third dimension. Required for combine='nested', but not used for combine='by_coords'. ...

as None is a valid input, wouldn't it make more sense as an optional argument?

The reason it's not an optional argument to combine_nested is because currently None tells combine_nested to do something specific: merge datasets along that axis of the input instead of concatenating them. This is useful when you want to combine by some combination of concatenation and merging.

That's what

Set concat_dim=[..., None, ...] explicitly to disable concatenation along a particular dimension.

is supposed to be getting at, but obviously also needs to be clearer. Note None is only a valid input because it gets converted to [None] internally for convenience.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Out of date docstring for concat_dim in open_mfdataset 471409673
514004558 https://github.com/pydata/xarray/issues/3158#issuecomment-514004558 https://api.github.com/repos/pydata/xarray/issues/3158 MDEyOklzc3VlQ29tbWVudDUxNDAwNDU1OA== zdgriffith 17169544 2019-07-23T00:26:14Z 2019-07-23T00:26:14Z CONTRIBUTOR

A related question - concat_dim is a required argument in the parent function combine_nested (and therefore required here when combine='nested'). But as None is a valid input, wouldn't it make more sense as an optional argument?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Out of date docstring for concat_dim in open_mfdataset 471409673

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);