issue_comments

Table actions

2 rows where issue = 470712573 and user = 32473508 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • HasanAhmadQ7 · 2 ✖

issue 1

  • BUG fix +test .sel method gives error with float32 values · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
517995453 https://github.com/pydata/xarray/pull/3153#issuecomment-517995453 https://api.github.com/repos/pydata/xarray/issues/3153 MDEyOklzc3VlQ29tbWVudDUxNzk5NTQ1Mw== HasanAhmadQ7 32473508 2019-08-04T11:29:44Z 2019-08-04T11:30:48Z CONTRIBUTOR

@shoyer A fix in pandas that I can imagine is to modify the pd.Index to retain the dtype similar to the PandasIndexAdapter in xarray/core/indexing. However, it seems to me that their design it to coerce any float to float64, so I did not feel they would consider this to be a bug. I would try to dig into such solution more if you recommend so.

I added a test case in which the coords are float16 (in addiction to the scalar case)to show that casting to the coords type is required.

The lowest level in which I can access the coords type is in the indexing/remap_label_indexers where I could get the coords from the data_obj. In the latest code, casting is done just before calling convert_label_indexer

Sorry if I am missing the point, and thank you in advance for any further feedback.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG fix +test .sel method gives error with float32 values 470712573
515919693 https://github.com/pydata/xarray/pull/3153#issuecomment-515919693 https://api.github.com/repos/pydata/xarray/issues/3153 MDEyOklzc3VlQ29tbWVudDUxNTkxOTY5Mw== HasanAhmadQ7 32473508 2019-07-29T09:33:25Z 2019-07-29T09:34:07Z CONTRIBUTOR

@shoyer @max-sixty I really appreciate your time and feedback. I will work on it within a week.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG fix +test .sel method gives error with float32 values 470712573

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);