issue_comments

Table actions

8 rows where issue = 469117528 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • .sel method gives error with float32 values · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
517989768 https://github.com/pydata/xarray/issues/3137#issuecomment-517989768 https://api.github.com/repos/pydata/xarray/issues/3137 MDEyOklzc3VlQ29tbWVudDUxNzk4OTc2OA== HasanAhmadQ7 32473508 2019-08-04T09:59:21Z 2019-08-04T09:59:21Z CONTRIBUTOR

The case also arises if coords are float16. e.g.

data_values = np.arange(4) coord_values_16 = np.asarray(float_values, dtype='float16') array_16 = DataArray(data_values, [('float16_coord', coord_values_16)]) array_16.sel(float16_coord=float_values[1:3])

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .sel method gives error with float32 values 469117528
515626172 https://github.com/pydata/xarray/issues/3137#issuecomment-515626172 https://api.github.com/repos/pydata/xarray/issues/3137 MDEyOklzc3VlQ29tbWVudDUxNTYyNjE3Mg== HasanAhmadQ7 32473508 2019-07-26T23:16:22Z 2019-07-26T23:16:32Z CONTRIBUTOR

@dcherian I sent a PR last week. Any feedback would be appreciated 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .sel method gives error with float32 values 469117528
512794689 https://github.com/pydata/xarray/issues/3137#issuecomment-512794689 https://api.github.com/repos/pydata/xarray/issues/3137 MDEyOklzc3VlQ29tbWVudDUxMjc5NDY4OQ== dcherian 2448579 2019-07-18T12:29:29Z 2019-07-18T12:29:29Z MEMBER

@HasanAhmadQ7 go for it!

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
   .sel method gives error with float32 values 469117528
512711316 https://github.com/pydata/xarray/issues/3137#issuecomment-512711316 https://api.github.com/repos/pydata/xarray/issues/3137 MDEyOklzc3VlQ29tbWVudDUxMjcxMTMxNg== HasanAhmadQ7 32473508 2019-07-18T08:06:46Z 2019-07-18T08:06:46Z CONTRIBUTOR

@dcherian I would like to send a PR and work on this issue if there is no problem in this.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
   .sel method gives error with float32 values 469117528
512684896 https://github.com/pydata/xarray/issues/3137#issuecomment-512684896 https://api.github.com/repos/pydata/xarray/issues/3137 MDEyOklzc3VlQ29tbWVudDUxMjY4NDg5Ng== hdsingh 30382331 2019-07-18T06:35:43Z 2019-07-18T06:35:43Z NONE

As of now I am a bit short on time due to GSOC project. I may not be able to look into this for next 2-3 weeks.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .sel method gives error with float32 values 469117528
512610043 https://github.com/pydata/xarray/issues/3137#issuecomment-512610043 https://api.github.com/repos/pydata/xarray/issues/3137 MDEyOklzc3VlQ29tbWVudDUxMjYxMDA0Mw== dcherian 2448579 2019-07-17T23:48:57Z 2019-07-17T23:48:57Z MEMBER

@hdsingh Any interest in sending in a PR?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .sel method gives error with float32 values 469117528
512360313 https://github.com/pydata/xarray/issues/3137#issuecomment-512360313 https://api.github.com/repos/pydata/xarray/issues/3137 MDEyOklzc3VlQ29tbWVudDUxMjM2MDMxMw== shoyer 1217238 2019-07-17T16:41:42Z 2019-07-17T16:41:42Z MEMBER

da.sel(a=np.float32(0.111)) works so maybe we should cast to the dtype of the coordinate?

Sounds like a good idea to me!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .sel method gives error with float32 values 469117528
512346644 https://github.com/pydata/xarray/issues/3137#issuecomment-512346644 https://api.github.com/repos/pydata/xarray/issues/3137 MDEyOklzc3VlQ29tbWVudDUxMjM0NjY0NA== dcherian 2448579 2019-07-17T16:05:10Z 2019-07-17T16:05:10Z MEMBER

da.sel(a=np.float32(0.111)) works so maybe we should cast to the dtype of the coordinate?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .sel method gives error with float32 values 469117528

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);