issue_comments

Table actions

10 rows where issue = 467908830 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • WIP: tutorial on merging datasets · 10 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
875136135 https://github.com/pydata/xarray/pull/3131#issuecomment-875136135 https://api.github.com/repos/pydata/xarray/issues/3131 MDEyOklzc3VlQ29tbWVudDg3NTEzNjEzNQ== andersy005 13301940 2021-07-06T22:57:29Z 2021-07-06T22:57:29Z MEMBER

@rabernat, the gentlest of bumps on this :)... How much work (content) is left to bring this to completion? I'm asking because I'd be happy to help if there's still more work and/or follow-up PR needed. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: tutorial on merging datasets 467908830
637570480 https://github.com/pydata/xarray/pull/3131#issuecomment-637570480 https://api.github.com/repos/pydata/xarray/issues/3131 MDEyOklzc3VlQ29tbWVudDYzNzU3MDQ4MA== dcherian 2448579 2020-06-02T14:13:44Z 2020-06-02T14:13:44Z MEMBER

Thanks @keewis !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: tutorial on merging datasets 467908830
637545516 https://github.com/pydata/xarray/pull/3131#issuecomment-637545516 https://api.github.com/repos/pydata/xarray/issues/3131 MDEyOklzc3VlQ29tbWVudDYzNzU0NTUxNg== keewis 14808389 2020-06-02T13:33:31Z 2020-06-02T13:33:31Z MEMBER

@rabernat, I did the rebase for this and #3111, so when you eventually pick this up again, a simple merge should get this up-to-date with master

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: tutorial on merging datasets 467908830
511253002 https://github.com/pydata/xarray/pull/3131#issuecomment-511253002 https://api.github.com/repos/pydata/xarray/issues/3131 MDEyOklzc3VlQ29tbWVudDUxMTI1MzAwMg== codecov[bot] 22429695 2019-07-15T01:32:30Z 2020-06-02T13:24:36Z NONE

Codecov Report

Merging #3131 into scipy19-docs will decrease coverage by 0.16%. The diff coverage is n/a.

```diff @@ Coverage Diff @@

scipy19-docs #3131 +/-

================================================ - Coverage 96.18% 96.02% -0.17%
================================================ Files 66 63 -3
Lines 13858 12799 -1059
================================================ - Hits 13330 12290 -1040
+ Misses 528 509 -19
```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: tutorial on merging datasets 467908830
630228624 https://github.com/pydata/xarray/pull/3131#issuecomment-630228624 https://api.github.com/repos/pydata/xarray/issues/3131 MDEyOklzc3VlQ29tbWVudDYzMDIyODYyNA== keewis 14808389 2020-05-18T14:42:08Z 2020-05-18T14:42:33Z MEMBER

we should rebase this and #3111 onto master so we don't depend on the old scipy19-docs branch. If we want to continue having a separate development branch for documentation, I think we should use one that is kept in sync with current master.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: tutorial on merging datasets 467908830
630209431 https://github.com/pydata/xarray/pull/3131#issuecomment-630209431 https://api.github.com/repos/pydata/xarray/issues/3131 MDEyOklzc3VlQ29tbWVudDYzMDIwOTQzMQ== keewis 14808389 2020-05-18T14:13:06Z 2020-05-18T14:13:06Z MEMBER

err, sorry, no. That happened because I deleted the branch you tried to merge into. Let me try to fix that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: tutorial on merging datasets 467908830
630208018 https://github.com/pydata/xarray/pull/3131#issuecomment-630208018 https://api.github.com/repos/pydata/xarray/issues/3131 MDEyOklzc3VlQ29tbWVudDYzMDIwODAxOA== rabernat 1197350 2020-05-18T14:10:34Z 2020-05-18T14:10:34Z MEMBER

I am still hoping to finish this one day. Any reason it needs to be closed?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: tutorial on merging datasets 467908830
512355490 https://github.com/pydata/xarray/pull/3131#issuecomment-512355490 https://api.github.com/repos/pydata/xarray/issues/3131 MDEyOklzc3VlQ29tbWVudDUxMjM1NTQ5MA== shoyer 1217238 2019-07-17T16:28:31Z 2019-07-17T16:28:31Z MEMBER

It is possible that we do actually need a third combine mode that works like the old auto_combine.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: tutorial on merging datasets 467908830
512353104 https://github.com/pydata/xarray/pull/3131#issuecomment-512353104 https://api.github.com/repos/pydata/xarray/issues/3131 MDEyOklzc3VlQ29tbWVudDUxMjM1MzEwNA== TomNicholas 35968931 2019-07-17T16:22:26Z 2019-07-17T16:22:26Z MEMBER

Nor am I. I originally thought it should be 'nested' because the concat-in-order behaviour is more similar to the original auto_combine, but I don't know.

It seems to me like it depends on the quality of user's data: if they have high-quality datasets which already have sensible coordinates for each dimension then' by_coords' is best, but if their data is more primitive without coordinates (like mine happens to be) then 'nested' is the most natural default. So do we have a sense of what the largest number of users would find most natural? Or is this not a good way to think about it?

On Wed, 17 Jul 2019, 16:05 Stephan Hoyer, notifications@github.com wrote:

I think "by_coords" is probably the most user friendly default for open_mfdataset? But I'm not entirely sure...

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/3131?email_source=notifications&email_token=AISNPI47L2F45PAJVZX6CHTP74YNFA5CNFSM4IDSQHX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2EQLPA#issuecomment-512296380, or mute the thread https://github.com/notifications/unsubscribe-auth/AISNPI4UBJO5K5NAC65VURTP74YNFANCNFSM4IDSQHXQ . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: tutorial on merging datasets 467908830
512296380 https://github.com/pydata/xarray/pull/3131#issuecomment-512296380 https://api.github.com/repos/pydata/xarray/issues/3131 MDEyOklzc3VlQ29tbWVudDUxMjI5NjM4MA== shoyer 1217238 2019-07-17T15:05:47Z 2019-07-17T15:05:47Z MEMBER

I think "by_coords" is probably the most user friendly default for open_mfdataset? But I'm not entirely sure...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: tutorial on merging datasets 467908830

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);