issue_comments

Table actions

6 rows where issue = 467897998 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Merge broadcast_like docstrings, analyze implementation problem · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
511916643 https://github.com/pydata/xarray/pull/3130#issuecomment-511916643 https://api.github.com/repos/pydata/xarray/issues/3130 MDEyOklzc3VlQ29tbWVudDUxMTkxNjY0Mw== shoyer 1217238 2019-07-16T17:43:57Z 2019-07-16T17:43:57Z MEMBER

thanks @DavidMertz and @dcherian !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Merge broadcast_like docstrings, analyze implementation problem 467897998
511245920 https://github.com/pydata/xarray/pull/3130#issuecomment-511245920 https://api.github.com/repos/pydata/xarray/issues/3130 MDEyOklzc3VlQ29tbWVudDUxMTI0NTkyMA== codecov[bot] 22429695 2019-07-15T00:00:06Z 2019-07-15T14:47:51Z NONE

Codecov Report

Merging #3130 into master will decrease coverage by 0.28%. The diff coverage is 100%.

```diff @@ Coverage Diff @@

master #3130 +/-

========================================== - Coverage 95.99% 95.71% -0.29%
========================================== Files 63 63
Lines 12799 12799
========================================== - Hits 12287 12250 -37
- Misses 512 549 +37 ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Merge broadcast_like docstrings, analyze implementation problem 467897998
511245138 https://github.com/pydata/xarray/pull/3130#issuecomment-511245138 https://api.github.com/repos/pydata/xarray/issues/3130 MDEyOklzc3VlQ29tbWVudDUxMTI0NTEzOA== pep8speaks 24736507 2019-07-14T23:45:36Z 2019-07-15T14:37:23Z NONE

Hello @DavidMertz! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-07-15 14:37:22 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Merge broadcast_like docstrings, analyze implementation problem 467897998
511251879 https://github.com/pydata/xarray/pull/3130#issuecomment-511251879 https://api.github.com/repos/pydata/xarray/issues/3130 MDEyOklzc3VlQ29tbWVudDUxMTI1MTg3OQ== dcherian 2448579 2019-07-15T01:20:21Z 2019-07-15T01:20:21Z MEMBER

Thanks for catching that @DavidMertz. Can you add back the original, simpler test too? This one is really just testing align. You could use @pytest.mark.parametrize to provide two different sets of arr1, arr2 arguments.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Merge broadcast_like docstrings, analyze implementation problem 467897998
511250197 https://github.com/pydata/xarray/pull/3130#issuecomment-511250197 https://api.github.com/repos/pydata/xarray/issues/3130 MDEyOklzc3VlQ29tbWVudDUxMTI1MDE5Nw== DavidMertz 2380665 2019-07-15T01:00:09Z 2019-07-15T01:00:39Z CONTRIBUTOR

Made changes suggested by @dcherian. This resolves the detected bug in the test. If CI passes, this should be ready to merge. Removed the temporary method .broadcast_like_naive() and the test using it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Merge broadcast_like docstrings, analyze implementation problem 467897998
511247968 https://github.com/pydata/xarray/pull/3130#issuecomment-511247968 https://api.github.com/repos/pydata/xarray/issues/3130 MDEyOklzc3VlQ29tbWVudDUxMTI0Nzk2OA== dcherian 2448579 2019-07-15T00:29:33Z 2019-07-15T00:32:02Z MEMBER

Thanks @DavidMertz

Line 2042 of dataset.py should be return _broadcast_helper(args[1], exclude, dims_map, common_coords) i.e. args[1] instead of self.

Can you make that change (and the same change in dataarray.py, Line 1019)?

EDIT: I made the dataarray change directly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Merge broadcast_like docstrings, analyze implementation problem 467897998

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);