issue_comments

Table actions

8 rows where issue = 467856339 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Fix tests on big-endian systems · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
511551723 https://github.com/pydata/xarray/pull/3125#issuecomment-511551723 https://api.github.com/repos/pydata/xarray/issues/3125 MDEyOklzc3VlQ29tbWVudDUxMTU1MTcyMw== ginggs 1970404 2019-07-15T20:12:59Z 2019-07-15T20:12:59Z CONTRIBUTOR

@max-sixty done in #3135

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix tests on big-endian systems 467856339
511527376 https://github.com/pydata/xarray/pull/3125#issuecomment-511527376 https://api.github.com/repos/pydata/xarray/issues/3125 MDEyOklzc3VlQ29tbWVudDUxMTUyNzM3Ng== max-sixty 5635139 2019-07-15T18:58:45Z 2019-07-15T18:58:45Z MEMBER

@ginggs if you're up for adding a whatsnew (and give yourself credit), please do!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix tests on big-endian systems 467856339
511527137 https://github.com/pydata/xarray/pull/3125#issuecomment-511527137 https://api.github.com/repos/pydata/xarray/issues/3125 MDEyOklzc3VlQ29tbWVudDUxMTUyNzEzNw== shoyer 1217238 2019-07-15T18:58:03Z 2019-07-15T18:58:03Z MEMBER

Thanks @ginggs !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix tests on big-endian systems 467856339
511465018 https://github.com/pydata/xarray/pull/3125#issuecomment-511465018 https://api.github.com/repos/pydata/xarray/issues/3125 MDEyOklzc3VlQ29tbWVudDUxMTQ2NTAxOA== shoyer 1217238 2019-07-15T16:06:03Z 2019-07-15T16:06:03Z MEMBER

I don't suppose any of platforms Azure pipelines offers for tests are big-endian? https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops#software

I'm guessing not, which is a bit of a shame, but that shouldn't stop us from merging this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix tests on big-endian systems 467856339
511459360 https://github.com/pydata/xarray/pull/3125#issuecomment-511459360 https://api.github.com/repos/pydata/xarray/issues/3125 MDEyOklzc3VlQ29tbWVudDUxMTQ1OTM2MA== ginggs 1970404 2019-07-15T15:51:34Z 2019-07-15T15:51:34Z CONTRIBUTOR

@max-sixty

Yes, #2334 is still relevant, I recently rebased and added another XFAIL for a new test.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix tests on big-endian systems 467856339
511453317 https://github.com/pydata/xarray/pull/3125#issuecomment-511453317 https://api.github.com/repos/pydata/xarray/issues/3125 MDEyOklzc3VlQ29tbWVudDUxMTQ1MzMxNw== max-sixty 5635139 2019-07-15T15:36:17Z 2019-07-15T15:36:17Z MEMBER

Thanks @ginggs

Is your PR here still relevant? https://github.com/pydata/xarray/pull/2334. I'm sorry no one reviewed that. This isn't my area of expertise; @pydata/xarray is there another member of the team who would be able to help? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix tests on big-endian systems 467856339
511215490 https://github.com/pydata/xarray/pull/3125#issuecomment-511215490 https://api.github.com/repos/pydata/xarray/issues/3125 MDEyOklzc3VlQ29tbWVudDUxMTIxNTQ5MA== codecov[bot] 22429695 2019-07-14T16:13:26Z 2019-07-14T16:39:46Z NONE

Codecov Report

Merging #3125 into master will not change coverage. The diff coverage is n/a.

```diff @@ Coverage Diff @@

master #3125 +/-

======================================= Coverage 95.98% 95.98%
======================================= Files 63 63
Lines 12777 12777
======================================= Hits 12264 12264
Misses 513 513 ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix tests on big-endian systems 467856339
511214600 https://github.com/pydata/xarray/pull/3125#issuecomment-511214600 https://api.github.com/repos/pydata/xarray/issues/3125 MDEyOklzc3VlQ29tbWVudDUxMTIxNDYwMA== pep8speaks 24736507 2019-07-14T16:01:16Z 2019-07-14T16:19:10Z NONE

Hello @ginggs! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-07-14 16:19:09 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix tests on big-endian systems 467856339

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);