home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

9 rows where issue = 467773069 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 5

  • dcherian 4
  • rdrussotto 2
  • max-sixty 1
  • codecov[bot] 1
  • pep8speaks 1

author_association 3

  • MEMBER 5
  • CONTRIBUTOR 2
  • NONE 2

issue 1

  • Clarify apply_ufunc error message (Issue #2078) · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
524425603 https://github.com/pydata/xarray/pull/3119#issuecomment-524425603 https://api.github.com/repos/pydata/xarray/issues/3119 MDEyOklzc3VlQ29tbWVudDUyNDQyNTYwMw== dcherian 2448579 2019-08-23T18:56:09Z 2019-08-23T18:56:09Z MEMBER

Yay! Thanks @rdrussotto

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Clarify apply_ufunc error message (Issue #2078) 467773069
511158633 https://github.com/pydata/xarray/pull/3119#issuecomment-511158633 https://api.github.com/repos/pydata/xarray/issues/3119 MDEyOklzc3VlQ29tbWVudDUxMTE1ODYzMw== pep8speaks 24736507 2019-07-13T22:36:49Z 2019-08-23T18:27:49Z NONE

Hello @rdrussotto! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-08-23 18:27:49 UTC
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Clarify apply_ufunc error message (Issue #2078) 467773069
524410174 https://github.com/pydata/xarray/pull/3119#issuecomment-524410174 https://api.github.com/repos/pydata/xarray/issues/3119 MDEyOklzc3VlQ29tbWVudDUyNDQxMDE3NA== dcherian 2448579 2019-08-23T18:07:53Z 2019-08-23T18:07:53Z MEMBER

You just need to run black xarray/core/computation.py

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Clarify apply_ufunc error message (Issue #2078) 467773069
524407480 https://github.com/pydata/xarray/pull/3119#issuecomment-524407480 https://api.github.com/repos/pydata/xarray/issues/3119 MDEyOklzc3VlQ29tbWVudDUyNDQwNzQ4MA== rdrussotto 13667821 2019-08-23T17:59:28Z 2019-08-23T17:59:28Z CONTRIBUTOR

I tried to resolve the merge conflicts but given the tests don't pass I might have messed something up...

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Clarify apply_ufunc error message (Issue #2078) 467773069
524050044 https://github.com/pydata/xarray/pull/3119#issuecomment-524050044 https://api.github.com/repos/pydata/xarray/issues/3119 MDEyOklzc3VlQ29tbWVudDUyNDA1MDA0NA== max-sixty 5635139 2019-08-22T19:46:48Z 2019-08-22T19:46:48Z MEMBER

Thanks @rdrussotto - there are now a couple of small merge conflicts - could you resolve? Then we can merge

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Clarify apply_ufunc error message (Issue #2078) 467773069
524049301 https://github.com/pydata/xarray/pull/3119#issuecomment-524049301 https://api.github.com/repos/pydata/xarray/issues/3119 MDEyOklzc3VlQ29tbWVudDUyNDA0OTMwMQ== rdrussotto 13667821 2019-08-22T19:44:53Z 2019-08-22T19:44:53Z CONTRIBUTOR

I agree with the suggested change, just committed it.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Clarify apply_ufunc error message (Issue #2078) 467773069
511159523 https://github.com/pydata/xarray/pull/3119#issuecomment-511159523 https://api.github.com/repos/pydata/xarray/issues/3119 MDEyOklzc3VlQ29tbWVudDUxMTE1OTUyMw== codecov[bot] 22429695 2019-07-13T22:57:36Z 2019-08-08T16:03:06Z NONE

Codecov Report

Merging #3119 into master will increase coverage by 27.47%. The diff coverage is n/a.

```diff @@ Coverage Diff @@

master #3119 +/-

========================================== + Coverage 68.52% 96% +27.47%
========================================== Files 64 63 -1
Lines 13100 12777 -323
========================================== + Hits 8977 12266 +3289
+ Misses 4123 511 -3612 ```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Clarify apply_ufunc error message (Issue #2078) 467773069
517730261 https://github.com/pydata/xarray/pull/3119#issuecomment-517730261 https://api.github.com/repos/pydata/xarray/issues/3119 MDEyOklzc3VlQ29tbWVudDUxNzczMDI2MQ== dcherian 2448579 2019-08-02T14:51:43Z 2019-08-02T14:51:43Z MEMBER

The test failure should be fixed by merging master.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Clarify apply_ufunc error message (Issue #2078) 467773069
517730011 https://github.com/pydata/xarray/pull/3119#issuecomment-517730011 https://api.github.com/repos/pydata/xarray/issues/3119 MDEyOklzc3VlQ29tbWVudDUxNzczMDAxMQ== dcherian 2448579 2019-08-02T14:51:05Z 2019-08-02T14:51:05Z MEMBER

Thanks @rdrussotto. Do you like the suggested change? If so, commit that and I'll merge.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Clarify apply_ufunc error message (Issue #2078) 467773069

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 14.271ms · About: xarray-datasette