issue_comments

Table actions

10 rows where issue = 467756080 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • More annotations in Dataset · 10 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
516952010 https://github.com/pydata/xarray/pull/3112#issuecomment-516952010 https://api.github.com/repos/pydata/xarray/issues/3112 MDEyOklzc3VlQ29tbWVudDUxNjk1MjAxMA== max-sixty 5635139 2019-07-31T17:48:19Z 2019-07-31T17:48:19Z MEMBER

Thanks again for the PR

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More annotations in Dataset 467756080
516951853 https://github.com/pydata/xarray/pull/3112#issuecomment-516951853 https://api.github.com/repos/pydata/xarray/issues/3112 MDEyOklzc3VlQ29tbWVudDUxNjk1MTg1Mw== max-sixty 5635139 2019-07-31T17:47:56Z 2019-07-31T17:47:56Z MEMBER

Sorry @crusaderky - we were all waiting on each other! My mistake

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More annotations in Dataset 467756080
516920645 https://github.com/pydata/xarray/pull/3112#issuecomment-516920645 https://api.github.com/repos/pydata/xarray/issues/3112 MDEyOklzc3VlQ29tbWVudDUxNjkyMDY0NQ== crusaderky 6213168 2019-07-31T16:21:33Z 2019-07-31T16:21:33Z MEMBER

@max-sixty @shoyer can we merge please?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More annotations in Dataset 467756080
511508383 https://github.com/pydata/xarray/pull/3112#issuecomment-511508383 https://api.github.com/repos/pydata/xarray/issues/3112 MDEyOklzc3VlQ29tbWVudDUxMTUwODM4Mw== pep8speaks 24736507 2019-07-15T18:04:37Z 2019-07-24T22:54:48Z NONE

Hello @crusaderky! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-07-24 22:54:48 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More annotations in Dataset 467756080
514800845 https://github.com/pydata/xarray/pull/3112#issuecomment-514800845 https://api.github.com/repos/pydata/xarray/issues/3112 MDEyOklzc3VlQ29tbWVudDUxNDgwMDg0NQ== shoyer 1217238 2019-07-24T21:08:26Z 2019-07-24T21:08:26Z MEMBER

+1 please go ahead without me!

On Wed, Jul 24, 2019 at 9:53 AM Maximilian Roos notifications@github.com wrote:

Thanks @crusaderky https://github.com/crusaderky ! I think fine to merge given we've both reviewed

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/3112?email_source=notifications&email_token=AAJJFVQMF2SAWWTI66BFMGDQBCCJLA5CNFSM4IDA3ET2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2W6OCY#issuecomment-514713355, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJJFVR5RRGF4CGOGIDDU63QBCCJLANCNFSM4IDA3ETQ . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More annotations in Dataset 467756080
514713355 https://github.com/pydata/xarray/pull/3112#issuecomment-514713355 https://api.github.com/repos/pydata/xarray/issues/3112 MDEyOklzc3VlQ29tbWVudDUxNDcxMzM1NQ== max-sixty 5635139 2019-07-24T16:53:39Z 2019-07-24T16:53:39Z MEMBER

Thanks @crusaderky ! I think fine to merge given we've both reviewed

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More annotations in Dataset 467756080
514552299 https://github.com/pydata/xarray/pull/3112#issuecomment-514552299 https://api.github.com/repos/pydata/xarray/issues/3112 MDEyOklzc3VlQ29tbWVudDUxNDU1MjI5OQ== crusaderky 6213168 2019-07-24T09:20:35Z 2019-07-24T09:20:35Z MEMBER

@shoyer this is ready for merge unless there are comments

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More annotations in Dataset 467756080
511147066 https://github.com/pydata/xarray/pull/3112#issuecomment-511147066 https://api.github.com/repos/pydata/xarray/issues/3112 MDEyOklzc3VlQ29tbWVudDUxMTE0NzA2Ng== codecov[bot] 22429695 2019-07-13T19:17:00Z 2019-07-19T09:24:47Z NONE

Codecov Report

Merging #3112 into master will decrease coverage by 0.04%. The diff coverage is 88.57%.

```diff @@ Coverage Diff @@

master #3112 +/-

========================================== - Coverage 95.98% 95.94% -0.05%
========================================== Files 63 63
Lines 12802 12816 +14
========================================== + Hits 12288 12296 +8
- Misses 514 520 +6 ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More annotations in Dataset 467756080
511528707 https://github.com/pydata/xarray/pull/3112#issuecomment-511528707 https://api.github.com/repos/pydata/xarray/issues/3112 MDEyOklzc3VlQ29tbWVudDUxMTUyODcwNw== max-sixty 5635139 2019-07-15T19:02:20Z 2019-07-15T19:02:20Z MEMBER

Great! Agree re Optional, thanks for clearing up. Good to go from my end

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More annotations in Dataset 467756080
511231279 https://github.com/pydata/xarray/pull/3112#issuecomment-511231279 https://api.github.com/repos/pydata/xarray/issues/3112 MDEyOklzc3VlQ29tbWVudDUxMTIzMTI3OQ== crusaderky 6213168 2019-07-14T20:05:41Z 2019-07-14T20:05:41Z MEMBER

@shoyer @max-sixty ready for review and merge

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   More annotations in Dataset 467756080

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);