issue_comments

Table actions

5 rows where issue = 466750687 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • max-sixty · 5 ✖

issue 1

  • black formatting · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
519711789 https://github.com/pydata/xarray/issues/3092#issuecomment-519711789 https://api.github.com/repos/pydata/xarray/issues/3092 MDEyOklzc3VlQ29tbWVudDUxOTcxMTc4OQ== max-sixty 5635139 2019-08-08T22:34:53Z 2019-08-08T22:34:53Z MEMBER

Thanks @Zac-HD 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   black formatting 466750687
511553442 https://github.com/pydata/xarray/issues/3092#issuecomment-511553442 https://api.github.com/repos/pydata/xarray/issues/3092 MDEyOklzc3VlQ29tbWVudDUxMTU1MzQ0Mg== max-sixty 5635139 2019-07-15T20:17:40Z 2019-07-15T20:18:03Z MEMBER

I didn't know about isort, nice. However, from a very quick test, it's not compatible with black

There's a specific isort config that's compatible with black; this is what we use internally (there's a similar official version I believe):

[isort] default_section=THIRDPARTY force_grid_wrap=0 include_trailing_comma=True line_length=88 multi_line_output=3 use_parentheses=True

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   black formatting 466750687
511538661 https://github.com/pydata/xarray/issues/3092#issuecomment-511538661 https://api.github.com/repos/pydata/xarray/issues/3092 MDEyOklzc3VlQ29tbWVudDUxMTUzODY2MQ== max-sixty 5635139 2019-07-15T19:32:54Z 2019-07-15T19:32:54Z MEMBER

@shoyer great

TODOs (please add where I've missed)

  • [ ] Reformat code
  • [ ] CI checks
  • [ ] Short instructions for how to merge an existing PR (i.e. avoid manual merge resolution)
  • [ ] Black badge
  • [ ] Do we want to keep flake8 checks? Black is mostly stricter but not always, e.g. on lines at the end of files. (+0.3 from me to use only black and stop using flake8)
  • [ ] Do we want to include isort? (-0.1 from me, even though I like the tool)
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   black formatting 466750687
511439980 https://github.com/pydata/xarray/issues/3092#issuecomment-511439980 https://api.github.com/repos/pydata/xarray/issues/3092 MDEyOklzc3VlQ29tbWVudDUxMTQzOTk4MA== max-sixty 5635139 2019-07-15T15:03:22Z 2019-07-15T15:03:22Z MEMBER

I'm happy to do this today

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   black formatting 466750687
510525639 https://github.com/pydata/xarray/issues/3092#issuecomment-510525639 https://api.github.com/repos/pydata/xarray/issues/3092 MDEyOklzc3VlQ29tbWVudDUxMDUyNTYzOQ== max-sixty 5635139 2019-07-11T15:06:53Z 2019-07-11T15:06:53Z MEMBER

I would be v keen. I find it great. But I'm generally too keen on a) tools and b) changing everything at once, so I discount myself a bit here!

I don't think it's possible to apply incrementally, unfortunately (e.g. only on changed lines). So it would require a single sweeping change. Interested to know how other projects are handling. IIRC they're applying it to some parts of stdlib too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   black formatting 466750687

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);