issue_comments

Table actions

6 rows where issue = 464813332 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Add broadcast_like. · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
511235940 https://github.com/pydata/xarray/pull/3086#issuecomment-511235940 https://api.github.com/repos/pydata/xarray/issues/3086 MDEyOklzc3VlQ29tbWVudDUxMTIzNTk0MA== dcherian 2448579 2019-07-14T21:14:57Z 2019-07-14T21:14:57Z MEMBER

Sounds good. @DavidMertz's docs/tests are much better!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add broadcast_like. 464813332
511232644 https://github.com/pydata/xarray/pull/3086#issuecomment-511232644 https://api.github.com/repos/pydata/xarray/issues/3086 MDEyOklzc3VlQ29tbWVudDUxMTIzMjY0NA== shoyer 1217238 2019-07-14T20:24:38Z 2019-07-14T20:24:38Z MEMBER

thanks @dcherian !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add broadcast_like. 464813332
511232358 https://github.com/pydata/xarray/pull/3086#issuecomment-511232358 https://api.github.com/repos/pydata/xarray/issues/3086 MDEyOklzc3VlQ29tbWVudDUxMTIzMjM1OA== shoyer 1217238 2019-07-14T20:20:28Z 2019-07-14T20:20:28Z MEMBER

I'm merging this now, so @DavidMertz can put his doc/test improvements on top of it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add broadcast_like. 464813332
509269548 https://github.com/pydata/xarray/pull/3086#issuecomment-509269548 https://api.github.com/repos/pydata/xarray/issues/3086 MDEyOklzc3VlQ29tbWVudDUwOTI2OTU0OA== codecov[bot] 22429695 2019-07-08T15:18:30Z 2019-07-12T15:15:23Z NONE

Codecov Report

Merging #3086 into master will decrease coverage by 0.01%. The diff coverage is 98%.

```diff @@ Coverage Diff @@

master #3086 +/-

========================================== - Coverage 95.99% 95.98% -0.02%
========================================== Files 63 63
Lines 12792 12809 +17
========================================== + Hits 12280 12295 +15
- Misses 512 514 +2 ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add broadcast_like. 464813332
508893975 https://github.com/pydata/xarray/pull/3086#issuecomment-508893975 https://api.github.com/repos/pydata/xarray/issues/3086 MDEyOklzc3VlQ29tbWVudDUwODg5Mzk3NQ== pep8speaks 24736507 2019-07-06T03:38:14Z 2019-07-12T14:57:07Z NONE

Hello @dcherian! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-07-12 14:57:07 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add broadcast_like. 464813332
508970317 https://github.com/pydata/xarray/pull/3086#issuecomment-508970317 https://api.github.com/repos/pydata/xarray/issues/3086 MDEyOklzc3VlQ29tbWVudDUwODk3MDMxNw== shoyer 1217238 2019-07-07T04:20:06Z 2019-07-07T04:20:06Z MEMBER

In principle, it feels like it would be better to have both xarray.broadcast() and broadcast_like written in terms of a lower level helper method that broadcasts only one object. This is what we do for align/reindex_like, for example. But in practice this is certainly way easier to write and probably good enough...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add broadcast_like. 464813332

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);