issue_comments

Table actions

7 rows where issue = 464152437 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Fix printing summaries of multiindex coords · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
509133480 https://github.com/pydata/xarray/pull/3079#issuecomment-509133480 https://api.github.com/repos/pydata/xarray/issues/3079 MDEyOklzc3VlQ29tbWVudDUwOTEzMzQ4MA== pep8speaks 24736507 2019-07-08T08:36:46Z 2019-07-10T16:47:47Z NONE

Hello @coroa! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-07-10 16:47:47 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix printing summaries of multiindex coords 464152437
510123889 https://github.com/pydata/xarray/pull/3079#issuecomment-510123889 https://api.github.com/repos/pydata/xarray/issues/3079 MDEyOklzc3VlQ29tbWVudDUxMDEyMzg4OQ== shoyer 1217238 2019-07-10T16:01:16Z 2019-07-10T16:01:16Z MEMBER

thanks @coroa! this will be in the next xarray release

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix printing summaries of multiindex coords 464152437
509134882 https://github.com/pydata/xarray/pull/3079#issuecomment-509134882 https://api.github.com/repos/pydata/xarray/issues/3079 MDEyOklzc3VlQ29tbWVudDUwOTEzNDg4Mg== codecov[bot] 22429695 2019-07-08T08:41:00Z 2019-07-09T21:58:52Z NONE

Codecov Report

Merging #3079 into master will decrease coverage by 0.03%. The diff coverage is n/a.

```diff @@ Coverage Diff @@

master #3079 +/-

========================================== - Coverage 92.68% 92.65% -0.04%
========================================== Files 63 63
Lines 12773 12786 +13
Branches 2906 2906
========================================== + Hits 11839 11847 +8
- Misses 619 623 +4
- Partials 315 316 +1 ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix printing summaries of multiindex coords 464152437
509702300 https://github.com/pydata/xarray/pull/3079#issuecomment-509702300 https://api.github.com/repos/pydata/xarray/issues/3079 MDEyOklzc3VlQ29tbWVudDUwOTcwMjMwMA== dcherian 2448579 2019-07-09T15:57:36Z 2019-07-09T15:57:36Z MEMBER

@coroa you should give yourself credit in whats-new.rst

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix printing summaries of multiindex coords 464152437
509145346 https://github.com/pydata/xarray/pull/3079#issuecomment-509145346 https://api.github.com/repos/pydata/xarray/issues/3079 MDEyOklzc3VlQ29tbWVudDUwOTE0NTM0Ng== coroa 2552981 2019-07-08T09:10:54Z 2019-07-08T09:10:54Z CONTRIBUTOR

Ok, rebased on master, added tests. Was not sooo easy to make linter and pytest happy :), but we're there. Hope skipping E501 line too long (... > 79 characters) for the multiline test string is allowed.

https://github.com/pydata/xarray/blob/e4716a4c2b9df681eb9e43dd31a3c9ec6e104e44/xarray/tests/test_dataarray.py#L74-L81

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix printing summaries of multiindex coords 464152437
508970205 https://github.com/pydata/xarray/pull/3079#issuecomment-508970205 https://api.github.com/repos/pydata/xarray/issues/3079 MDEyOklzc3VlQ29tbWVudDUwODk3MDIwNQ== shoyer 1217238 2019-07-07T04:16:56Z 2019-07-07T04:16:56Z MEMBER

The test failures on pandas-dev are unrelated. If you merge in master, I believe they should be fixed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix printing summaries of multiindex coords 464152437
508970184 https://github.com/pydata/xarray/pull/3079#issuecomment-508970184 https://api.github.com/repos/pydata/xarray/issues/3079 MDEyOklzc3VlQ29tbWVudDUwODk3MDE4NA== shoyer 1217238 2019-07-07T04:16:24Z 2019-07-07T04:16:24Z MEMBER

Thanks @coroa. Would you mind adding a test to verify your fix? It could probably go alongside test_repr_multiindex: https://github.com/pydata/xarray/blob/23fc0d6f8a5affefb84e5f20dc0bef7ace4542e2/xarray/tests/test_dataarray.py#L57-L65

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix printing summaries of multiindex coords 464152437

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);