issue_comments

Table actions

3 rows where issue = 463021297 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • shoyer · 3 ✖

issue 1

  • Fix the ability to run network and flaky tests · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
508201730 https://github.com/pydata/xarray/pull/3070#issuecomment-508201730 https://api.github.com/repos/pydata/xarray/issues/3070 MDEyOklzc3VlQ29tbWVudDUwODIwMTczMA== shoyer 1217238 2019-07-03T18:14:49Z 2019-07-03T18:14:49Z MEMBER

I'm referring to the tests running on CI, e.g., "Linux py36-flakey" on Azure. If you look at the full logs from this PR (which I made verbose) and scroll down you see: xarray/tests/test_backends.py::TestPydapOnline::test_cmp_local_file SKIPPED [ 13%] xarray/tests/test_backends.py::TestPydapOnline::test_compatible_to_netcdf SKIPPED [ 13%] xarray/tests/test_backends.py::TestPydapOnline::test_dask SKIPPED [ 13%] xarray/tests/test_backends.py::TestPydapOnline::test_session SKIPPED [ 13%] So for some reason it's not doing flakey tests, even though in theory I'm passing the right flags for it: https://github.com/pydata/xarray/blob/681ec0e84af7c155b16ef46122e2a6cea64b585d/ci/azure/unit-tests.yml#L14

Actually, I definitely screwed this up. I should be using $PYTEST_EXTRA_FLAGS, not $EXTRA_FLAGS. Let me try fixing that...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix the ability to run network and flaky tests 463021297
507717430 https://github.com/pydata/xarray/pull/3070#issuecomment-507717430 https://api.github.com/repos/pydata/xarray/issues/3070 MDEyOklzc3VlQ29tbWVudDUwNzcxNzQzMA== shoyer 1217238 2019-07-02T15:03:53Z 2019-07-02T15:03:53Z MEMBER

Pytest reports the exact same number of tests passed, both with and without --run-network-tests. That seems suspicious to me.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix the ability to run network and flaky tests 463021297
507537223 https://github.com/pydata/xarray/pull/3070#issuecomment-507537223 https://api.github.com/repos/pydata/xarray/issues/3070 MDEyOklzc3VlQ29tbWVudDUwNzUzNzIyMw== shoyer 1217238 2019-07-02T06:24:15Z 2019-07-02T06:24:15Z MEMBER

Hmm... maybe it does work, at least in this. But we definitely aren't running the network tests, even with these changes (e.g., look at the TestPydapOnline tests). I'm not quite sure why.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix the ability to run network and flaky tests 463021297

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);