issue_comments

Table actions

4 rows where issue = 459569339 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

These facets timed out: author_association, issue

user 1

  • shoyer · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
506760236 https://github.com/pydata/xarray/pull/3039#issuecomment-506760236 https://api.github.com/repos/pydata/xarray/issues/3039 MDEyOklzc3VlQ29tbWVudDUwNjc2MDIzNg== shoyer 1217238 2019-06-28T14:44:53Z 2019-06-28T14:44:53Z MEMBER

For anyone else following along, this needed one more minor follow-on: https://github.com/pydata/xarray/pull/3052

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Set up CI with Azure Pipelines (and remove Appveyor) 459569339
506504319 https://github.com/pydata/xarray/pull/3039#issuecomment-506504319 https://api.github.com/repos/pydata/xarray/issues/3039 MDEyOklzc3VlQ29tbWVudDUwNjUwNDMxOQ== shoyer 1217238 2019-06-27T20:45:27Z 2019-06-27T20:45:27Z MEMBER

@max-sixty thanks for the review! I've gone ahead and removed the Appveyor hook, so it should be entirely gone now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Set up CI with Azure Pipelines (and remove Appveyor) 459569339
506417533 https://github.com/pydata/xarray/pull/3039#issuecomment-506417533 https://api.github.com/repos/pydata/xarray/issues/3039 MDEyOklzc3VlQ29tbWVudDUwNjQxNzUzMw== shoyer 1217238 2019-06-27T16:26:32Z 2019-06-27T16:26:32Z MEMBER

I think this is ready to merge, and probably worth doing soon given the broken state of our Appveyor config.

Switching away from Travis can wait until we figure out how to report coverage and are sure we've worked out the kinks. But it already seems a bit more usable -- Azure surfaces test failures much more prominently.

@max-sixty would you mind looking it over for any obvious issues?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Set up CI with Azure Pipelines (and remove Appveyor) 459569339
505095846 https://github.com/pydata/xarray/pull/3039#issuecomment-505095846 https://api.github.com/repos/pydata/xarray/issues/3039 MDEyOklzc3VlQ29tbWVudDUwNTA5NTg0Ng== shoyer 1217238 2019-06-24T17:04:03Z 2019-06-24T17:04:03Z MEMBER

OK, this is actually working pretty well now.

Azure Pipelines is has loads of concurrent builds with a longer time-out and lets us use a single CI platform for everything (Linux, Mac, Window). The output is also pretty reasonable, and well integrated with GitHub.

The only feature we're missing here is integration with Coveralls for coverage statistics. I haven't looked hard for a way to do that yet, though.

At the very last, I am tempted to merge this and turn off our use of Appveyor.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Set up CI with Azure Pipelines (and remove Appveyor) 459569339

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);